All of lore.kernel.org
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH 0/2] block/mirror: Make cancel always cancel pre-READY
@ 2018-05-01 22:05 Max Reitz
  2018-05-01 22:05 ` [Qemu-devel] [PATCH 1/2] " Max Reitz
                   ` (4 more replies)
  0 siblings, 5 replies; 9+ messages in thread
From: Max Reitz @ 2018-05-01 22:05 UTC (permalink / raw)
  To: qemu-block; +Cc: qemu-devel, Max Reitz, Jeff Cody, Kevin Wolf, John Snow

Currently, you cannot cancel a mirror job without the @force flag set.
This is intentional once source and target are in sync, but probably not
so much before that happens.  The main reason for me thinking this is
because it is an undocumented change in 2.12.0 in respect to 2.11.

(b76e4458b1eb3c32e9824fe6aa51f67d2b251748 only notes a behavior change
 after READY, but not before.)


This series depends on Stefan’s patch “block/mirror: honor ratelimit
again” (which is in Jeff’s queue).

Based-on: <20180424123527.19168-1-stefanha@redhat.com>


Max Reitz (2):
  block/mirror: Make cancel always cancel pre-READY
  iotests: Add test for cancelling a mirror job

 block/mirror.c             |   4 +-
 tests/qemu-iotests/218     | 138 +++++++++++++++++++++++++++++++++++++++++++++
 tests/qemu-iotests/218.out |  30 ++++++++++
 tests/qemu-iotests/group   |   1 +
 4 files changed, 172 insertions(+), 1 deletion(-)
 create mode 100755 tests/qemu-iotests/218
 create mode 100644 tests/qemu-iotests/218.out

-- 
2.14.3

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2018-05-02 17:36 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-01 22:05 [Qemu-devel] [PATCH 0/2] block/mirror: Make cancel always cancel pre-READY Max Reitz
2018-05-01 22:05 ` [Qemu-devel] [PATCH 1/2] " Max Reitz
2018-05-01 23:31   ` Eric Blake
2018-05-02 12:35     ` Max Reitz
2018-05-01 22:05 ` [Qemu-devel] [PATCH 2/2] iotests: Add test for cancelling a mirror job Max Reitz
2018-05-02 14:31   ` Jeff Cody
2018-05-01 23:29 ` [Qemu-devel] [PATCH 0/2] block/mirror: Make cancel always cancel pre-READY Eric Blake
2018-05-02 14:32 ` Jeff Cody
2018-05-02 17:36 ` John Snow

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.