From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E6C2C48BCD for ; Wed, 9 Jun 2021 16:50:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 81D3C613CB for ; Wed, 9 Jun 2021 16:50:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230268AbhFIQwn (ORCPT ); Wed, 9 Jun 2021 12:52:43 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:34916 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230242AbhFIQwl (ORCPT ); Wed, 9 Jun 2021 12:52:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623257446; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OrCtXf49JzCZn5dpJiNF9Oj4zY4Qes8vs6vhU+MkX5Y=; b=I0S0+PPe+5y1du0tN2jJ7TxFucVIy7rej8iVDH7PBG9tV9nxubDY2oWcSe64on7KFR+OPX 8wHILOnC/0xdakPgK20BGLh1h8pHLwkZUwHdN4b9LUBHQS9AfDCvKGHjyuLn/1a7EVjYMg dH9GqYzX2rGsKeohXlX40pVqJGGS6VQ= Received: from mail-oo1-f69.google.com (mail-oo1-f69.google.com [209.85.161.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-59-MyGz9V_ANlqcg2gvNVlqTw-1; Wed, 09 Jun 2021 12:50:43 -0400 X-MC-Unique: MyGz9V_ANlqcg2gvNVlqTw-1 Received: by mail-oo1-f69.google.com with SMTP id b9-20020a4a87890000b0290248cb841124so13778813ooi.4 for ; Wed, 09 Jun 2021 09:50:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=OrCtXf49JzCZn5dpJiNF9Oj4zY4Qes8vs6vhU+MkX5Y=; b=T3AKW1r4q5eR1FI50EE4mp2vyFidOhObFcnXQ1IpGHIMFQkLd1+IJmVuz89fb1u3W3 2DRxd5eNWsWiGWzhgfWIgzdC4iV1ujdDDHKrqDGpqP0OlR1qqMAzqdEzPlA9Jx2BD9ma VDB/HEfUakbCNYKPqH0p/Z9KdLsTINyh86xnz27EdfsH9o4POXCngiMjlzXGsWezgZw1 G6HwbscIsC9Q05Og39jybnDhWY54+OQMsmAo6xdlRhMR3Tt7F2J+j5/9HmV5PCE09UQU 23VujloN1L+pdXgH4Xmx7CvqCUvnRQWDxaOenjJNj0U++G6OARoPRykKoVLjVkuzfmyy YOqQ== X-Gm-Message-State: AOAM530XGXG4uQUbOQ+AO6namsTNUb+DxTS4iH7SyWwPmWhFd14wX9hw WNXUGmtt5fF9nzFDtesD6OMyFyc1ZnDHEr8KjiGbofzJcMhSQHJlXS7kCx8lolgin0IIgxuxeBl ALMvBapnA3z8KBqlO2uOr0tR6 X-Received: by 2002:a9d:4105:: with SMTP id o5mr316331ote.20.1623257442830; Wed, 09 Jun 2021 09:50:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxlqxLGv0YiZs5n6IvS0gh+tJjoLR7xG7pb5AgIFw1+rbYfRnBn+0w4EjGkNDFxCJKICpMBPw== X-Received: by 2002:a9d:4105:: with SMTP id o5mr316304ote.20.1623257442552; Wed, 09 Jun 2021 09:50:42 -0700 (PDT) Received: from localhost.localdomain (075-142-250-213.res.spectrum.com. [75.142.250.213]) by smtp.gmail.com with ESMTPSA id o21sm62806oie.34.2021.06.09.09.50.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Jun 2021 09:50:42 -0700 (PDT) Subject: Re: [PATCH v2 0/4] fpga: reorganize to subdirs To: Greg KH Cc: mdf@kernel.org, hao.wu@intel.com, michal.simek@xilinx.com, nava.manne@xilinx.com, dinguyen@kernel.org, krzysztof.kozlowski@canonical.com, yilun.xu@intel.com, arnd@arndb.de, fpacheco@redhat.com, richard.gong@intel.com, luca@lucaceresoli.net, linux-kernel@vger.kernel.org, linux-fpga@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20210609142208.3085451-1-trix@redhat.com> <2738ee7a-448f-c327-c430-13fb44da45ec@redhat.com> From: Tom Rix Message-ID: Date: Wed, 9 Jun 2021 09:50:39 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/9/21 9:38 AM, Greg KH wrote: > On Wed, Jun 09, 2021 at 08:08:06AM -0700, Tom Rix wrote: >> On 6/9/21 7:53 AM, Greg KH wrote: >>> On Wed, Jun 09, 2021 at 07:22:03AM -0700, trix@redhat.com wrote: >>>> From: Tom Rix >>>> >>>> The incoming xrt patchset has a toplevel subdir xrt/ >>>> The current fpga/ uses a single dir with filename prefixes to subdivide owners >>>> For consistency, there should be only one way to organize the fpga/ dir. >>>> Because the subdir model scales better, refactor to use it. >>>> The discussion wrt xrt is here: >>>> https://lore.kernel.org/linux-fpga/68e85a4f-4a10-1ff9-0443-aa565878c855@redhat.com/ >>>> >>>> Follow drivers/net/ethernet/ which has control configs >>>> NET_VENDOR_BLA that map to drivers/net/ethernet/bla >>>> Since fpgas do not have many vendors, drop the 'VENDOR' and use >>>> FPGA_BLA. >>>> >>>> There are several new subdirs >>>> altera/ >>>> dfl/ >>>> lattice/ >>>> xilinx/ >>>> >>>> Each subdir has a Kconfig that has a new/reused >>>> >>>> if FPGA_BLA >>>> ... existing configs ... >>>> endif FPGA_BLA >>>> >>>> Which is sourced into the main fpga/Kconfig >>>> >>>> Each subdir has a Makefile whose transversal is controlled in the >>>> fpga/Makefile by >>>> >>>> obj-$(CONFIG_FPGA_BLA) += bla/ >>>> >>>> Some cleanup to arrange thing alphabetically and make fpga/Makefile's >>>> whitespace look more like net/'s >>>> >>>> Changes from >>>> v1 >>>> Drop renaming files >>>> Cleanup makefiles >>> You can rename the files, you just can not rename the .ko objects >>> without everyone knowing what you are doing and you trying to bury it in >>> the middle of a differently described patch. >>> >>> If you want to do that, do you? I don't really understand why you want >>> to move things around right now other than "we have 40 files in one >>> directory, ick!". >> I am trying to resolve the layout inconsistency between what we have and >> what the xrt patchset does. > Why does it matter? New stuff can be added to a new dir, why worry > about old stuff? What does it hurt? > >> The big issue is the files vs dirs. >> >> Over specified filenames is secondary, so I dropped them. >> >> 40 files in one dir is itself not a problem. >> >> having 40 files and an xrt/ is. > Why is that a "problem"? > >> fpga/ layout should be consistent so the Makefile and Kconfig are easier to >> maintain. > Is it somehow hard to maintain today? Seems pretty trivial to me... This change was to help move xrt along. If you are fine with xrt/, I will drop this patchset. Tom > > thanks, > > greg k-h > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3052DC48BCF for ; Wed, 9 Jun 2021 17:34:58 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E8F6C613CB for ; Wed, 9 Jun 2021 17:34:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E8F6C613CB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=6GMlRedc8YRXLVx/oDgFcWecMYQrR5TU7oaoi3FN03Y=; b=4RSSF2ILPp9X5gMNZPlNZ8ZL1k deyfWyx1C/D5CJpiDS0fiX1DY13vGZJyeotyHYXoT7+hSb1P15Q4YuJ3EJNM7h6xz8czgGqVY3nRt Lji1vijwcogFRv5eDIRIhcK0gBCr+1scqdOp0RdE0YRsJB3ZBb7JcYh2994h5FR5GMBgQ89YH8EkH 6NjnltOQypaKrhIafdVspPVCJXHvfaUg+71wEzIznFa5afVpztkRsg813BB6TXwmfGpXj1Cy7d6mW UPykYKZ1JCHyOrQwsJn6dJ0Zx5RRsxuVt8c+oq1OHRa0MK8D5pS2RfG1gKcJZXexncv21gsUJoyTf NskJX5Xw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lr242-00FJzu-6G; Wed, 09 Jun 2021 17:32:29 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lr1Pi-00F3uV-Gx for linux-arm-kernel@lists.infradead.org; Wed, 09 Jun 2021 16:50:49 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623257444; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OrCtXf49JzCZn5dpJiNF9Oj4zY4Qes8vs6vhU+MkX5Y=; b=TgeRZ9wLHh00XQce9/PMIw5GPcXz0z9tsBgHdEnBGBJp/CbcaCfivUQyRWGtKm2xOtAmzS FTormIkqIn1ADeYs4FTgeradE3s79we+GZP+UuIVnqPK/esjldvwf2jG0p9qyComIZNlyS 9hAQ2aTRixKD7zEhEDdEgCvVx410nOg= Received: from mail-oi1-f199.google.com (mail-oi1-f199.google.com [209.85.167.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-516-_SX4pg4JP_e9wGGP-uwu9Q-1; Wed, 09 Jun 2021 12:50:43 -0400 X-MC-Unique: _SX4pg4JP_e9wGGP-uwu9Q-1 Received: by mail-oi1-f199.google.com with SMTP id x125-20020aca31830000b02901f1c37dd8c9so1130033oix.8 for ; Wed, 09 Jun 2021 09:50:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=OrCtXf49JzCZn5dpJiNF9Oj4zY4Qes8vs6vhU+MkX5Y=; b=X61NFnWLHP1/GVnxY8yLG/bkBGUawESfcvYd7lkVwkbpIqJqURuV/cfe2xzew77tE9 qznmV57U93D/jF+IqZSltppbc/BTkNTAt+KMVJZdqDU9kkRFfGRyo667SIrvK0WbLrpU FGIxRFPaq/VjNs8qbhGpDie4KEBkCcBXkb0jb2Ozc/3Rurhzd1fzo+BjFI/lkOGae89t ITcqiqmzh+0tRr/JFLsWTFiSx8nuaC3g/d4wcubMpbGodCcv7nJZxATbod1G+54hg8q6 UYQQl42E0JlLKGljdAzM5q8Ypq6VXnzGrwqXyEEHNEnV7or+kz8IshjvR06MqDyUKKNP r3JQ== X-Gm-Message-State: AOAM5322qWLfslABXzSrImrXb1iYl9wQ7pdOcsGTPVSUP5Xtx8qQDVxS wOFhaVVNBPupOFyHLIrQ/Wf4hIoUVl7swZg4rIuvqsNqaG9spJTMo1hXO9mCpUdz2ZkF232M0N0 ki7gFArI8vc1pkbNeFLcZuNw6uyhmeUE/DfEWR3JxnO5tvV+r8I2TpOYF97OpiAt7mQOFNfJztZ ncpCsCeg== X-Received: by 2002:a9d:4105:: with SMTP id o5mr316336ote.20.1623257442892; Wed, 09 Jun 2021 09:50:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxlqxLGv0YiZs5n6IvS0gh+tJjoLR7xG7pb5AgIFw1+rbYfRnBn+0w4EjGkNDFxCJKICpMBPw== X-Received: by 2002:a9d:4105:: with SMTP id o5mr316304ote.20.1623257442552; Wed, 09 Jun 2021 09:50:42 -0700 (PDT) Received: from localhost.localdomain (075-142-250-213.res.spectrum.com. [75.142.250.213]) by smtp.gmail.com with ESMTPSA id o21sm62806oie.34.2021.06.09.09.50.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Jun 2021 09:50:42 -0700 (PDT) Subject: Re: [PATCH v2 0/4] fpga: reorganize to subdirs To: Greg KH Cc: mdf@kernel.org, hao.wu@intel.com, michal.simek@xilinx.com, nava.manne@xilinx.com, dinguyen@kernel.org, krzysztof.kozlowski@canonical.com, yilun.xu@intel.com, arnd@arndb.de, fpacheco@redhat.com, richard.gong@intel.com, luca@lucaceresoli.net, linux-kernel@vger.kernel.org, linux-fpga@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20210609142208.3085451-1-trix@redhat.com> <2738ee7a-448f-c327-c430-13fb44da45ec@redhat.com> From: Tom Rix Message-ID: Date: Wed, 9 Jun 2021 09:50:39 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=trix@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210609_095046_680192_74178A1B X-CRM114-Status: GOOD ( 22.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 6/9/21 9:38 AM, Greg KH wrote: > On Wed, Jun 09, 2021 at 08:08:06AM -0700, Tom Rix wrote: >> On 6/9/21 7:53 AM, Greg KH wrote: >>> On Wed, Jun 09, 2021 at 07:22:03AM -0700, trix@redhat.com wrote: >>>> From: Tom Rix >>>> >>>> The incoming xrt patchset has a toplevel subdir xrt/ >>>> The current fpga/ uses a single dir with filename prefixes to subdivide owners >>>> For consistency, there should be only one way to organize the fpga/ dir. >>>> Because the subdir model scales better, refactor to use it. >>>> The discussion wrt xrt is here: >>>> https://lore.kernel.org/linux-fpga/68e85a4f-4a10-1ff9-0443-aa565878c855@redhat.com/ >>>> >>>> Follow drivers/net/ethernet/ which has control configs >>>> NET_VENDOR_BLA that map to drivers/net/ethernet/bla >>>> Since fpgas do not have many vendors, drop the 'VENDOR' and use >>>> FPGA_BLA. >>>> >>>> There are several new subdirs >>>> altera/ >>>> dfl/ >>>> lattice/ >>>> xilinx/ >>>> >>>> Each subdir has a Kconfig that has a new/reused >>>> >>>> if FPGA_BLA >>>> ... existing configs ... >>>> endif FPGA_BLA >>>> >>>> Which is sourced into the main fpga/Kconfig >>>> >>>> Each subdir has a Makefile whose transversal is controlled in the >>>> fpga/Makefile by >>>> >>>> obj-$(CONFIG_FPGA_BLA) += bla/ >>>> >>>> Some cleanup to arrange thing alphabetically and make fpga/Makefile's >>>> whitespace look more like net/'s >>>> >>>> Changes from >>>> v1 >>>> Drop renaming files >>>> Cleanup makefiles >>> You can rename the files, you just can not rename the .ko objects >>> without everyone knowing what you are doing and you trying to bury it in >>> the middle of a differently described patch. >>> >>> If you want to do that, do you? I don't really understand why you want >>> to move things around right now other than "we have 40 files in one >>> directory, ick!". >> I am trying to resolve the layout inconsistency between what we have and >> what the xrt patchset does. > Why does it matter? New stuff can be added to a new dir, why worry > about old stuff? What does it hurt? > >> The big issue is the files vs dirs. >> >> Over specified filenames is secondary, so I dropped them. >> >> 40 files in one dir is itself not a problem. >> >> having 40 files and an xrt/ is. > Why is that a "problem"? > >> fpga/ layout should be consistent so the Makefile and Kconfig are easier to >> maintain. > Is it somehow hard to maintain today? Seems pretty trivial to me... This change was to help move xrt along. If you are fine with xrt/, I will drop this patchset. Tom > > thanks, > > greg k-h > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel