From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [PATCH V2 7/8] scsi: hpsa: call hpsa_hba_inquiry() after adding host To: Ming Lei , Jens Axboe , linux-block@vger.kernel.org, Christoph Hellwig , Mike Snitzer Cc: linux-scsi@vger.kernel.org, Arun Easi , Omar Sandoval , "Martin K . Petersen" , James Bottomley , Christoph Hellwig , Don Brace , Kashyap Desai , Peter Rivera , Paolo Bonzini , Laurence Oberman References: <20180205152035.15016-1-ming.lei@redhat.com> <20180205152035.15016-8-ming.lei@redhat.com> From: Hannes Reinecke Message-ID: Date: Tue, 6 Feb 2018 09:32:02 +0100 MIME-Version: 1.0 In-Reply-To: <20180205152035.15016-8-ming.lei@redhat.com> Content-Type: text/plain; charset=utf-8 List-ID: On 02/05/2018 04:20 PM, Ming Lei wrote: > So that we can decide the default reply queue by the map created > during adding host. > > Cc: Hannes Reinecke > Cc: Arun Easi > Cc: Omar Sandoval , > Cc: "Martin K. Petersen" , > Cc: James Bottomley , > Cc: Christoph Hellwig , > Cc: Don Brace > Cc: Kashyap Desai > Cc: Peter Rivera > Cc: Paolo Bonzini > Cc: Mike Snitzer > Tested-by: Laurence Oberman > Signed-off-by: Ming Lei > --- > drivers/scsi/hpsa.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c > index 287e5eb0723f..443eabf63a9f 100644 > --- a/drivers/scsi/hpsa.c > +++ b/drivers/scsi/hpsa.c > @@ -8691,12 +8691,9 @@ static int hpsa_init_one(struct pci_dev *pdev, const struct pci_device_id *ent) > /* Disable discovery polling.*/ > h->discovery_polling = 0; > > - > /* Turn the interrupts on so we can service requests */ > h->access.set_intr_mask(h, HPSA_INTR_ON); > > - hpsa_hba_inquiry(h); > - > h->lastlogicals = kzalloc(sizeof(*(h->lastlogicals)), GFP_KERNEL); > if (!h->lastlogicals) > dev_info(&h->pdev->dev, > @@ -8707,6 +8704,8 @@ static int hpsa_init_one(struct pci_dev *pdev, const struct pci_device_id *ent) > if (rc) > goto clean7; /* perf, sg, cmd, irq, shost, pci, lu, aer/h */ > > + hpsa_hba_inquiry(h); > + > /* Monitor the controller for firmware lockups */ > h->heartbeat_sample_interval = HEARTBEAT_SAMPLE_INTERVAL; > INIT_DELAYED_WORK(&h->monitor_ctlr_work, hpsa_monitor_ctlr_worker); > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking hare@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg)