From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 124B0C43218 for ; Sat, 27 Apr 2019 17:27:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D0130206BB for ; Sat, 27 Apr 2019 17:27:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LsSfokzT" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726358AbfD0R1x (ORCPT ); Sat, 27 Apr 2019 13:27:53 -0400 Received: from mail-io1-f65.google.com ([209.85.166.65]:44918 "EHLO mail-io1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725983AbfD0R1x (ORCPT ); Sat, 27 Apr 2019 13:27:53 -0400 Received: by mail-io1-f65.google.com with SMTP id r71so5526060iod.11 for ; Sat, 27 Apr 2019 10:27:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=HsHkCbvzTHzIHJ/d31EanXYl1WIwjiDmcIayTb+VutM=; b=LsSfokzTW6pAjZ9LtRgCbqTkZ5XqxadhCsBvIghnt2onog5nS0zr2Mj+yoMr2Hl+gg u2ddyNQkGvYR9vgFN3jhsm2wkFJNsaXdbXWjCEpmdertH3A2ZN2kTtR2xkRlqEZgRX1x BQFo8JkrTJZWrqD7i8I03xrvFxsUK/YrFLxqiURq/nM4FF6nRofhCUpp+PSKv0BJ8cfN VTXAwrhu4y/gVNGBGjpYL4cvRFUlVYe+o2eVUcPP2P1UGoj7VjritRxBERIuc1/aYKAk 6Bo68VN+Qhy4n9bw+e7V4IJsJSf1bRlZ/fkYP+xGWLfyCR4m+inXzNXUNys41kkDM791 U+hA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=HsHkCbvzTHzIHJ/d31EanXYl1WIwjiDmcIayTb+VutM=; b=JhcS1+cc25TmHHwKRp0tVnqNzRv04Uqv1KEwTOsMF98CVcbzBwJ63U/hAFSRk+DJ/z +beQqZbdQlhuWMF8n9E2DKeAsswjpWdjkGf8fshp80/55XgYozuyJP9p03xgd41zavF9 JCxeQXcxCDRpf8oSJIosPYVXIlYlhi071QYIpVdmuM2UsLJuQ7UPwuTzP3L1ESjPqTPu eyNHV9Y0V2KVPhuYY9xx/4H3/Lmjtu7PomCnNNe8UsG706HX9nwqFBnL/Jh+1M6FvQ80 qHloN1aePnfzfD9YQB3aSXeGhq/2vpD4zJLHtckmEHFjS4M3nphZ7oDQWGfWlRy724JR p6zA== X-Gm-Message-State: APjAAAVHH8sHH52ZYOMKUlLp1vcJGx4LiUmtXnLc+2YK3bNt1uFBDQfB 50vUB/2fA3Ox2W2CFPEihcEHe+E2 X-Google-Smtp-Source: APXvYqyCBOJYX6USdeyikKqk4kDTWLRggaf+5+wF3H6Mie+hUP3kjvW+wB+cTACn1q8icmUNhd9/9Q== X-Received: by 2002:a6b:4f0f:: with SMTP id d15mr20615119iob.48.1556386072373; Sat, 27 Apr 2019 10:27:52 -0700 (PDT) Received: from ?IPv6:2601:282:800:fd80:7dcd:8cf4:8ba5:a6c? ([2601:282:800:fd80:7dcd:8cf4:8ba5:a6c]) by smtp.googlemail.com with ESMTPSA id g126sm13858591itg.36.2019.04.27.10.27.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 27 Apr 2019 10:27:51 -0700 (PDT) Subject: Re: [PATCH net,v3] vrf: Use orig netdev to count Ip6InNoRoutes and a fresh route lookup when sending dest unreach To: Stephen Suryaputra , netdev@vger.kernel.org References: <20190427131433.4082-1-ssuryaextr@gmail.com> From: David Ahern Message-ID: Date: Sat, 27 Apr 2019 11:27:49 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190427131433.4082-1-ssuryaextr@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 4/27/19 7:14 AM, Stephen Suryaputra wrote: > When there is no route to an IPv6 dest addr, skb_dst(skb) points > to loopback dev in the case of that the IP6CB(skb)->iif is > enslaved to a vrf. This causes Ip6InNoRoutes to be incremented on the > loopback dev. This also causes the lookup to fail on icmpv6_send() and > the dest unreachable to not sent and Ip6OutNoRoutes gets incremented on > the loopback dev. > > To reproduce: > * Gateway configuration: > ip link add dev vrf_258 type vrf table 258 > ip link set dev enp0s9 master vrf_258 > ip addr add 66:1/64 dev enp0s9 > ip -6 route add unreachable default metric 8192 table 258 > sysctl -w net.ipv6.conf.all.forwarding=1 > sysctl -w net.ipv6.conf.enp0s9.forwarding=1 > * Sender configuration: > ip addr add 66::2/64 dev enp0s9 > ip -6 route add default via 66::1 > and ping 67::1 for example from the sender. > > Fix this by counting on the original netdev and reset the skb dst to > force a fresh lookup. > > v2: Fix typo of destination address in the repro steps. > v3: Simplify the loopback check (per David Ahern) and use reverse > Christmas tree format (per David Miller). > > Signed-off-by: Stephen Suryaputra > Reviewed-by: David Ahern > Tested-by: David Ahern > --- > net/ipv6/route.c | 23 +++++++++++++++++------ > 1 file changed, 17 insertions(+), 6 deletions(-) > Reviewed-by: David Ahern