From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56B2FC43217 for ; Wed, 9 Mar 2022 08:47:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231440AbiCIIsf (ORCPT ); Wed, 9 Mar 2022 03:48:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35270 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231472AbiCIIsf (ORCPT ); Wed, 9 Mar 2022 03:48:35 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 1CBCB1D1 for ; Wed, 9 Mar 2022 00:47:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1646815653; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9ffS413S/InwxV5O0x2uo8HI1Zzb6CIePH7gzRiVJ4s=; b=V+04jHOUpCPsFFbOKblGYGp5MziBq6uaJiNeXLL0fLf1z2xIV0IDUzBTlhahmDpFaQICjH LhFGpbe9r2i+3tTIspUzxQturzmn4QFk3rpl7WcpGW+frLFsl6PAD3rNZSlAWh3b9TGeRQ HpawgMMl9aSpEdhwzomDtIpvMYCeMXY= Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-302-ZFLEG7pkPQKPos0FZFroCg-1; Wed, 09 Mar 2022 03:47:31 -0500 X-MC-Unique: ZFLEG7pkPQKPos0FZFroCg-1 Received: by mail-pl1-f199.google.com with SMTP id x6-20020a1709029a4600b0014efe26b04fso797623plv.21 for ; Wed, 09 Mar 2022 00:47:30 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=9ffS413S/InwxV5O0x2uo8HI1Zzb6CIePH7gzRiVJ4s=; b=1+vdSeSREMlF5/Thi2Tt1nLssKOrDYR9wRvAEocShOdLYzX1nN4hF7GEuovMWAtIga G7XbcB2k/dX2AqOY0lmVhpY5iwqJvx/CAAqIBNysFzPVp4P+AAo/sJZnVntlmP0jp2ro GNi+nkQKaMVQk0LzCXJnmUmJRLzseXHTRsoX6xooVYeCPgtZZyJpbg9ODL7fPj8xMxii XugrHKUE4apkLcrs/JHFOmks9HbncS/SgseILYdDBeZwIk4fM8gZkTTS3NcFYIzlfygk J4z7pGPzW7tnW6I+5bbj+gEneX4XAws4JQDR3mRNeU9XzpN/Vg2t0/RF2wJNChXFAbY6 +Beg== X-Gm-Message-State: AOAM533F9drq4sblJq1SiR1yNBJIKbq+s1CbvcqwDWJyPhVn0/VjSUKL 8Cx28UGND3k7Yk60G+4HLQdanJ+qy5MbS3GAYWJEINn6Ej3yyQ4ifaqqqop9WK4aHWRn4knDctA N66VNsC+AFz8gk4amTbsPjWcsaezd2w== X-Received: by 2002:a63:4756:0:b0:373:e14b:5848 with SMTP id w22-20020a634756000000b00373e14b5848mr17589440pgk.337.1646815649947; Wed, 09 Mar 2022 00:47:29 -0800 (PST) X-Google-Smtp-Source: ABdhPJy8AxlCNXVWTVj7iH9SvFqBnT+ALE8NBgyTqiezfIt6S/mnWP42+w8t2ODBwFju+xJKaGATOA== X-Received: by 2002:a63:4756:0:b0:373:e14b:5848 with SMTP id w22-20020a634756000000b00373e14b5848mr17589411pgk.337.1646815649649; Wed, 09 Mar 2022 00:47:29 -0800 (PST) Received: from [10.72.12.183] ([209.132.188.80]) by smtp.gmail.com with ESMTPSA id l17-20020a637011000000b0037d5eac87e3sm1577760pgc.18.2022.03.09.00.47.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Mar 2022 00:47:29 -0800 (PST) Message-ID: Date: Wed, 9 Mar 2022 16:47:11 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH v7 13/26] virtio: queue_reset: struct virtio_config_ops add callbacks for queue_reset Content-Language: en-US To: Xuan Zhuo , virtualization@lists.linux-foundation.org, netdev@vger.kernel.org Cc: Jeff Dike , Richard Weinberger , Anton Ivanov , "Michael S. Tsirkin" , "David S. Miller" , Jakub Kicinski , Hans de Goede , Mark Gross , Vadim Pasternak , Bjorn Andersson , Mathieu Poirier , Cornelia Huck , Halil Pasic , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Alexander Gordeev , Sven Schnelle , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Johannes Berg , Vincent Whitchurch , linux-um@lists.infradead.org, platform-driver-x86@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, kvm@vger.kernel.org, bpf@vger.kernel.org References: <20220308123518.33800-1-xuanzhuo@linux.alibaba.com> <20220308123518.33800-14-xuanzhuo@linux.alibaba.com> From: Jason Wang In-Reply-To: <20220308123518.33800-14-xuanzhuo@linux.alibaba.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org 在 2022/3/8 下午8:35, Xuan Zhuo 写道: > Performing reset on a queue is divided into four steps: > > 1. reset_vq() - notify the device to reset the queue > 2. virtqueue_detach_unused_buf() - recycle the buffer submitted > 3. virtqueue_reset_vring() - reset the vring (may re-alloc) > 4. enable_reset_vq() - mmap vring to device, and enable the queue > > So add two callbacks reset_vq, enable_reset_vq to struct > virtio_config_ops. > > Signed-off-by: Xuan Zhuo > --- > include/linux/virtio_config.h | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/include/linux/virtio_config.h b/include/linux/virtio_config.h > index 4d107ad31149..d51906b1389f 100644 > --- a/include/linux/virtio_config.h > +++ b/include/linux/virtio_config.h > @@ -74,6 +74,15 @@ struct virtio_shm_region { > * @set_vq_affinity: set the affinity for a virtqueue (optional). > * @get_vq_affinity: get the affinity for a virtqueue (optional). > * @get_shm_region: get a shared memory region based on the index. > + * @reset_vq: reset a queue individually (optional). > + * vq: the virtqueue > + * Returns 0 on success or error status > + * Caller should guarantee that the vring is not accessed by any functions > + * of virtqueue. We probably need to be more accurate here: 1) reset_vq will guarantee that the callbacks are disabled or synchronized 2) except for the callback, the caller should guarantee ... Thanks > + * @enable_reset_vq: enable a reset queue > + * vq: the virtqueue > + * Returns 0 on success or error status > + * If reset_vq is set, then enable_reset_vq must also be set. > */ > typedef void vq_callback_t(struct virtqueue *); > struct virtio_config_ops { > @@ -100,6 +109,8 @@ struct virtio_config_ops { > int index); > bool (*get_shm_region)(struct virtio_device *vdev, > struct virtio_shm_region *region, u8 id); > + int (*reset_vq)(struct virtqueue *vq); > + int (*enable_reset_vq)(struct virtqueue *vq); > }; > > /* If driver didn't advertise the feature, it will never appear. */ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A455DC433EF for ; Wed, 9 Mar 2022 08:47:37 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 36C57417CB; Wed, 9 Mar 2022 08:47:37 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JX_UTaQGfWCh; Wed, 9 Mar 2022 08:47:36 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp4.osuosl.org (Postfix) with ESMTPS id AFE86417B7; Wed, 9 Mar 2022 08:47:35 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 819C0C001D; Wed, 9 Mar 2022 08:47:35 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists.linuxfoundation.org (Postfix) with ESMTP id 07E77C000B for ; Wed, 9 Mar 2022 08:47:34 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id D9D8D84291 for ; Wed, 9 Mar 2022 08:47:33 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp1.osuosl.org (amavisd-new); dkim=pass (1024-bit key) header.d=redhat.com Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id j-V_HEE_eL7H for ; Wed, 9 Mar 2022 08:47:33 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by smtp1.osuosl.org (Postfix) with ESMTPS id 1F946828EF for ; Wed, 9 Mar 2022 08:47:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1646815652; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9ffS413S/InwxV5O0x2uo8HI1Zzb6CIePH7gzRiVJ4s=; b=Rwu3uEKXiY3vULpMLR0RIcM/P/wSI4F1NJkTUIWktGlJU9Eq3ESjd4L3dsZfrDYzMFMEuN WSfhYG63Qw8+iDjrwvNPVNglT7dr36vvxpvvWk+Id7csxdHqd6zzDHe9yuyoEE1QBCzq3G CVOFoQNo3X1fRk4PA40/BpLQXE0EbeU= Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-15-KBUUxur1O2ys2FyJOL7ktA-1; Wed, 09 Mar 2022 03:47:31 -0500 X-MC-Unique: KBUUxur1O2ys2FyJOL7ktA-1 Received: by mail-pj1-f72.google.com with SMTP id mm2-20020a17090b358200b001bf529127dfso1177500pjb.6 for ; Wed, 09 Mar 2022 00:47:30 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=9ffS413S/InwxV5O0x2uo8HI1Zzb6CIePH7gzRiVJ4s=; b=6HwickT06wOuw95jOinEqgBSAcvlCDk2ULfNbGbI8LD/U8kS3LysTXAwAD1FT4z/Fs 7gzMTRjsJnqP8XPx795BSNf7CAzrTSbea0WQp97FJis3hzUVNCBMbGTfG80hsFpSBTEY sRpfYCg6GdRsmDGaz+luzHKd2/wPcsF2HJvcFfirjLC9sp5Uoi9FrcWxmUWcS6SljjNv R49QjJ9xtALEr/uoS6jOQaknAD4mbgxfkkjVJ9U1aQYerVlJPqCVu5MKsW2YMCiImws5 V0tGwZ6mNLOXtNtRoMvrEtIB4Gc4vs6K6eNz8gZKapxYx/JSmWwQ9NTrwIDCFbSgWmwX 2Hcw== X-Gm-Message-State: AOAM530l3q4jn3dsZUBCY0ns68TekR+JjJuGyEKL1iISdEtPQhrNrExn qX/1UmGjul/MN4xESbk3SMZg03PBWaS4nBKA7jqWf5kxH22q4lJgsmKX3RU+ekuJ+8OCV5iyW0z iIwMEYIjVQmg5UHdhHmeIxOSAbTSgflzrsBsbEIi9GQ== X-Received: by 2002:a63:4756:0:b0:373:e14b:5848 with SMTP id w22-20020a634756000000b00373e14b5848mr17589451pgk.337.1646815649980; Wed, 09 Mar 2022 00:47:29 -0800 (PST) X-Google-Smtp-Source: ABdhPJy8AxlCNXVWTVj7iH9SvFqBnT+ALE8NBgyTqiezfIt6S/mnWP42+w8t2ODBwFju+xJKaGATOA== X-Received: by 2002:a63:4756:0:b0:373:e14b:5848 with SMTP id w22-20020a634756000000b00373e14b5848mr17589411pgk.337.1646815649649; Wed, 09 Mar 2022 00:47:29 -0800 (PST) Received: from [10.72.12.183] ([209.132.188.80]) by smtp.gmail.com with ESMTPSA id l17-20020a637011000000b0037d5eac87e3sm1577760pgc.18.2022.03.09.00.47.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Mar 2022 00:47:29 -0800 (PST) Message-ID: Date: Wed, 9 Mar 2022 16:47:11 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH v7 13/26] virtio: queue_reset: struct virtio_config_ops add callbacks for queue_reset To: Xuan Zhuo , virtualization@lists.linux-foundation.org, netdev@vger.kernel.org References: <20220308123518.33800-1-xuanzhuo@linux.alibaba.com> <20220308123518.33800-14-xuanzhuo@linux.alibaba.com> From: Jason Wang In-Reply-To: <20220308123518.33800-14-xuanzhuo@linux.alibaba.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jasowang@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Cc: Vadim Pasternak , "Michael S. Tsirkin" , linux-remoteproc@vger.kernel.org, Alexei Starovoitov , Bjorn Andersson , Alexander Gordeev , Anton Ivanov , linux-s390@vger.kernel.org, Johannes Berg , Daniel Borkmann , Richard Weinberger , Vincent Whitchurch , John Fastabend , Halil Pasic , Jakub Kicinski , Heiko Carstens , Jesper Dangaard Brouer , Vasily Gorbik , Jeff Dike , linux-um@lists.infradead.org, Mark Gross , Hans de Goede , kvm@vger.kernel.org, platform-driver-x86@vger.kernel.org, Mathieu Poirier , Cornelia Huck , Sven Schnelle , bpf@vger.kernel.org, "David S. Miller" X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" CuWcqCAyMDIyLzMvOCDkuIvljYg4OjM1LCBYdWFuIFpodW8g5YaZ6YGTOgo+IFBlcmZvcm1pbmcg cmVzZXQgb24gYSBxdWV1ZSBpcyBkaXZpZGVkIGludG8gZm91ciBzdGVwczoKPgo+ICAgMS4gcmVz ZXRfdnEoKSAgICAgICAgICAgICAgICAgICAgIC0gbm90aWZ5IHRoZSBkZXZpY2UgdG8gcmVzZXQg dGhlIHF1ZXVlCj4gICAyLiB2aXJ0cXVldWVfZGV0YWNoX3VudXNlZF9idWYoKSAgLSByZWN5Y2xl IHRoZSBidWZmZXIgc3VibWl0dGVkCj4gICAzLiB2aXJ0cXVldWVfcmVzZXRfdnJpbmcoKSAgICAg ICAgLSByZXNldCB0aGUgdnJpbmcgKG1heSByZS1hbGxvYykKPiAgIDQuIGVuYWJsZV9yZXNldF92 cSgpICAgICAgICAgICAgICAtIG1tYXAgdnJpbmcgdG8gZGV2aWNlLCBhbmQgZW5hYmxlIHRoZSBx dWV1ZQo+Cj4gU28gYWRkIHR3byBjYWxsYmFja3MgcmVzZXRfdnEsIGVuYWJsZV9yZXNldF92cSB0 byBzdHJ1Y3QKPiB2aXJ0aW9fY29uZmlnX29wcy4KPgo+IFNpZ25lZC1vZmYtYnk6IFh1YW4gWmh1 byA8eHVhbnpodW9AbGludXguYWxpYmFiYS5jb20+Cj4gLS0tCj4gICBpbmNsdWRlL2xpbnV4L3Zp cnRpb19jb25maWcuaCB8IDExICsrKysrKysrKysrCj4gICAxIGZpbGUgY2hhbmdlZCwgMTEgaW5z ZXJ0aW9ucygrKQo+Cj4gZGlmZiAtLWdpdCBhL2luY2x1ZGUvbGludXgvdmlydGlvX2NvbmZpZy5o IGIvaW5jbHVkZS9saW51eC92aXJ0aW9fY29uZmlnLmgKPiBpbmRleCA0ZDEwN2FkMzExNDkuLmQ1 MTkwNmIxMzg5ZiAxMDA2NDQKPiAtLS0gYS9pbmNsdWRlL2xpbnV4L3ZpcnRpb19jb25maWcuaAo+ ICsrKyBiL2luY2x1ZGUvbGludXgvdmlydGlvX2NvbmZpZy5oCj4gQEAgLTc0LDYgKzc0LDE1IEBA IHN0cnVjdCB2aXJ0aW9fc2htX3JlZ2lvbiB7Cj4gICAgKiBAc2V0X3ZxX2FmZmluaXR5OiBzZXQg dGhlIGFmZmluaXR5IGZvciBhIHZpcnRxdWV1ZSAob3B0aW9uYWwpLgo+ICAgICogQGdldF92cV9h ZmZpbml0eTogZ2V0IHRoZSBhZmZpbml0eSBmb3IgYSB2aXJ0cXVldWUgKG9wdGlvbmFsKS4KPiAg ICAqIEBnZXRfc2htX3JlZ2lvbjogZ2V0IGEgc2hhcmVkIG1lbW9yeSByZWdpb24gYmFzZWQgb24g dGhlIGluZGV4Lgo+ICsgKiBAcmVzZXRfdnE6IHJlc2V0IGEgcXVldWUgaW5kaXZpZHVhbGx5IChv cHRpb25hbCkuCj4gKyAqCXZxOiB0aGUgdmlydHF1ZXVlCj4gKyAqCVJldHVybnMgMCBvbiBzdWNj ZXNzIG9yIGVycm9yIHN0YXR1cwo+ICsgKglDYWxsZXIgc2hvdWxkIGd1YXJhbnRlZSB0aGF0IHRo ZSB2cmluZyBpcyBub3QgYWNjZXNzZWQgYnkgYW55IGZ1bmN0aW9ucwo+ICsgKglvZiB2aXJ0cXVl dWUuCgoKV2UgcHJvYmFibHkgbmVlZCB0byBiZSBtb3JlIGFjY3VyYXRlIGhlcmU6CgoxKSByZXNl dF92cSB3aWxsIGd1YXJhbnRlZSB0aGF0IHRoZSBjYWxsYmFja3MgYXJlIGRpc2FibGVkIG9yIHN5 bmNocm9uaXplZAoyKSBleGNlcHQgZm9yIHRoZSBjYWxsYmFjaywgdGhlIGNhbGxlciBzaG91bGQg Z3VhcmFudGVlIC4uLgoKVGhhbmtzCgoKPiArICogQGVuYWJsZV9yZXNldF92cTogZW5hYmxlIGEg cmVzZXQgcXVldWUKPiArICoJdnE6IHRoZSB2aXJ0cXVldWUKPiArICoJUmV0dXJucyAwIG9uIHN1 Y2Nlc3Mgb3IgZXJyb3Igc3RhdHVzCj4gKyAqCUlmIHJlc2V0X3ZxIGlzIHNldCwgdGhlbiBlbmFi bGVfcmVzZXRfdnEgbXVzdCBhbHNvIGJlIHNldC4KPiAgICAqLwo+ICAgdHlwZWRlZiB2b2lkIHZx X2NhbGxiYWNrX3Qoc3RydWN0IHZpcnRxdWV1ZSAqKTsKPiAgIHN0cnVjdCB2aXJ0aW9fY29uZmln X29wcyB7Cj4gQEAgLTEwMCw2ICsxMDksOCBAQCBzdHJ1Y3QgdmlydGlvX2NvbmZpZ19vcHMgewo+ ICAgCQkJaW50IGluZGV4KTsKPiAgIAlib29sICgqZ2V0X3NobV9yZWdpb24pKHN0cnVjdCB2aXJ0 aW9fZGV2aWNlICp2ZGV2LAo+ICAgCQkJICAgICAgIHN0cnVjdCB2aXJ0aW9fc2htX3JlZ2lvbiAq cmVnaW9uLCB1OCBpZCk7Cj4gKwlpbnQgKCpyZXNldF92cSkoc3RydWN0IHZpcnRxdWV1ZSAqdnEp Owo+ICsJaW50ICgqZW5hYmxlX3Jlc2V0X3ZxKShzdHJ1Y3QgdmlydHF1ZXVlICp2cSk7Cj4gICB9 Owo+ICAgCj4gICAvKiBJZiBkcml2ZXIgZGlkbid0IGFkdmVydGlzZSB0aGUgZmVhdHVyZSwgaXQg d2lsbCBuZXZlciBhcHBlYXIuICovCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpWaXJ0dWFsaXphdGlvbiBtYWlsaW5nIGxpc3QKVmlydHVhbGl6YXRpb25A bGlzdHMubGludXgtZm91bmRhdGlvbi5vcmcKaHR0cHM6Ly9saXN0cy5saW51eGZvdW5kYXRpb24u b3JnL21haWxtYW4vbGlzdGluZm8vdmlydHVhbGl6YXRpb24= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nRryp-007mth-6k for linux-um@lists.infradead.org; Wed, 09 Mar 2022 08:47:36 +0000 Received: by mail-pj1-f70.google.com with SMTP id w3-20020a17090ac98300b001b8b914e91aso1211445pjt.0 for ; Wed, 09 Mar 2022 00:47:30 -0800 (PST) Message-ID: Date: Wed, 9 Mar 2022 16:47:11 +0800 MIME-Version: 1.0 Subject: Re: [PATCH v7 13/26] virtio: queue_reset: struct virtio_config_ops add callbacks for queue_reset References: <20220308123518.33800-1-xuanzhuo@linux.alibaba.com> <20220308123518.33800-14-xuanzhuo@linux.alibaba.com> From: Jason Wang In-Reply-To: <20220308123518.33800-14-xuanzhuo@linux.alibaba.com> Content-Language: en-US List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-um" Errors-To: linux-um-bounces+geert=linux-m68k.org@lists.infradead.org To: Xuan Zhuo , virtualization@lists.linux-foundation.org, netdev@vger.kernel.org Cc: Jeff Dike , Richard Weinberger , Anton Ivanov , "Michael S. Tsirkin" , "David S. Miller" , Jakub Kicinski , Hans de Goede , Mark Gross , Vadim Pasternak , Bjorn Andersson , Mathieu Poirier , Cornelia Huck , Halil Pasic , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Alexander Gordeev , Sven Schnelle , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Johannes Berg , Vincent Whitchurch , linux-um@lists.infradead.org, platform-driver-x86@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, kvm@vger.kernel.org, bpf@vger.kernel.org CuWcqCAyMDIyLzMvOCDkuIvljYg4OjM1LCBYdWFuIFpodW8g5YaZ6YGTOgo+IFBlcmZvcm1pbmcg cmVzZXQgb24gYSBxdWV1ZSBpcyBkaXZpZGVkIGludG8gZm91ciBzdGVwczoKPgo+ICAgMS4gcmVz ZXRfdnEoKSAgICAgICAgICAgICAgICAgICAgIC0gbm90aWZ5IHRoZSBkZXZpY2UgdG8gcmVzZXQg dGhlIHF1ZXVlCj4gICAyLiB2aXJ0cXVldWVfZGV0YWNoX3VudXNlZF9idWYoKSAgLSByZWN5Y2xl IHRoZSBidWZmZXIgc3VibWl0dGVkCj4gICAzLiB2aXJ0cXVldWVfcmVzZXRfdnJpbmcoKSAgICAg ICAgLSByZXNldCB0aGUgdnJpbmcgKG1heSByZS1hbGxvYykKPiAgIDQuIGVuYWJsZV9yZXNldF92 cSgpICAgICAgICAgICAgICAtIG1tYXAgdnJpbmcgdG8gZGV2aWNlLCBhbmQgZW5hYmxlIHRoZSBx dWV1ZQo+Cj4gU28gYWRkIHR3byBjYWxsYmFja3MgcmVzZXRfdnEsIGVuYWJsZV9yZXNldF92cSB0 byBzdHJ1Y3QKPiB2aXJ0aW9fY29uZmlnX29wcy4KPgo+IFNpZ25lZC1vZmYtYnk6IFh1YW4gWmh1 byA8eHVhbnpodW9AbGludXguYWxpYmFiYS5jb20+Cj4gLS0tCj4gICBpbmNsdWRlL2xpbnV4L3Zp cnRpb19jb25maWcuaCB8IDExICsrKysrKysrKysrCj4gICAxIGZpbGUgY2hhbmdlZCwgMTEgaW5z ZXJ0aW9ucygrKQo+Cj4gZGlmZiAtLWdpdCBhL2luY2x1ZGUvbGludXgvdmlydGlvX2NvbmZpZy5o IGIvaW5jbHVkZS9saW51eC92aXJ0aW9fY29uZmlnLmgKPiBpbmRleCA0ZDEwN2FkMzExNDkuLmQ1 MTkwNmIxMzg5ZiAxMDA2NDQKPiAtLS0gYS9pbmNsdWRlL2xpbnV4L3ZpcnRpb19jb25maWcuaAo+ ICsrKyBiL2luY2x1ZGUvbGludXgvdmlydGlvX2NvbmZpZy5oCj4gQEAgLTc0LDYgKzc0LDE1IEBA IHN0cnVjdCB2aXJ0aW9fc2htX3JlZ2lvbiB7Cj4gICAgKiBAc2V0X3ZxX2FmZmluaXR5OiBzZXQg dGhlIGFmZmluaXR5IGZvciBhIHZpcnRxdWV1ZSAob3B0aW9uYWwpLgo+ICAgICogQGdldF92cV9h ZmZpbml0eTogZ2V0IHRoZSBhZmZpbml0eSBmb3IgYSB2aXJ0cXVldWUgKG9wdGlvbmFsKS4KPiAg ICAqIEBnZXRfc2htX3JlZ2lvbjogZ2V0IGEgc2hhcmVkIG1lbW9yeSByZWdpb24gYmFzZWQgb24g dGhlIGluZGV4Lgo+ICsgKiBAcmVzZXRfdnE6IHJlc2V0IGEgcXVldWUgaW5kaXZpZHVhbGx5IChv cHRpb25hbCkuCj4gKyAqCXZxOiB0aGUgdmlydHF1ZXVlCj4gKyAqCVJldHVybnMgMCBvbiBzdWNj ZXNzIG9yIGVycm9yIHN0YXR1cwo+ICsgKglDYWxsZXIgc2hvdWxkIGd1YXJhbnRlZSB0aGF0IHRo ZSB2cmluZyBpcyBub3QgYWNjZXNzZWQgYnkgYW55IGZ1bmN0aW9ucwo+ICsgKglvZiB2aXJ0cXVl dWUuCgoKV2UgcHJvYmFibHkgbmVlZCB0byBiZSBtb3JlIGFjY3VyYXRlIGhlcmU6CgoxKSByZXNl dF92cSB3aWxsIGd1YXJhbnRlZSB0aGF0IHRoZSBjYWxsYmFja3MgYXJlIGRpc2FibGVkIG9yIHN5 bmNocm9uaXplZAoyKSBleGNlcHQgZm9yIHRoZSBjYWxsYmFjaywgdGhlIGNhbGxlciBzaG91bGQg Z3VhcmFudGVlIC4uLgoKVGhhbmtzCgoKPiArICogQGVuYWJsZV9yZXNldF92cTogZW5hYmxlIGEg cmVzZXQgcXVldWUKPiArICoJdnE6IHRoZSB2aXJ0cXVldWUKPiArICoJUmV0dXJucyAwIG9uIHN1 Y2Nlc3Mgb3IgZXJyb3Igc3RhdHVzCj4gKyAqCUlmIHJlc2V0X3ZxIGlzIHNldCwgdGhlbiBlbmFi bGVfcmVzZXRfdnEgbXVzdCBhbHNvIGJlIHNldC4KPiAgICAqLwo+ICAgdHlwZWRlZiB2b2lkIHZx X2NhbGxiYWNrX3Qoc3RydWN0IHZpcnRxdWV1ZSAqKTsKPiAgIHN0cnVjdCB2aXJ0aW9fY29uZmln X29wcyB7Cj4gQEAgLTEwMCw2ICsxMDksOCBAQCBzdHJ1Y3QgdmlydGlvX2NvbmZpZ19vcHMgewo+ ICAgCQkJaW50IGluZGV4KTsKPiAgIAlib29sICgqZ2V0X3NobV9yZWdpb24pKHN0cnVjdCB2aXJ0 aW9fZGV2aWNlICp2ZGV2LAo+ICAgCQkJICAgICAgIHN0cnVjdCB2aXJ0aW9fc2htX3JlZ2lvbiAq cmVnaW9uLCB1OCBpZCk7Cj4gKwlpbnQgKCpyZXNldF92cSkoc3RydWN0IHZpcnRxdWV1ZSAqdnEp Owo+ICsJaW50ICgqZW5hYmxlX3Jlc2V0X3ZxKShzdHJ1Y3QgdmlydHF1ZXVlICp2cSk7Cj4gICB9 Owo+ICAgCj4gICAvKiBJZiBkcml2ZXIgZGlkbid0IGFkdmVydGlzZSB0aGUgZmVhdHVyZSwgaXQg d2lsbCBuZXZlciBhcHBlYXIuICovCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KbGludXgtdW0gbWFpbGluZyBsaXN0CmxpbnV4LXVtQGxpc3RzLmluZnJh ZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51 eC11bQo=