From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11354C43217 for ; Tue, 22 Nov 2022 09:25:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232243AbiKVJZK (ORCPT ); Tue, 22 Nov 2022 04:25:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58062 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232500AbiKVJZI (ORCPT ); Tue, 22 Nov 2022 04:25:08 -0500 Received: from out30-45.freemail.mail.aliyun.com (out30-45.freemail.mail.aliyun.com [115.124.30.45]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DB7D53FB9A; Tue, 22 Nov 2022 01:25:06 -0800 (PST) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R531e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046051;MF=renyu.zj@linux.alibaba.com;NM=1;PH=DS;RN=19;SR=0;TI=SMTPD_---0VVRfUdC_1669109100; Received: from 30.221.132.69(mailfrom:renyu.zj@linux.alibaba.com fp:SMTPD_---0VVRfUdC_1669109100) by smtp.aliyun-inc.com; Tue, 22 Nov 2022 17:25:02 +0800 Message-ID: Date: Tue, 22 Nov 2022 17:24:59 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [External] : [RFC PATCH v2 1/6] perf vendor events arm64: Add topdown L1 metrics for neoverse-n2 To: John Garry , linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, Will Deacon , James Clark , Mike Leach , Leo Yan , Ian Rogers Cc: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Andrew Kilroy , Shuai Xue , Zhuo Song References: <1667214694-89839-1-git-send-email-renyu.zj@linux.alibaba.com> <1668411720-3581-2-git-send-email-renyu.zj@linux.alibaba.com> <590ff032-d271-48ee-a4d8-141cc070c335@oracle.com> <75c4f0e6-3f28-a748-e891-7be6016ca28e@oracle.com> From: Jing Zhang In-Reply-To: <75c4f0e6-3f28-a748-e891-7be6016ca28e@oracle.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2022/11/22 上午1:55, John Garry 写道: > On 21/11/2022 15:17, Jing Zhang wrote: >> I'm sorry that I misunderstood the purpose of putting metric as arch_std_event at first, >> and now it works after the modification over your suggestion. >> >> But there are also a few questions: >> >> 1. The value of the slot in the topdownL1 is various in different architectures, for example, >> the slot is 5 on neoverse-n2. If I put topdownL1 metric as arch_std_event, then I need to >> specify the slot to 5 in n2. I can specify slot values in metric like below, but is there any >> other concise way to do this? >> >> diff --git a/tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/metrics.json b/tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/metrics.json >> index 8ff1dfe..b473baf 100644 >> --- a/tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/metrics.json >> +++ b/tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/metrics.json >> @@ -1,4 +1,23 @@ >> [ >> +       { >> +               "MetricExpr": "5", >> +               "PublicDescription": "A pipeline slot represents the hardware resources needed to process one uOp", >> +               "BriefDescription": "A pipeline slot represents the hardware resources needed to process one uOp", >> +               "MetricName": "slot" > > Ehhh....I'm not sure if that is a good idea. Ian or anyone else have an opinion on this? It is possible to reuse metrics, so it should work, but... > > One problem is that "slot" would show up as a metric, which you would not want. > > Alternatively I was going to suggest that you can overwrite specific std arch event attributes. So for example of frontend_bound, you could have: > > + b/tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/metrics.json > @@ -0,0 +1,30 @@ > [ >     { >     "ArchStdEvent": "FRONTEND_BOUND", >         "MetricExpr": "(stall_slot_frontend - cpu_cycles) / (5 * cpu_cycles)", >     }, > >> +       } >> +       { >> +               "ArchStdEvent": "FRONTEND_BOUND" >> +       }, >> +       { >> +               "ArchStdEvent": "BACKEND_BOUND" >> +       }, >> +       { >> +               "ArchStdEvent": "WASTED" >> +       }, >> +       { >> +               "ArchStdEvent": "RETIRING" >> +       }, >> >> >> 2. Should I add the topdownL1 metric to tools/perf/pmu-event/recommended.json, >> or create a new json file to place the general metric? > > It would not belong in recommended.json as that is specifically for arch-recommended events. It would really just depend on where the value comes from, i.e. arm arm or sbsa. > Thanks for your suggestion, I will send next patchset as you suggested. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5C038C433FE for ; Tue, 22 Nov 2022 09:26:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/IUP6qJ9jgWKQVDO+9RVmMbEPnA1EAPd4G0balJbBOs=; b=kCBk+gI6E08Ikj IxVhwJHKd4Itn0wru1StU3yKjIFxr1sn9UQSl6Gaj2F4WsdDjF5HDFvcsFBcBYChJDn6HiNN6bUz1 FVij0tmCuNQLwYi25S34C7b5h43m38Y4NgvYNWUf9YtBgfLgjgFPAEZC7pbhpYyG8GdVZ/+ud+xWh y9KQIGZMLo7422Uij80l4sFwtZZEo3KSNvJmUYYaV832U6wp9Fnpl/nK5Byfkhd60YO7TYKBcQH9/ rlsXxr2Y0X+WnYkWx4s+wJS3uiNCIFcR80Ms+NkqzIy+/WCkATnVY3AlKcbmwv9/1dm/O6Iuhuh0B U/zPm+PAIHV96GkPxc+A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oxPX6-006yU0-Ju; Tue, 22 Nov 2022 09:25:36 +0000 Received: from out30-44.freemail.mail.aliyun.com ([115.124.30.44]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oxPWe-006y5k-19 for linux-arm-kernel@lists.infradead.org; Tue, 22 Nov 2022 09:25:10 +0000 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R531e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046051;MF=renyu.zj@linux.alibaba.com;NM=1;PH=DS;RN=19;SR=0;TI=SMTPD_---0VVRfUdC_1669109100; Received: from 30.221.132.69(mailfrom:renyu.zj@linux.alibaba.com fp:SMTPD_---0VVRfUdC_1669109100) by smtp.aliyun-inc.com; Tue, 22 Nov 2022 17:25:02 +0800 Message-ID: Date: Tue, 22 Nov 2022 17:24:59 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [External] : [RFC PATCH v2 1/6] perf vendor events arm64: Add topdown L1 metrics for neoverse-n2 To: John Garry , linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, Will Deacon , James Clark , Mike Leach , Leo Yan , Ian Rogers Cc: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Andrew Kilroy , Shuai Xue , Zhuo Song References: <1667214694-89839-1-git-send-email-renyu.zj@linux.alibaba.com> <1668411720-3581-2-git-send-email-renyu.zj@linux.alibaba.com> <590ff032-d271-48ee-a4d8-141cc070c335@oracle.com> <75c4f0e6-3f28-a748-e891-7be6016ca28e@oracle.com> From: Jing Zhang In-Reply-To: <75c4f0e6-3f28-a748-e891-7be6016ca28e@oracle.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221122_012508_325055_4F1D814A X-CRM114-Status: GOOD ( 23.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org CgrlnKggMjAyMi8xMS8yMiDkuIrljYgxOjU1LCBKb2huIEdhcnJ5IOWGmemBkzoKPiBPbiAyMS8x MS8yMDIyIDE1OjE3LCBKaW5nIFpoYW5nIHdyb3RlOgo+PiBJJ20gc29ycnkgdGhhdCBJIG1pc3Vu ZGVyc3Rvb2QgdGhlIHB1cnBvc2Ugb2YgcHV0dGluZyBtZXRyaWMgYXMgYXJjaF9zdGRfZXZlbnQg YXQgZmlyc3QsCj4+IGFuZCBub3cgaXQgd29ya3MgYWZ0ZXIgdGhlIG1vZGlmaWNhdGlvbiBvdmVy IHlvdXIgc3VnZ2VzdGlvbi4KPj4KPj4gQnV0IHRoZXJlIGFyZSBhbHNvIGEgZmV3IHF1ZXN0aW9u czoKPj4KPj4gMS4gVGhlIHZhbHVlIG9mIHRoZSBzbG90IGluIHRoZSB0b3Bkb3duTDEgaXMgdmFy aW91cyBpbiBkaWZmZXJlbnQgYXJjaGl0ZWN0dXJlcywgZm9yIGV4YW1wbGUsCj4+IHRoZSBzbG90 IGlzIDUgb24gbmVvdmVyc2UtbjIuIElmIEkgcHV0IHRvcGRvd25MMSBtZXRyaWMgYXMgYXJjaF9z dGRfZXZlbnQsIHRoZW4gSSBuZWVkIHRvCj4+IHNwZWNpZnkgdGhlIHNsb3QgdG8gNSBpbiBuMi4g SSBjYW4gc3BlY2lmeSBzbG90IHZhbHVlcyBpbiBtZXRyaWMgbGlrZSBiZWxvdywgYnV0IGlzIHRo ZXJlIGFueQo+PiBvdGhlciBjb25jaXNlIHdheSB0byBkbyB0aGlzPwo+Pgo+PiBkaWZmIC0tZ2l0 IGEvdG9vbHMvcGVyZi9wbXUtZXZlbnRzL2FyY2gvYXJtNjQvYXJtL25lb3ZlcnNlLW4yL21ldHJp Y3MuanNvbiBiL3Rvb2xzL3BlcmYvcG11LWV2ZW50cy9hcmNoL2FybTY0L2FybS9uZW92ZXJzZS1u Mi9tZXRyaWNzLmpzb24KPj4gaW5kZXggOGZmMWRmZS4uYjQ3M2JhZiAxMDA2NDQKPj4gLS0tIGEv dG9vbHMvcGVyZi9wbXUtZXZlbnRzL2FyY2gvYXJtNjQvYXJtL25lb3ZlcnNlLW4yL21ldHJpY3Mu anNvbgo+PiArKysgYi90b29scy9wZXJmL3BtdS1ldmVudHMvYXJjaC9hcm02NC9hcm0vbmVvdmVy c2UtbjIvbWV0cmljcy5qc29uCj4+IEBAIC0xLDQgKzEsMjMgQEAKPj4gWwo+PiArwqDCoMKgwqDC oMKgIHsKPj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgIk1ldHJpY0V4cHIiOiAiNSIs Cj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgICJQdWJsaWNEZXNjcmlwdGlvbiI6ICJB IHBpcGVsaW5lIHNsb3QgcmVwcmVzZW50cyB0aGUgaGFyZHdhcmUgcmVzb3VyY2VzIG5lZWRlZCB0 byBwcm9jZXNzIG9uZSB1T3AiLAo+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAiQnJp ZWZEZXNjcmlwdGlvbiI6ICJBIHBpcGVsaW5lIHNsb3QgcmVwcmVzZW50cyB0aGUgaGFyZHdhcmUg cmVzb3VyY2VzIG5lZWRlZCB0byBwcm9jZXNzIG9uZSB1T3AiLAo+PiArwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoCAiTWV0cmljTmFtZSI6ICJzbG90Igo+IAo+IEVoaGguLi4uSSdtIG5vdCBz dXJlIGlmIHRoYXQgaXMgYSBnb29kIGlkZWEuIElhbiBvciBhbnlvbmUgZWxzZSBoYXZlIGFuIG9w aW5pb24gb24gdGhpcz8gSXQgaXMgcG9zc2libGUgdG8gcmV1c2UgbWV0cmljcywgc28gaXQgc2hv dWxkIHdvcmssIGJ1dC4uLgo+IAo+IE9uZSBwcm9ibGVtIGlzIHRoYXQgInNsb3QiIHdvdWxkIHNo b3cgdXAgYXMgYSBtZXRyaWMsIHdoaWNoIHlvdSB3b3VsZCBub3Qgd2FudC4KPiAKPiBBbHRlcm5h dGl2ZWx5IEkgd2FzIGdvaW5nIHRvIHN1Z2dlc3QgdGhhdCB5b3UgY2FuIG92ZXJ3cml0ZSBzcGVj aWZpYyBzdGQgYXJjaCBldmVudCBhdHRyaWJ1dGVzLiBTbyBmb3IgZXhhbXBsZSBvZiBmcm9udGVu ZF9ib3VuZCwgeW91IGNvdWxkIGhhdmU6Cj4gCj4gKyBiL3Rvb2xzL3BlcmYvcG11LWV2ZW50cy9h cmNoL2FybTY0L2FybS9uZW92ZXJzZS1uMi9tZXRyaWNzLmpzb24KPiBAQCAtMCwwICsxLDMwIEBA Cj4gWwo+IMKgwqDCoCB7Cj4gwqDCoMKgwqAiQXJjaFN0ZEV2ZW50IjogIkZST05URU5EX0JPVU5E IiwKPiDCoMKgwqDCoMKgwqDCoCAiTWV0cmljRXhwciI6ICIoc3RhbGxfc2xvdF9mcm9udGVuZCAt IGNwdV9jeWNsZXMpIC8gKDUgKiBjcHVfY3ljbGVzKSIsCj4gwqDCoMKgIH0sCj4gCj4+ICvCoMKg wqDCoMKgwqAgfQo+PiArwqDCoMKgwqDCoMKgIHsKPj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqAgIkFyY2hTdGRFdmVudCI6ICJGUk9OVEVORF9CT1VORCIKPj4gK8KgwqDCoMKgwqDCoCB9 LAo+PiArwqDCoMKgwqDCoMKgIHsKPj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgIkFy Y2hTdGRFdmVudCI6ICJCQUNLRU5EX0JPVU5EIgo+PiArwqDCoMKgwqDCoMKgIH0sCj4+ICvCoMKg wqDCoMKgwqAgewo+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAiQXJjaFN0ZEV2ZW50 IjogIldBU1RFRCIKPj4gK8KgwqDCoMKgwqDCoCB9LAo+PiArwqDCoMKgwqDCoMKgIHsKPj4gK8Kg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgIkFyY2hTdGRFdmVudCI6ICJSRVRJUklORyIKPj4g K8KgwqDCoMKgwqDCoCB9LAo+Pgo+Pgo+PiAyLiBTaG91bGQgSSBhZGQgdGhlIHRvcGRvd25MMSBt ZXRyaWMgdG8gdG9vbHMvcGVyZi9wbXUtZXZlbnQvcmVjb21tZW5kZWQuanNvbiwKPj4gb3IgY3Jl YXRlIGEgbmV3IGpzb24gZmlsZSB0byBwbGFjZSB0aGUgZ2VuZXJhbCBtZXRyaWM/Cj4gCj4gSXQg d291bGQgbm90IGJlbG9uZyBpbiByZWNvbW1lbmRlZC5qc29uIGFzIHRoYXQgaXMgc3BlY2lmaWNh bGx5IGZvciBhcmNoLXJlY29tbWVuZGVkIGV2ZW50cy4gSXQgd291bGQgcmVhbGx5IGp1c3QgZGVw ZW5kIG9uIHdoZXJlIHRoZSB2YWx1ZSBjb21lcyBmcm9tLCBpLmUuIGFybSBhcm0gb3Igc2JzYS4K PiAKCgpUaGFua3MgZm9yIHlvdXIgc3VnZ2VzdGlvbiwgSSB3aWxsIHNlbmQgbmV4dCBwYXRjaHNl dCBhcyB5b3Ugc3VnZ2VzdGVkLgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5l bEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4v bGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=