From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96800C48BE6 for ; Mon, 14 Jun 2021 15:05:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7C16B61352 for ; Mon, 14 Jun 2021 15:05:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233379AbhFNPH3 (ORCPT ); Mon, 14 Jun 2021 11:07:29 -0400 Received: from foss.arm.com ([217.140.110.172]:38202 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232869AbhFNPHZ (ORCPT ); Mon, 14 Jun 2021 11:07:25 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6547B1FB; Mon, 14 Jun 2021 08:05:22 -0700 (PDT) Received: from [10.57.9.136] (unknown [10.57.9.136]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id DECD13F70D; Mon, 14 Jun 2021 08:05:20 -0700 (PDT) Subject: Re: [PATCH v12 3/5] iommu/vt-d: Add support for IOMMU default DMA mode build options To: John Garry , Lu Baolu , "joro@8bytes.org" , "will@kernel.org" , "dwmw2@infradead.org" Cc: "linux-kernel@vger.kernel.org" , "iommu@lists.linux-foundation.org" , Linuxarm , "Leizhen (ThunderTown)" , "chenxiang (M)" References: <1623414043-40745-1-git-send-email-john.garry@huawei.com> <1623414043-40745-4-git-send-email-john.garry@huawei.com> <4f2cec34-bad9-e1bf-85c1-04d1a0c1aecf@linux.intel.com> <6055cd0d-a1d3-a73a-6831-3837021f3c9c@huawei.com> <0a04f964-80f4-7b2a-9740-eae4596e4e09@arm.com> <453a4606-099c-3d06-13fd-dc29c24230f5@huawei.com> From: Robin Murphy Message-ID: Date: Mon, 14 Jun 2021 16:05:15 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <453a4606-099c-3d06-13fd-dc29c24230f5@huawei.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021-06-14 15:19, John Garry wrote: > On 14/06/2021 15:11, Robin Murphy wrote: >> On 2021-06-14 08:53, John Garry wrote: >>> On 12/06/2021 03:22, Lu Baolu wrote: >>>> On 2021/6/11 20:20, John Garry wrote: >>>>> @@ -453,8 +452,7 @@ static int __init intel_iommu_setup(char *str) >>>>>                pr_warn("intel_iommu=forcedac deprecated; use >>>>> iommu.forcedac instead\n"); >>>>>                iommu_dma_forcedac = true; >>>>>            } else if (!strncmp(str, "strict", 6)) { >>>>> -            pr_info("Disable batched IOTLB flush\n"); >>>>> -            intel_iommu_strict = 1; >>>>> +            iommu_set_dma_strict(true); >>>> I would like to deprecate this command line and ask users to use >>>> iommu.strict instead. >>> ok, but then I should probably make the AMD driver also officially >>> support this. >> Oops, I should have documented that "iommu.strict" already applies to >> x86 as well. The interaction with the driver-specific parameters is a >> bit weird and unintuitive, but it was done knowingly. Let me quickly >> spin a kernel-parameters.txt fix for that... > > So I already had a pending patch here for the same to be included in > this series: > https://github.com/hisilicon/kernel-dev/commit/2375a2d888d78de9eb7d91d6f2c5891395300a96 > > > If you want to do it, then ok. I might have to reorder the series though... Yeah, sorry for the complication. Your subsequent deprecation of the x86 parameters doesn't need to conflict, but we should probably also update that the default value now depends on the kernel config, which will :( Thanks, Robin. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94DE6C2B9F4 for ; Mon, 14 Jun 2021 15:05:27 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1F70B61352 for ; Mon, 14 Jun 2021 15:05:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1F70B61352 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id DC639605A9; Mon, 14 Jun 2021 15:05:26 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Tj9u89c7z2n0; Mon, 14 Jun 2021 15:05:26 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp3.osuosl.org (Postfix) with ESMTPS id B50CA605DB; Mon, 14 Jun 2021 15:05:25 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 8704FC000E; Mon, 14 Jun 2021 15:05:25 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 4C11DC000B for ; Mon, 14 Jun 2021 15:05:24 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 2D4764013B for ; Mon, 14 Jun 2021 15:05:24 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id T4oQy22BcmQH for ; Mon, 14 Jun 2021 15:05:23 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp2.osuosl.org (Postfix) with ESMTP id 47C6640100 for ; Mon, 14 Jun 2021 15:05:23 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6547B1FB; Mon, 14 Jun 2021 08:05:22 -0700 (PDT) Received: from [10.57.9.136] (unknown [10.57.9.136]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id DECD13F70D; Mon, 14 Jun 2021 08:05:20 -0700 (PDT) Subject: Re: [PATCH v12 3/5] iommu/vt-d: Add support for IOMMU default DMA mode build options To: John Garry , Lu Baolu , "joro@8bytes.org" , "will@kernel.org" , "dwmw2@infradead.org" References: <1623414043-40745-1-git-send-email-john.garry@huawei.com> <1623414043-40745-4-git-send-email-john.garry@huawei.com> <4f2cec34-bad9-e1bf-85c1-04d1a0c1aecf@linux.intel.com> <6055cd0d-a1d3-a73a-6831-3837021f3c9c@huawei.com> <0a04f964-80f4-7b2a-9740-eae4596e4e09@arm.com> <453a4606-099c-3d06-13fd-dc29c24230f5@huawei.com> From: Robin Murphy Message-ID: Date: Mon, 14 Jun 2021 16:05:15 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <453a4606-099c-3d06-13fd-dc29c24230f5@huawei.com> Content-Language: en-GB Cc: "iommu@lists.linux-foundation.org" , "linux-kernel@vger.kernel.org" , Linuxarm X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" T24gMjAyMS0wNi0xNCAxNToxOSwgSm9obiBHYXJyeSB3cm90ZToKPiBPbiAxNC8wNi8yMDIxIDE1 OjExLCBSb2JpbiBNdXJwaHkgd3JvdGU6Cj4+IE9uIDIwMjEtMDYtMTQgMDg6NTMsIEpvaG4gR2Fy cnkgd3JvdGU6Cj4+PiBPbiAxMi8wNi8yMDIxIDAzOjIyLCBMdSBCYW9sdSB3cm90ZToKPj4+PiBP biAyMDIxLzYvMTEgMjA6MjAsIEpvaG4gR2Fycnkgd3JvdGU6Cj4+Pj4+IEBAIC00NTMsOCArNDUy LDcgQEAgc3RhdGljIGludCBfX2luaXQgaW50ZWxfaW9tbXVfc2V0dXAoY2hhciAqc3RyKQo+Pj4+ PiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHByX3dhcm4oImludGVsX2lvbW11PWZvcmNl ZGFjIGRlcHJlY2F0ZWQ7IHVzZQo+Pj4+PiBpb21tdS5mb3JjZWRhYyBpbnN0ZWFkXG4iKTsKPj4+ Pj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBpb21tdV9kbWFfZm9yY2VkYWMgPSB0cnVl Owo+Pj4+PiDCoMKgwqDCoMKgwqDCoMKgwqDCoCB9IGVsc2UgaWYgKCFzdHJuY21wKHN0ciwgInN0 cmljdCIsIDYpKSB7Cj4+Pj4+IC3CoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHByX2luZm8oIkRpc2Fi bGUgYmF0Y2hlZCBJT1RMQiBmbHVzaFxuIik7Cj4+Pj4+IC3CoMKgwqDCoMKgwqDCoMKgwqDCoMKg IGludGVsX2lvbW11X3N0cmljdCA9IDE7Cj4+Pj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGlv bW11X3NldF9kbWFfc3RyaWN0KHRydWUpOwo+Pj4+IEkgd291bGQgbGlrZSB0byBkZXByZWNhdGUg dGhpcyBjb21tYW5kIGxpbmUgYW5kIGFzayB1c2VycyB0byB1c2UKPj4+PiBpb21tdS5zdHJpY3Qg aW5zdGVhZC4KPj4+IG9rLCBidXQgdGhlbiBJIHNob3VsZCBwcm9iYWJseSBtYWtlIHRoZSBBTUQg ZHJpdmVyIGFsc28gb2ZmaWNpYWxseQo+Pj4gc3VwcG9ydCB0aGlzLgo+PiBPb3BzLCBJIHNob3Vs ZCBoYXZlIGRvY3VtZW50ZWQgdGhhdCAiaW9tbXUuc3RyaWN0IiBhbHJlYWR5IGFwcGxpZXMgdG8K Pj4geDg2IGFzIHdlbGwuIFRoZSBpbnRlcmFjdGlvbiB3aXRoIHRoZSBkcml2ZXItc3BlY2lmaWMg cGFyYW1ldGVycyBpcyBhCj4+IGJpdCB3ZWlyZCBhbmQgdW5pbnR1aXRpdmUsIGJ1dCBpdCB3YXMg ZG9uZSBrbm93aW5nbHkuIExldCBtZSBxdWlja2x5Cj4+IHNwaW4gYSBrZXJuZWwtcGFyYW1ldGVy cy50eHQgZml4IGZvciB0aGF0Li4uCj4gCj4gU28gSSBhbHJlYWR5IGhhZCBhIHBlbmRpbmcgcGF0 Y2ggaGVyZSBmb3IgdGhlIHNhbWUgdG8gYmUgaW5jbHVkZWQgaW4gCj4gdGhpcyBzZXJpZXM6Cj4g aHR0cHM6Ly9naXRodWIuY29tL2hpc2lsaWNvbi9rZXJuZWwtZGV2L2NvbW1pdC8yMzc1YTJkODg4 ZDc4ZGU5ZWI3ZDkxZDZmMmM1ODkxMzk1MzAwYTk2IAo+IAo+IAo+IElmIHlvdSB3YW50IHRvIGRv IGl0LCB0aGVuIG9rLiBJIG1pZ2h0IGhhdmUgdG8gcmVvcmRlciB0aGUgc2VyaWVzIHRob3VnaC4u LgoKWWVhaCwgc29ycnkgZm9yIHRoZSBjb21wbGljYXRpb24uIFlvdXIgc3Vic2VxdWVudCBkZXBy ZWNhdGlvbiBvZiB0aGUgeDg2IApwYXJhbWV0ZXJzIGRvZXNuJ3QgbmVlZCB0byBjb25mbGljdCwg YnV0IHdlIHNob3VsZCBwcm9iYWJseSBhbHNvIHVwZGF0ZSAKdGhhdCB0aGUgZGVmYXVsdCB2YWx1 ZSBub3cgZGVwZW5kcyBvbiB0aGUga2VybmVsIGNvbmZpZywgd2hpY2ggd2lsbCA6KAoKVGhhbmtz LApSb2Jpbi4KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K aW9tbXUgbWFpbGluZyBsaXN0CmlvbW11QGxpc3RzLmxpbnV4LWZvdW5kYXRpb24ub3JnCmh0dHBz Oi8vbGlzdHMubGludXhmb3VuZGF0aW9uLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2lvbW11