From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6449FC61DA4 for ; Fri, 3 Feb 2023 09:02:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232494AbjBCJCF (ORCPT ); Fri, 3 Feb 2023 04:02:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57436 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231602AbjBCJCA (ORCPT ); Fri, 3 Feb 2023 04:02:00 -0500 Received: from ex01.ufhost.com (ex01.ufhost.com [61.152.239.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0474391199; Fri, 3 Feb 2023 01:01:56 -0800 (PST) Received: from EXMBX165.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX165", Issuer "EXMBX165" (not verified)) by ex01.ufhost.com (Postfix) with ESMTP id 7654524E201; Fri, 3 Feb 2023 17:01:54 +0800 (CST) Received: from EXMBX073.cuchost.com (172.16.6.83) by EXMBX165.cuchost.com (172.16.6.75) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Fri, 3 Feb 2023 17:01:54 +0800 Received: from [192.168.120.49] (171.223.208.138) by EXMBX073.cuchost.com (172.16.6.83) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Fri, 3 Feb 2023 17:01:53 +0800 Message-ID: Date: Fri, 3 Feb 2023 17:01:52 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v4 6/7] riscv: dts: starfive: jh7110: Add ethernet device node Content-Language: en-US To: Krzysztof Kozlowski , , , , CC: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Emil Renner Berthing , Richard Cochran , Andrew Lunn , Heiner Kallweit , Peter Geis References: <20230118061701.30047-1-yanhong.wang@starfivetech.com> <20230118061701.30047-7-yanhong.wang@starfivetech.com> <55f020de-6058-67d2-ea68-6006186daee3@linaro.org> <870f6ec5-5378-760b-7a30-324ee2d178cf@linaro.org> <048b3ab0-7c13-b7f7-403c-f4e1d5574a10@starfivetech.com> From: yanhong wang In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [171.223.208.138] X-ClientProxiedBy: EXCAS066.cuchost.com (172.16.6.26) To EXMBX073.cuchost.com (172.16.6.83) X-YovoleRuleAgent: yovoleflag Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023/2/3 15:56, Krzysztof Kozlowski wrote: > On 03/02/2023 08:40, yanhong wang wrote: >>> >> >> Sorry, I didn't check all the bindings, only the modified ones, the command >> used is as follows: >> "make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/net/snps,dwmac.yaml" >> "make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml" > > That's good actually, except that you change binding used by others, so > you affect other files. > > However in this DTS you will have now warnings (dtbs_check with > simple-bus or dtbs W=1) because of using non-MMIO node in your soc-bus. > The stmmac-axi-config probably should be moved outside of soc node. Or > you keep two of them - one in each ethernet node. > Thanks. The stmmac-axi-config probably will be moved outside of soc node in the next version. > Best regards, > Krzysztof > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A4552C636CC for ; Fri, 3 Feb 2023 09:02:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=iJywpZ4TN/VeNRDtkW9DEVuiEJQmYKeIuIUEpgjtfNo=; b=OfC+edktdvpPB6 Hbh8TrG4uVbrev7J9xvvVwqTdTPwDoKCtVrxmeyTjLqK7q1yp6TRU3UibHyWX+6lRbbCUtIkBOUF5 uTbxpXXyf9oBBnCreet8xQfXm+6A5eng/l4yZvmez/mhBNfnHr0pnm5rLLbZs/kgLwcIpN4EQmpds heqxz35w2mLdcHUnM6CUhExhYpybfEJ1sNEsyed7iQZ+h6AESqD0iBACpElZUODLejmjN5GGn8Yby MNJPang+IuqCmYNtyv+S5nf9J/0neoKVT92nNF5c87So7gxlbP0ppri3M4v1bejPaSwlYvMEoaoSF akqYXrAnQ/MqqozxVeEA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pNrxT-0015gt-1K; Fri, 03 Feb 2023 09:02:11 +0000 Received: from ex01.ufhost.com ([61.152.239.75]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pNrxP-0015fZ-81 for linux-riscv@lists.infradead.org; Fri, 03 Feb 2023 09:02:09 +0000 Received: from EXMBX165.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX165", Issuer "EXMBX165" (not verified)) by ex01.ufhost.com (Postfix) with ESMTP id 7654524E201; Fri, 3 Feb 2023 17:01:54 +0800 (CST) Received: from EXMBX073.cuchost.com (172.16.6.83) by EXMBX165.cuchost.com (172.16.6.75) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Fri, 3 Feb 2023 17:01:54 +0800 Received: from [192.168.120.49] (171.223.208.138) by EXMBX073.cuchost.com (172.16.6.83) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Fri, 3 Feb 2023 17:01:53 +0800 Message-ID: Date: Fri, 3 Feb 2023 17:01:52 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v4 6/7] riscv: dts: starfive: jh7110: Add ethernet device node Content-Language: en-US To: Krzysztof Kozlowski , , , , CC: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Emil Renner Berthing , Richard Cochran , Andrew Lunn , Heiner Kallweit , Peter Geis References: <20230118061701.30047-1-yanhong.wang@starfivetech.com> <20230118061701.30047-7-yanhong.wang@starfivetech.com> <55f020de-6058-67d2-ea68-6006186daee3@linaro.org> <870f6ec5-5378-760b-7a30-324ee2d178cf@linaro.org> <048b3ab0-7c13-b7f7-403c-f4e1d5574a10@starfivetech.com> From: yanhong wang In-Reply-To: X-Originating-IP: [171.223.208.138] X-ClientProxiedBy: EXCAS066.cuchost.com (172.16.6.26) To EXMBX073.cuchost.com (172.16.6.83) X-YovoleRuleAgent: yovoleflag X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230203_010207_457848_EE4CC2B0 X-CRM114-Status: GOOD ( 10.42 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On 2023/2/3 15:56, Krzysztof Kozlowski wrote: > On 03/02/2023 08:40, yanhong wang wrote: >>> >> >> Sorry, I didn't check all the bindings, only the modified ones, the command >> used is as follows: >> "make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/net/snps,dwmac.yaml" >> "make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml" > > That's good actually, except that you change binding used by others, so > you affect other files. > > However in this DTS you will have now warnings (dtbs_check with > simple-bus or dtbs W=1) because of using non-MMIO node in your soc-bus. > The stmmac-axi-config probably should be moved outside of soc node. Or > you keep two of them - one in each ethernet node. > Thanks. The stmmac-axi-config probably will be moved outside of soc node in the next version. > Best regards, > Krzysztof > _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv