From mboxrd@z Thu Jan 1 00:00:00 1970 Subject: Re: [PATCH 3/5] block: move poll code to blk-mq To: Christoph Hellwig References: <1478202307-1947-1-git-send-email-axboe@fb.com> <1478202307-1947-4-git-send-email-axboe@fb.com> <20161104144410.GA29203@lst.de> Cc: axboe@kernel.dk, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org From: Jens Axboe Message-ID: Date: Fri, 4 Nov 2016 09:30:00 -0600 MIME-Version: 1.0 In-Reply-To: <20161104144410.GA29203@lst.de> Content-Type: text/plain; charset=windows-1252; format=flowed List-ID: On 11/04/2016 08:44 AM, Christoph Hellwig wrote: > On Thu, Nov 03, 2016 at 01:45:05PM -0600, Jens Axboe wrote: >> The poll code is blk-mq specific, let's move it to blk-mq.c. This >> is a prep patch for improving the polling code. >> >> Signed-off-by: Jens Axboe >> Reviewed-by: Christoph Hellwig > > So I gave my ok earlier, but I spent some more time looking at this > this morning and now I wonder why we even bother to keep some > code in blk-core.c. How about just renaming the whole damn thing > to blk_mq_poll and move it to blk-mq.c instead of that split? I pondered that too, and I guess we might as well since the likelihood of supporting polling on non-mq is pretty close to 0%. -- Jens Axboe From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935925AbcKDPaP (ORCPT ); Fri, 4 Nov 2016 11:30:15 -0400 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:36554 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S935749AbcKDPaL (ORCPT ); Fri, 4 Nov 2016 11:30:11 -0400 Subject: Re: [PATCH 3/5] block: move poll code to blk-mq To: Christoph Hellwig References: <1478202307-1947-1-git-send-email-axboe@fb.com> <1478202307-1947-4-git-send-email-axboe@fb.com> <20161104144410.GA29203@lst.de> CC: , , From: Jens Axboe Message-ID: Date: Fri, 4 Nov 2016 09:30:00 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161104144410.GA29203@lst.de> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [166.176.59.136] X-ClientProxiedBy: BN6PR1601CA0016.namprd16.prod.outlook.com (10.172.104.154) To CY4PR15MB1192.namprd15.prod.outlook.com (10.172.177.14) X-MS-Office365-Filtering-Correlation-Id: 4d6524d2-b1bf-4beb-14b0-08d404c7743b X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1192;2:keVvSYVGkJg8qG8Yrgi0fYHhEsZv6K9OWjyTJV3IQH1sRTeVw0vaYWsuWpBcCZj8J4EsXd0qhgqdyEnKVriceXvyZJ4UVBlwyJ3G8YOaa5bibDh65ZifTMgZ2dD2T1HMhz614bRrTH8ChxTrvZdd4le8e7UPngRcAmI3UKGR+y202PK8jzjJYA80UjlhTqG6jlQSIrLHBrPsk0XDj5xzog==;3:XPHJS8DwsGS2/qWYwew2U9x8Bx88ZlHlOf9fyC5JMfPeWlX0G8ADK56gaL3dffUEn6FXXKAsjabViTeBJveDBlRyLB7NsIbyPH57KuIiT67Te2v5bGxq/1JryC8i/7VCcfh6ikx907QXfldxUyBwOQ== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY4PR15MB1192; X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1192;25:0+q3ZJQcJ2/XlwcxKdW+gPbkfyijgNN5uchd6vJjZbnohkWS3r4TbzKjs24jJaF2NrEOlZvg22Wct9XTz5tq3Zx8jYJ85b8wK6aOmPzWBFNK5gY64f1ROnGaa0t8gEubX1PNeQzFEnDJNrnh8aQlo6Tbv2/cklOtTSBeqOiB59l+8T81jnGF0Dgs2fI+dcSx1/TdQZAVeigiDBYl2XrYHPjq8PGDcbZbZPzNlBANtyd0XjAhwGEJGKHdMJZGldR3dxIwIXQLNgc0ziUxdqqxM/s3GzJp5d3dVGxYEAWWXws/hMjaXWmOrXRCJspoDpUhBrEgJYv64UCDp0x324BakEZhwaifCa62MVsKXJKg7Q16FSXjbONMSBwihjotLO+4+zBucoh62I9kaXmG1XevM9pOdfnipCR6paYntvYJ5CBtfSLKUU/GrT38XfIHyR7M3mXBZkhXAW+7FEVLV3lRdCRMLhnbducNtfufqumEtAK5vqiKqs2eLmicYXmCU8zluTcJFtDPE67UFWnY9ApkYLiUp8gnEA8svyYlSxBstSpbToR5RNa+22ExzMyl4aMriZvtiFr36FymVCElieNL4D26ZHMO7F+jQ07s9ArQ+nDChvXxOCj0NKwEZO6vj9eFsNej7kvmj6HTuIqKohKXMafwivFqrZEdRK6XzH4tDlEPDuKWAUp74qfgCkA7odcz78J1fK8md3IMH4q8VfCIdbwe13EBEsLpZ1l1NusT8dQ= X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1192;31:aGUPGh0Jqzfpy9t1Q3zrFxGkEz5fWSMBa+violiNU2iUvR67q9pzwS968rs7YHvdGbTILJ3QO1m36r761FscChEuQT6SK8U8GfKaZnwmI6WOZ6gkCDXZBKds1ZE2qdfv/+bN/Lx6j1rTnYpA8dF6jh2hplF3LF/q9ekQkniAocfHTx9CkwLl1Pq76eyLoStqYj06KzMZ25ybxdAFbq+wfgcCoxMBSH/XuZl6vDKz9WvdfIJi6KgYuQyoDJsjnRe6wjhZS2eBY16+zau2Un1Qow==;20:XkzdLcaKom1bkQLk3nz0dLXgLaV1tlLh+YT1y3j6KPqEDZ7OvePjLRl1hyAIpstm0jsJnBaxMEfpsdoVbRsBtqo2j0cRYSaW+IoRvIOdtvflte2YcDqm3BlULmw8ChkQiG3LFoNOAC4KAjRxt9znTFepp5Uwtts0x7eJBr0SmYw=;4:jnKbHvHBLODUFvZkKmtiGSCjcX9TfnwDGe7Qcw78k1k1sbEoFm0G0SxaK2DnX1w0jGaqR5RjSyqK+PrA8EmDTi8mxhRvD3CJpW6lAIEhO4Os9iBQ0I/eXr5rRLlpbe3Otmr80Oqxd4KFYr4PhPsXm0jyVGqbSr8jpehMybQoZBaCPMgxiwb3wb+PH+JLvHk2MNQN+bVCe5+m6jmG1whyt2QHUYiTH80XPcqrl/MWlobxLbieFbFivjq0RyskkGE7FZOClQfIfN0Qp+yV70SLGljJTxH8CgXsWVJCKkvDHPYUmLrbX4NwH+Gv651J58RgSyswjK+AJkDtINic6W/AiyZ9Nje0a6iA1bxHI26T1+zPdLAWEUvLBXRFQ1TSIanPqih9zh8WQPyHxRoXi4Ta0h4z3vNIvpnE53+/cnJHELSUfGzJbIn8Yr6jhoZoiAY2 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(67672495146484); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046);SRVR:CY4PR15MB1192;BCL:0;PCL:0;RULEID:;SRVR:CY4PR15MB1192; X-Forefront-PRVS: 01165471DB X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(6049001)(7916002)(377454003)(24454002)(199003)(189002)(36756003)(6666003)(7736002)(7846002)(101416001)(305945005)(76176999)(54356999)(50986999)(110136003)(68736007)(77096005)(65826007)(2950100002)(6916009)(92566002)(23746002)(33646002)(5660300001)(97736004)(189998001)(4001350100001)(86362001)(31696002)(50466002)(64126003)(106356001)(81156014)(83506001)(19580405001)(105586002)(8676002)(3846002)(6116002)(65956001)(81166006)(19580395003)(4326007)(586003)(47776003)(2906002)(65806001)(66066001)(42186005)(230700001)(31686004);DIR:OUT;SFP:1102;SCL:1;SRVR:CY4PR15MB1192;H:[172.20.10.9];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;CY4PR15MB1192;23:0OcUeZKf657aWCja208FuWTwcyRzAqma6HFYO?= =?Windows-1252?Q?7hLX5Ket8YrquAGoWWWGQqux80wWe68baCMTQlIINEQdFbRSYktZsYna?= =?Windows-1252?Q?xWE+Is05fOZsrzvsyEhH8A3QIvDIBHCKCW4OjwMf7v7CCVm2HKbs5Ymq?= =?Windows-1252?Q?nilfh8/1CBBSO5QpsbJcC9Tk2UUWQmdqF1qaaKXnFScv2E5sSCEPGBOA?= =?Windows-1252?Q?nEaipVbHOrc79dEoHZwm00kZgm1Yf4dFRgJgd95PI3Ii6o6Jgwggf5tT?= =?Windows-1252?Q?TXq/cozaTnfVwrrELEER8ej2Cfb7csmCgGpjL4tyw2x3vB0v/ZJDHgm0?= =?Windows-1252?Q?wptJMPcPYOnlasnjJQ+Ab0VwQhzGu3lqU1nIL1SN8esOg9K//Ng2tlIs?= =?Windows-1252?Q?hYYc2ZRK3i0fuVsy9Fi1/EKRsS3zDBYQ+Mo4IedHkoERaewsqJhbHhlb?= =?Windows-1252?Q?mpEKCKIOysNQqVvf6M1ufdDigbpRUS9anxblWkoFAuoKlIeB2Qg+Q14d?= =?Windows-1252?Q?MCWiHXMKxVcvmrldEe7r4CJzuJlYT6fh7Bw/p+xc2mj+ZYiGfi9ycqeb?= =?Windows-1252?Q?KX5Sdax54qgNuD+KpSiSfOBxM+RJpS3n3lkHkMvd9+JSuN2FDUTdSeRf?= =?Windows-1252?Q?egHdbgGFh+RKlh4X2GynvbWIdtyzoLI4JIyx+oNp4TxBl7jyqc0r4WGg?= =?Windows-1252?Q?364NUFPBQ/HL5aBsnHnq//8WUO/r+mEVcU7t51s2LBYy3EVZdYB8lEiQ?= =?Windows-1252?Q?I3MvP3Sx8380m1E7Y/aDAyBYbKLKwOVIx+ErX/10NUhNq9BrMYC8nXPS?= =?Windows-1252?Q?fFdiPh7CiDlKCajudDciJVO+july5Q+5mPcM1wlC6FYspzfb9o2Q+UfJ?= =?Windows-1252?Q?E8RgkqzlneKBntFl9bEvS0PaGBH6x2Alcs7+5QpUQC7Hco7x6I6M8+IX?= =?Windows-1252?Q?2q5jfZA5lpHG9cJeG1MSwRbD8pDmC4Qov08UZWshPUQoDNGq0BTkdWxp?= =?Windows-1252?Q?pYZmxm+cKk9eYK6y5/RYIlF8x1ud5cXTNlpqoaO/duPV+9LmISuG/mwB?= =?Windows-1252?Q?QjPeBRBHWE0U8NWbOSmZ0UCHC5NVqM9+SPnkiexpo+gY8Z1nxoenr+ew?= =?Windows-1252?Q?J07mqaO3EvHDsVdfkoRwcRMBqTFUVILtuU9wuIDtdXRxeSPDyPrHi1/c?= =?Windows-1252?Q?3WDzTD+R/mu4tqgg7IYuVRj8ZH0fNQp9fRT3zC+a03+VKWqgJeO0LB3E?= =?Windows-1252?Q?tVGqUHNfGOXxI78y6u6JbaG7YMoUV0Hxvwqrs561AuwYAPhCEFD+NTFl?= =?Windows-1252?Q?AFnJPTs2/mbszUb8n04PojBoTTjsfeqsoEvHGFUOyBAjqdhDKx7G0lR6?= =?Windows-1252?Q?1YqK3kcvmFXpvTebiYtRad3RFyEJ+17EEWNdP/4Zk/p/0pJJHyxBrz6Q?= =?Windows-1252?Q?vcy48fBTSAnsCnXczS1?= X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1192;6:smJlvMzuYmHHMmZ+hdG0g95XpsOLoz6ETc9qiMEjY3dRc+qJ5FgE9/lsX0ZnBgUmy45XG8Zv862rcQL+wNFZ/rCaO0FC8uK9BkovjljHIAzmIeDdJUDyQY5ydfb8qqWd/P61jEnRRjAloiQf0dt8EQYpORNTNaBCri8ixp/UaVdiSuuZ6aFTjmkp7Hs0CblF19+z2gA6lAvZUcGEVCp6K3geaQOVABVbIBEzWuUvG09hTkmyFmYYAzg49rjPgfMhldajtx4y966agIeEAMXEQSaMfnaoj81NHqsQJ8xsFc9eDGfhPM0FrBtbUOjMr0w+;5:Sll5TwAi+fpS8BRpDvii6ThbEvtPLd9mkwdnl4WefHD0QKGl6sSXJk16/HiRCo2GLTa/xG0v6NQ6EPUhyScJYYxkxeiyWVBwx4z4tbzT63txsPEkHfS7IggdVt0tNBjhNhtZy6S9m5ckRuoXVMYkqBCvwSsfpKUyAQi/0bEF8oU=;24:/0YpKOS1nz+SnroMIfVEG/NIL+9VBLvMb7Kdurksj49F49+88K7NFiI8aRCZAk3SEdHaUUtZDDUDHmkUtQMXKzmLBCnGnSqDtGoNiOe4iJI= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1192;7:5SfC7fKlq4DxPNWeL5WN16CHvUx4hYaLI1YHdxfHaBd/yVp7FhO7JJD95AISN0WQN2Z+dDypZRsv4vFfIQXgudX9OzAVo+WNvgh52ICQSEQT/Zb1+Rt7ND+bUqdc4WdfcT1Ze2KOxJdBKjnVCf/rCl7pqRzo6QdAyyvXh1YB7W2yyACF1Ed7mDHPWYN0OkNzaJP5NqYhrnz/ols/maggXsCuBsrGuI1evkRnIFymisjjLwE8SNTJoeBOOARxd5wwRL6p+qmTvWPMN7mhrlUBXTswHzbpgt+9v9OZC5UgbPPuwaIIlswqfESIxN9+QEnG3Kq2CHLfVjOuDKssoS3t8r360Oez0y2Bq7pB6BdB6Ko=;20:5OAgssLzesRmUPtUt02ata3EAqyioRFeusUSXLy5E+fDLA5MYS/tKOn11lbCA6yXNFlXFPNiKoumCI9xVNuSD2EkeXTMI4zSlgVqTncptNAjaiVwMIcGPw5uxCDE5bnbkKY3SCyC5kIIUzoHW045XxWbFR3wpXj6og1s3x1RVu4= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Nov 2016 15:30:04.5701 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR15MB1192 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-11-04_03:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/04/2016 08:44 AM, Christoph Hellwig wrote: > On Thu, Nov 03, 2016 at 01:45:05PM -0600, Jens Axboe wrote: >> The poll code is blk-mq specific, let's move it to blk-mq.c. This >> is a prep patch for improving the polling code. >> >> Signed-off-by: Jens Axboe >> Reviewed-by: Christoph Hellwig > > So I gave my ok earlier, but I spent some more time looking at this > this morning and now I wonder why we even bother to keep some > code in blk-core.c. How about just renaming the whole damn thing > to blk_mq_poll and move it to blk-mq.c instead of that split? I pondered that too, and I guess we might as well since the likelihood of supporting polling on non-mq is pretty close to 0%. -- Jens Axboe