From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eu-smtp-delivery-151.mimecast.com (eu-smtp-delivery-151.mimecast.com [185.58.85.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F26D070 for ; Fri, 4 Jun 2021 08:33:55 +0000 (UTC) Received: from AcuMS.aculab.com (156.67.243.121 [156.67.243.121]) (Using TLS) by relay.mimecast.com with ESMTP id uk-mta-60-CDThUlX4PWym1fEgqsJjnA-2; Fri, 04 Jun 2021 09:33:52 +0100 X-MC-Unique: CDThUlX4PWym1fEgqsJjnA-2 Received: from AcuMS.Aculab.com (fd9f:af1c:a25b:0:994c:f5c2:35d6:9b65) by AcuMS.aculab.com (fd9f:af1c:a25b:0:994c:f5c2:35d6:9b65) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Fri, 4 Jun 2021 09:33:50 +0100 Received: from AcuMS.Aculab.com ([fe80::994c:f5c2:35d6:9b65]) by AcuMS.aculab.com ([fe80::994c:f5c2:35d6:9b65%12]) with mapi id 15.00.1497.018; Fri, 4 Jun 2021 09:33:50 +0100 From: David Laight To: 'Joe Perches' , 'Alex Elder' , 'Manikishan Ghantasala' , Alex Elder CC: Alex Elder , "greybus-dev@lists.linaro.org" , "linux-staging@lists.linux.dev" , Johan Hovold , "linux-kernel@vger.kernel.org" Subject: RE: [greybus-dev] [PATCH] staging: greybus: fixed the coding style, labels should not be indented. Thread-Topic: [greybus-dev] [PATCH] staging: greybus: fixed the coding style, labels should not be indented. Thread-Index: AQHXV7uPElUZ9thDckyuMtjnIAGFwKsCzNHA///2ooCAABDyEP//8ZgAgAC7OdD///UyAAACKTmg Date: Fri, 4 Jun 2021 08:33:50 +0000 Message-ID: References: <20210602133659.46158-1-manikishanghantasala@gmail.com> <9a3878fd-3b59-76f5-ddc7-625c66f9fee8@ieee.org> <792dd57c0ef8454497e5ae4c4534dea2@AcuMS.aculab.com> <10ad30e2-c906-b210-bf0e-5e20b6de1993@linaro.org> <19651be0dc8706da34658d25195ff122f41ee7c0.camel@perches.com> In-Reply-To: <19651be0dc8706da34658d25195ff122f41ee7c0.camel@perches.com> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.107] X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=C51A453 smtp.mailfrom=david.laight@aculab.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: aculab.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable From: Joe Perches > Sent: 04 June 2021 09:27 >=20 > On Fri, 2021-06-04 at 08:13 +0000, David Laight wrote: > > From: Alex Elder > > > Sent: 03 June 2021 22:55 > > ... > > > Not necessarily, sizeof(bool) is implementation defined. > > > And I thought you didn't think the size of the structure > > > was very important... > > > > It is 'implementation defined' but will be 32 bits on everything > > except an old 32bit ARM ABI. >=20 > Really? (x86-64) >=20 ... > sizeof _Bool: 1 > sizeof struct foo: 1 Gah, not enough coffee. I said I don't like _Bool :-) The old arm32 must have had 32bit bool. =09David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1= PT, UK Registration No: 1397386 (Wales)