From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [PATCH v2 16/16] block: unexport bsg_softirq_done() again To: Johannes Thumshirn , "Martin K . Petersen" References: <992fceabad26e146a728e8c80694ccb856182dc5.1476276823.git.jthumshirn@suse.de> Cc: Christoph Hellwig , Linux Kernel Mailinglist , Linux SCSI Mailinglist , Jens Axboe , "open list:BLOCK LAYER" From: Hannes Reinecke Message-ID: Date: Thu, 13 Oct 2016 13:50:08 +0200 MIME-Version: 1.0 In-Reply-To: <992fceabad26e146a728e8c80694ccb856182dc5.1476276823.git.jthumshirn@suse.de> Content-Type: text/plain; charset=windows-1252 List-ID: On 10/12/2016 03:06 PM, Johannes Thumshirn wrote: > Unexport bsg_softirq_done() again, we don't need it outside of bsg-lib.c > anymore now that scsi_transport_fc is a pure bsg-lib client. > > Signed-off-by: Johannes Thumshirn > --- > block/bsg-lib.c | 3 +-- > include/linux/bsg-lib.h | 1 - > 2 files changed, 1 insertion(+), 3 deletions(-) > > diff --git a/block/bsg-lib.c b/block/bsg-lib.c > index 46a4fee..4ac0ade 100644 > --- a/block/bsg-lib.c > +++ b/block/bsg-lib.c > @@ -93,14 +93,13 @@ EXPORT_SYMBOL_GPL(bsg_job_done); > * bsg_softirq_done - softirq done routine for destroying the bsg requests > * @rq: BSG request that holds the job to be destroyed > */ > -void bsg_softirq_done(struct request *rq) > +static void bsg_softirq_done(struct request *rq) > { > struct bsg_job *job = rq->special; > > blk_end_request_all(rq, rq->errors); > bsg_job_put(job); > } > -EXPORT_SYMBOL_GPL(bsg_softirq_done); > > static int bsg_map_buffer(struct bsg_buffer *buf, struct request *req) > { > diff --git a/include/linux/bsg-lib.h b/include/linux/bsg-lib.h > index b708db9..657a718 100644 > --- a/include/linux/bsg-lib.h > +++ b/include/linux/bsg-lib.h > @@ -69,7 +69,6 @@ void bsg_job_done(struct bsg_job *job, int result, > int bsg_setup_queue(struct device *dev, struct request_queue *q, char *name, > bsg_job_fn *job_fn, int dd_job_size); > void bsg_request_fn(struct request_queue *q); > -void bsg_softirq_done(struct request *rq); > void bsg_job_put(struct bsg_job *job); > int __must_check bsg_job_get(struct bsg_job *job); > > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking hare@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N�rnberg GF: F. Imend�rffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG N�rnberg) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755786AbcJMNDz (ORCPT ); Thu, 13 Oct 2016 09:03:55 -0400 Received: from mx2.suse.de ([195.135.220.15]:39085 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753419AbcJMNDp (ORCPT ); Thu, 13 Oct 2016 09:03:45 -0400 Subject: Re: [PATCH v2 16/16] block: unexport bsg_softirq_done() again To: Johannes Thumshirn , "Martin K . Petersen" References: <992fceabad26e146a728e8c80694ccb856182dc5.1476276823.git.jthumshirn@suse.de> Cc: Christoph Hellwig , Linux Kernel Mailinglist , Linux SCSI Mailinglist , Jens Axboe , "open list:BLOCK LAYER" From: Hannes Reinecke Message-ID: Date: Thu, 13 Oct 2016 13:50:08 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <992fceabad26e146a728e8c80694ccb856182dc5.1476276823.git.jthumshirn@suse.de> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/12/2016 03:06 PM, Johannes Thumshirn wrote: > Unexport bsg_softirq_done() again, we don't need it outside of bsg-lib.c > anymore now that scsi_transport_fc is a pure bsg-lib client. > > Signed-off-by: Johannes Thumshirn > --- > block/bsg-lib.c | 3 +-- > include/linux/bsg-lib.h | 1 - > 2 files changed, 1 insertion(+), 3 deletions(-) > > diff --git a/block/bsg-lib.c b/block/bsg-lib.c > index 46a4fee..4ac0ade 100644 > --- a/block/bsg-lib.c > +++ b/block/bsg-lib.c > @@ -93,14 +93,13 @@ EXPORT_SYMBOL_GPL(bsg_job_done); > * bsg_softirq_done - softirq done routine for destroying the bsg requests > * @rq: BSG request that holds the job to be destroyed > */ > -void bsg_softirq_done(struct request *rq) > +static void bsg_softirq_done(struct request *rq) > { > struct bsg_job *job = rq->special; > > blk_end_request_all(rq, rq->errors); > bsg_job_put(job); > } > -EXPORT_SYMBOL_GPL(bsg_softirq_done); > > static int bsg_map_buffer(struct bsg_buffer *buf, struct request *req) > { > diff --git a/include/linux/bsg-lib.h b/include/linux/bsg-lib.h > index b708db9..657a718 100644 > --- a/include/linux/bsg-lib.h > +++ b/include/linux/bsg-lib.h > @@ -69,7 +69,6 @@ void bsg_job_done(struct bsg_job *job, int result, > int bsg_setup_queue(struct device *dev, struct request_queue *q, char *name, > bsg_job_fn *job_fn, int dd_job_size); > void bsg_request_fn(struct request_queue *q); > -void bsg_softirq_done(struct request *rq); > void bsg_job_put(struct bsg_job *job); > int __must_check bsg_job_get(struct bsg_job *job); > > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking hare@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg)