From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBFBCC47082 for ; Mon, 24 May 2021 02:53:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8B52661155 for ; Mon, 24 May 2021 02:53:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232222AbhEXCyu (ORCPT ); Sun, 23 May 2021 22:54:50 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:46744 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231896AbhEXCyt (ORCPT ); Sun, 23 May 2021 22:54:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621824801; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OHCpWszk2k0MKGSbz/oMp6Y4c3mTJaXAiLMSobPSgQg=; b=YvolKr8XsByZwrAg0qc56TH7IIweqwtpUZuVblSLmpXx9O3B6pDbrtmPi2q9eGpCxeL87K GL0o3HrXma0HnldMPIG2z4A32aFEHbgP9vNaw3tmStT8DDY7SALCKJ6wHjlJzbfk9rZg5p abxcGPncMDpyTHzwVgl4ScMmQUFUrbM= Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-326-CL1IcWi5OESiIh-sf0zaWA-1; Sun, 23 May 2021 22:53:18 -0400 X-MC-Unique: CL1IcWi5OESiIh-sf0zaWA-1 Received: by mail-pj1-f72.google.com with SMTP id gq1-20020a17090b1041b029015dad62a207so12868293pjb.9 for ; Sun, 23 May 2021 19:53:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=OHCpWszk2k0MKGSbz/oMp6Y4c3mTJaXAiLMSobPSgQg=; b=dtasDF2KGPXeE4Zhe7fceP4nNqrdiBi3klNzMamoY2+nWhamxadLdsg8LQldoxL8n4 aICHvVQIlYE+q0YOihXvS1wyrCYpuw/mNOP3X6qnkUM3E0W8r52Tv+CxYjNXhqQIPoje ECq+0CIgnRsv1dTzCocdVxOeg9tfcqyQhDH68amrheZvsf8cn8tIKGFGhZEv2YfJqnI9 7UQSb4JsadTO29U34PyF7SXfIJkH26AY/GDtiKBaIvkOxOM/gchqRpjh4dc5/g4/II5J kZIINN1IOEhSKG0ORCCEoh+IQPsvuk6ERf/r7z48enzG1Z2bl5VRcFpzzbhfP9EALwF5 QuCA== X-Gm-Message-State: AOAM531Ui1EUCNDPHpuSfRloLwSoQApqPTSDLEzTFtxtZ5bllRB0IcCl BWhf6krJggBexE39wDeIbiOUhwlMsHF8IraKcyeIh54r35HlJJ9XvOVQz293fBtmrgE/Kgg8nAy DFSJPf+wY3nfy8ahdOM14Xi6C X-Received: by 2002:a63:74e:: with SMTP id 75mr7415331pgh.200.1621824797353; Sun, 23 May 2021 19:53:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzP1ngdwvFX7GKxWKgZ4m6yITaZWeGU+YceEWcYXFbWXp51SlQUq1uR/X6gvfXsGOJdOyWhtQ== X-Received: by 2002:a63:74e:: with SMTP id 75mr7415321pgh.200.1621824797107; Sun, 23 May 2021 19:53:17 -0700 (PDT) Received: from wangxiaodeMacBook-Air.local ([209.132.188.80]) by smtp.gmail.com with ESMTPSA id b9sm9335313pfo.107.2021.05.23.19.53.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 23 May 2021 19:53:16 -0700 (PDT) Subject: Re: virtio_net: BQL? To: Dave Taht , Willem de Bruijn Cc: Xianting Tian , "Michael S. Tsirkin" , "David S. Miller" , Jakub Kicinski , virtualization , Linux Kernel Network Developers , LKML , bloat References: <56270996-33a6-d71b-d935-452dad121df7@linux.alibaba.com> From: Jason Wang Message-ID: Date: Mon, 24 May 2021 10:53:08 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2021/5/18 上午5:48, Dave Taht 写道: > On Mon, May 17, 2021 at 1:23 PM Willem de Bruijn > wrote: >> On Mon, May 17, 2021 at 2:44 PM Dave Taht wrote: >>> Not really related to this patch, but is there some reason why virtio >>> has no support for BQL? >> There have been a few attempts to add it over the years. >> >> Most recently, https://lore.kernel.org/lkml/20181205225323.12555-2-mst@redhat.com/ >> >> That thread has a long discussion. I think the key open issue remains >> >> "The tricky part is the mode switching between napi and no napi." > Oy, vey. > > I didn't pay any attention to that discussion, sadly enough. > > It's been about that long (2018) since I paid any attention to > bufferbloat in the cloud and my cloudy provider (linode) switched to > using virtio when I wasn't looking. For over a year now, I'd been > getting reports saying that comcast's pie rollout wasn't working as > well as expected, that evenroute's implementation of sch_cake and sqm > on inbound wasn't working right, nor pf_sense's and numerous other > issues at Internet scale. > > Last week I ran a string of benchmarks against starlink's new services > and was really aghast at what I found there, too. but the problem > seemed deeper than in just the dishy... > > Without BQL, there's no backpressure for fq_codel to do its thing. > None. My measurement servers aren't FQ-codeling > no matter how much load I put on them. Since that qdisc is the default > now in most linux distributions, I imagine that the bulk of the cloud > is now behaving as erratically as linux was in 2011 with enormous > swings in throughput and latency from GSO/TSO hitting overlarge rx/tx > rings, [1], breaking various rate estimators in codel, pie and the tcp > stack itself. > > See: > > http://fremont.starlink.taht.net/~d/virtio_nobql/rrul_-_evenroute_v3_server_fq_codel.png > > See the swings in latency there? that's symptomatic of tx/rx rings > filling and emptying. > > it wasn't until I switched my measurement server temporarily over to > sch_fq that I got a rrul result that was close to the results we used > to get from the virtualized e1000e drivers we were using in 2014. > > http://fremont.starlink.taht.net/~d/virtio_nobql/rrul_-_evenroute_v3_server_fq.png > > While I have long supported the use of sch_fq for tcp-heavy workloads, > it still behaves better with bql in place, and fq_codel is better for > generic workloads... but needs bql based backpressure to kick in. > > [1] I really hope I'm overreacting but, um, er, could someone(s) spin > up a new patch that does bql in some way even half right for this > driver and help test it? I haven't built a kernel in a while. I think it's time to obsolete skb_orphan() for virtio-net to get rid of a brunch of tricky codes in the current virtio-net driver. Then we can do BQL on top. I will prepare some patches to do this (probably with Michael's BQL patch). Thanks > > >>> On Mon, May 17, 2021 at 11:41 AM Xianting Tian >>> wrote: >>>> BUG_ON() uses unlikely in if(), which can be optimized at compile time. >>>> >>>> Signed-off-by: Xianting Tian >>>> --- >>>> drivers/net/virtio_net.c | 5 ++--- >>>> 1 file changed, 2 insertions(+), 3 deletions(-) >>>> >>>> diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c >>>> index c921ebf3ae82..212d52204884 100644 >>>> --- a/drivers/net/virtio_net.c >>>> +++ b/drivers/net/virtio_net.c >>>> @@ -1646,10 +1646,9 @@ static int xmit_skb(struct send_queue *sq, struct >>>> sk_buff *skb) >>>> else >>>> hdr = skb_vnet_hdr(skb); >>>> >>>> - if (virtio_net_hdr_from_skb(skb, &hdr->hdr, >>>> + BUG_ON(virtio_net_hdr_from_skb(skb, &hdr->hdr, >>>> virtio_is_little_endian(vi->vdev), false, >>>> - 0)) >>>> - BUG(); >>>> + 0)); >>>> >>>> if (vi->mergeable_rx_bufs) >>>> hdr->num_buffers = 0; >>>> -- >>>> 2.17.1 >>>> >>> >>> -- >>> Latest Podcast: >>> https://www.linkedin.com/feed/update/urn:li:activity:6791014284936785920/ >>> >>> Dave Täht CTO, TekLibre, LLC > > > -- > Latest Podcast: > https://www.linkedin.com/feed/update/urn:li:activity:6791014284936785920/ > > Dave Täht CTO, TekLibre, LLC > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69397C47080 for ; Mon, 24 May 2021 02:53:31 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 066A761159 for ; Mon, 24 May 2021 02:53:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 066A761159 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=virtualization-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id B338B606ED; Mon, 24 May 2021 02:53:30 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id c8To2iW1XHUX; Mon, 24 May 2021 02:53:29 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp3.osuosl.org (Postfix) with ESMTP id 3162160677; Mon, 24 May 2021 02:53:29 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 02DF9C000E; Mon, 24 May 2021 02:53:29 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137]) by lists.linuxfoundation.org (Postfix) with ESMTP id A9DF3C0001 for ; Mon, 24 May 2021 02:53:27 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 90CDB40340 for ; Mon, 24 May 2021 02:53:27 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp4.osuosl.org (amavisd-new); dkim=pass (1024-bit key) header.d=redhat.com Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id aF2wdaYBF_oQ for ; Mon, 24 May 2021 02:53:24 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by smtp4.osuosl.org (Postfix) with ESMTPS id D0046402EB for ; Mon, 24 May 2021 02:53:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621824802; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OHCpWszk2k0MKGSbz/oMp6Y4c3mTJaXAiLMSobPSgQg=; b=OPHQRZ2A7IxtTiPAm+MKXusQrNsyOv6GnyhqkYhrxNBWszbvC9Hz1NofnIBOZl+R0ugFn3 s05lQlaX8KAWNeNlA7ZjhggjyF1KOK1zVNsGbfI91HphCdaCs1eRg2Cl/k4joE58YCXybl ef3erKpiy5UcHcZHlS6BcE6xycMrcAQ= Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-388-8DEfBaSfMQ25d__jU5ZTZg-1; Sun, 23 May 2021 22:53:18 -0400 X-MC-Unique: 8DEfBaSfMQ25d__jU5ZTZg-1 Received: by mail-pj1-f72.google.com with SMTP id h23-20020a17090aa897b029015cc61ef388so12708979pjq.9 for ; Sun, 23 May 2021 19:53:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=OHCpWszk2k0MKGSbz/oMp6Y4c3mTJaXAiLMSobPSgQg=; b=Cakfr0BM995+Oeuc6wz68vXlknKPtOFBHv/DHcOEqiOwmLU54qoph41ljb9g3jAl7q Zwdyf/PZPJxVabKND1aGGM1eBOvxBbV/mJhsZ0QzvJEmeyTtkOHGUUGGpGdhgwnRZymB fQawmE+6HP5HoYyFD8/7ArsUS2ddEvCoCwmgcVzDfs/W8uD9XCSrC+IIiPiQl6WSBMED yicIwsbFfrFLefOB88290DDPOBRpMWotr174rzSbqow1o/qkCigJ+4ijKDBCKeglvhaV aAPKcVAqN5HH43Mrcp2YxC5Wb4WBu2f6G+zo5s1Hh0//oxKvUGzgPxRuIFcNqeQmyVba jVDA== X-Gm-Message-State: AOAM531skvKdzvMIFDHVxfEJgFvQwB3vKUpJJugEZ3xHjXjpO2nbRm2p oqQxv7m/vH6zenItiNHSUMQMaRvjPj/MzgQjQUK3JpG2mOjUaeOzczbP6qoW0Sw8iISJwWdPM+f O4/kk6H7DhfxEHXTAlvTavJgl5XSmPOPWRP6eavtMDQ== X-Received: by 2002:a63:74e:: with SMTP id 75mr7415335pgh.200.1621824797355; Sun, 23 May 2021 19:53:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzP1ngdwvFX7GKxWKgZ4m6yITaZWeGU+YceEWcYXFbWXp51SlQUq1uR/X6gvfXsGOJdOyWhtQ== X-Received: by 2002:a63:74e:: with SMTP id 75mr7415321pgh.200.1621824797107; Sun, 23 May 2021 19:53:17 -0700 (PDT) Received: from wangxiaodeMacBook-Air.local ([209.132.188.80]) by smtp.gmail.com with ESMTPSA id b9sm9335313pfo.107.2021.05.23.19.53.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 23 May 2021 19:53:16 -0700 (PDT) Subject: Re: virtio_net: BQL? To: Dave Taht , Willem de Bruijn References: <56270996-33a6-d71b-d935-452dad121df7@linux.alibaba.com> From: Jason Wang Message-ID: Date: Mon, 24 May 2021 10:53:08 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jasowang@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Cc: "Michael S. Tsirkin" , Xianting Tian , Linux Kernel Network Developers , LKML , virtualization , bloat , Jakub Kicinski , "David S. Miller" X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" CuWcqCAyMDIxLzUvMTgg5LiK5Y2INTo0OCwgRGF2ZSBUYWh0IOWGmemBkzoKPiBPbiBNb24sIE1h eSAxNywgMjAyMSBhdCAxOjIzIFBNIFdpbGxlbSBkZSBCcnVpam4KPiA8d2lsbGVtZGVicnVpam4u a2VybmVsQGdtYWlsLmNvbT4gd3JvdGU6Cj4+IE9uIE1vbiwgTWF5IDE3LCAyMDIxIGF0IDI6NDQg UE0gRGF2ZSBUYWh0IDxkYXZlLnRhaHRAZ21haWwuY29tPiB3cm90ZToKPj4+IE5vdCByZWFsbHkg cmVsYXRlZCB0byB0aGlzIHBhdGNoLCBidXQgaXMgdGhlcmUgc29tZSByZWFzb24gd2h5IHZpcnRp bwo+Pj4gaGFzIG5vIHN1cHBvcnQgZm9yIEJRTD8KPj4gVGhlcmUgaGF2ZSBiZWVuIGEgZmV3IGF0 dGVtcHRzIHRvIGFkZCBpdCBvdmVyIHRoZSB5ZWFycy4KPj4KPj4gTW9zdCByZWNlbnRseSwgaHR0 cHM6Ly9sb3JlLmtlcm5lbC5vcmcvbGttbC8yMDE4MTIwNTIyNTMyMy4xMjU1NS0yLW1zdEByZWRo YXQuY29tLwo+Pgo+PiBUaGF0IHRocmVhZCBoYXMgYSBsb25nIGRpc2N1c3Npb24uIEkgdGhpbmsg dGhlIGtleSBvcGVuIGlzc3VlIHJlbWFpbnMKPj4KPj4gIlRoZSB0cmlja3kgcGFydCBpcyB0aGUg bW9kZSBzd2l0Y2hpbmcgYmV0d2VlbiBuYXBpIGFuZCBubyBuYXBpLiIKPiBPeSwgdmV5Lgo+Cj4g SSBkaWRuJ3QgcGF5IGFueSBhdHRlbnRpb24gdG8gdGhhdCBkaXNjdXNzaW9uLCBzYWRseSBlbm91 Z2guCj4KPiBJdCdzIGJlZW4gYWJvdXQgdGhhdCBsb25nICgyMDE4KSBzaW5jZSBJIHBhaWQgYW55 IGF0dGVudGlvbiB0bwo+IGJ1ZmZlcmJsb2F0IGluIHRoZSBjbG91ZCBhbmQgbXkgY2xvdWR5IHBy b3ZpZGVyIChsaW5vZGUpIHN3aXRjaGVkIHRvCj4gdXNpbmcgdmlydGlvIHdoZW4gSSB3YXNuJ3Qg bG9va2luZy4gRm9yIG92ZXIgYSB5ZWFyIG5vdywgSSdkIGJlZW4KPiBnZXR0aW5nIHJlcG9ydHMg c2F5aW5nIHRoYXQgY29tY2FzdCdzIHBpZSByb2xsb3V0IHdhc24ndCB3b3JraW5nIGFzCj4gd2Vs bCBhcyBleHBlY3RlZCwgdGhhdCBldmVucm91dGUncyBpbXBsZW1lbnRhdGlvbiBvZiBzY2hfY2Fr ZSBhbmQgc3FtCj4gb24gaW5ib3VuZCB3YXNuJ3Qgd29ya2luZyByaWdodCwgbm9yIHBmX3NlbnNl J3MgYW5kIG51bWVyb3VzIG90aGVyCj4gaXNzdWVzIGF0IEludGVybmV0IHNjYWxlLgo+Cj4gTGFz dCB3ZWVrIEkgcmFuIGEgc3RyaW5nIG9mIGJlbmNobWFya3MgYWdhaW5zdCBzdGFybGluaydzIG5l dyBzZXJ2aWNlcwo+IGFuZCB3YXMgcmVhbGx5IGFnaGFzdCBhdCB3aGF0IEkgZm91bmQgdGhlcmUs IHRvby4gYnV0IHRoZSBwcm9ibGVtCj4gc2VlbWVkIGRlZXBlciB0aGFuIGluIGp1c3QgdGhlIGRp c2h5Li4uCj4KPiBXaXRob3V0IEJRTCwgdGhlcmUncyBubyBiYWNrcHJlc3N1cmUgZm9yIGZxX2Nv ZGVsIHRvIGRvIGl0cyB0aGluZy4KPiBOb25lLiBNeSBtZWFzdXJlbWVudCBzZXJ2ZXJzIGFyZW4n dCBGUS1jb2RlbGluZwo+IG5vIG1hdHRlciBob3cgbXVjaCBsb2FkIEkgcHV0IG9uIHRoZW0uIFNp bmNlIHRoYXQgcWRpc2MgaXMgdGhlIGRlZmF1bHQKPiBub3cgaW4gbW9zdCBsaW51eCBkaXN0cmli dXRpb25zLCBJIGltYWdpbmUgdGhhdCB0aGUgYnVsayBvZiB0aGUgY2xvdWQKPiBpcyBub3cgYmVo YXZpbmcgYXMgZXJyYXRpY2FsbHkgYXMgbGludXggd2FzIGluIDIwMTEgd2l0aCBlbm9ybW91cwo+ IHN3aW5ncyBpbiB0aHJvdWdocHV0IGFuZCBsYXRlbmN5IGZyb20gR1NPL1RTTyBoaXR0aW5nIG92 ZXJsYXJnZSByeC90eAo+IHJpbmdzLCBbMV0sIGJyZWFraW5nIHZhcmlvdXMgcmF0ZSBlc3RpbWF0 b3JzIGluIGNvZGVsLCBwaWUgYW5kIHRoZSB0Y3AKPiBzdGFjayBpdHNlbGYuCj4KPiBTZWU6Cj4K PiBodHRwOi8vZnJlbW9udC5zdGFybGluay50YWh0Lm5ldC9+ZC92aXJ0aW9fbm9icWwvcnJ1bF8t X2V2ZW5yb3V0ZV92M19zZXJ2ZXJfZnFfY29kZWwucG5nCj4KPiBTZWUgdGhlIHN3aW5ncyBpbiBs YXRlbmN5IHRoZXJlPyB0aGF0J3Mgc3ltcHRvbWF0aWMgb2YgdHgvcnggcmluZ3MKPiBmaWxsaW5n IGFuZCBlbXB0eWluZy4KPgo+IGl0IHdhc24ndCB1bnRpbCBJIHN3aXRjaGVkIG15IG1lYXN1cmVt ZW50IHNlcnZlciB0ZW1wb3JhcmlseSBvdmVyIHRvCj4gc2NoX2ZxIHRoYXQgSSBnb3QgYSBycnVs IHJlc3VsdCB0aGF0IHdhcyBjbG9zZSB0byB0aGUgcmVzdWx0cyB3ZSB1c2VkCj4gdG8gZ2V0IGZy b20gdGhlIHZpcnR1YWxpemVkIGUxMDAwZSBkcml2ZXJzIHdlIHdlcmUgdXNpbmcgaW4gMjAxNC4K Pgo+IGh0dHA6Ly9mcmVtb250LnN0YXJsaW5rLnRhaHQubmV0L35kL3ZpcnRpb19ub2JxbC9ycnVs Xy1fZXZlbnJvdXRlX3YzX3NlcnZlcl9mcS5wbmcKPgo+IFdoaWxlIEkgaGF2ZSBsb25nIHN1cHBv cnRlZCB0aGUgdXNlIG9mIHNjaF9mcSBmb3IgdGNwLWhlYXZ5IHdvcmtsb2FkcywKPiBpdCBzdGls bCBiZWhhdmVzIGJldHRlciB3aXRoIGJxbCBpbiBwbGFjZSwgYW5kIGZxX2NvZGVsIGlzIGJldHRl ciBmb3IKPiBnZW5lcmljIHdvcmtsb2Fkcy4uLiBidXQgbmVlZHMgYnFsIGJhc2VkIGJhY2twcmVz c3VyZSB0byBraWNrIGluLgo+Cj4gWzFdIEkgcmVhbGx5IGhvcGUgSSdtIG92ZXJyZWFjdGluZyBi dXQsIHVtLCBlciwgY291bGQgc29tZW9uZShzKSBzcGluCj4gdXAgYSBuZXcgcGF0Y2ggdGhhdCBk b2VzIGJxbCBpbiBzb21lIHdheSBldmVuIGhhbGYgcmlnaHQgZm9yIHRoaXMKPiBkcml2ZXIgYW5k IGhlbHAgdGVzdCBpdD8gSSBoYXZlbid0IGJ1aWx0IGEga2VybmVsIGluIGEgd2hpbGUuCgoKSSB0 aGluayBpdCdzIHRpbWUgdG8gb2Jzb2xldGUgc2tiX29ycGhhbigpIGZvciB2aXJ0aW8tbmV0IHRv IGdldCByaWQgb2YgCmEgYnJ1bmNoIG9mIHRyaWNreSBjb2RlcyBpbiB0aGUgY3VycmVudCB2aXJ0 aW8tbmV0IGRyaXZlci4KClRoZW4gd2UgY2FuIGRvIEJRTCBvbiB0b3AuCgpJIHdpbGwgcHJlcGFy ZSBzb21lIHBhdGNoZXMgdG8gZG8gdGhpcyAocHJvYmFibHkgd2l0aCBNaWNoYWVsJ3MgQlFMIHBh dGNoKS4KClRoYW5rcwoKCj4KPgo+Pj4gT24gTW9uLCBNYXkgMTcsIDIwMjEgYXQgMTE6NDEgQU0g WGlhbnRpbmcgVGlhbgo+Pj4gPHhpYW50aW5nLnRpYW5AbGludXguYWxpYmFiYS5jb20+IHdyb3Rl Ogo+Pj4+IEJVR19PTigpIHVzZXMgdW5saWtlbHkgaW4gaWYoKSwgd2hpY2ggY2FuIGJlIG9wdGlt aXplZCBhdCBjb21waWxlIHRpbWUuCj4+Pj4KPj4+PiBTaWduZWQtb2ZmLWJ5OiBYaWFudGluZyBU aWFuIDx4aWFudGluZy50aWFuQGxpbnV4LmFsaWJhYmEuY29tPgo+Pj4+IC0tLQo+Pj4+ICAgIGRy aXZlcnMvbmV0L3ZpcnRpb19uZXQuYyB8IDUgKystLS0KPj4+PiAgICAxIGZpbGUgY2hhbmdlZCwg MiBpbnNlcnRpb25zKCspLCAzIGRlbGV0aW9ucygtKQo+Pj4+Cj4+Pj4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvbmV0L3ZpcnRpb19uZXQuYyBiL2RyaXZlcnMvbmV0L3ZpcnRpb19uZXQuYwo+Pj4+IGlu ZGV4IGM5MjFlYmYzYWU4Mi4uMjEyZDUyMjA0ODg0IDEwMDY0NAo+Pj4+IC0tLSBhL2RyaXZlcnMv bmV0L3ZpcnRpb19uZXQuYwo+Pj4+ICsrKyBiL2RyaXZlcnMvbmV0L3ZpcnRpb19uZXQuYwo+Pj4+ IEBAIC0xNjQ2LDEwICsxNjQ2LDkgQEAgc3RhdGljIGludCB4bWl0X3NrYihzdHJ1Y3Qgc2VuZF9x dWV1ZSAqc3EsIHN0cnVjdAo+Pj4+IHNrX2J1ZmYgKnNrYikKPj4+PiAgICAgICAgICBlbHNlCj4+ Pj4gICAgICAgICAgICAgICAgICBoZHIgPSBza2Jfdm5ldF9oZHIoc2tiKTsKPj4+Pgo+Pj4+IC0g ICAgICAgaWYgKHZpcnRpb19uZXRfaGRyX2Zyb21fc2tiKHNrYiwgJmhkci0+aGRyLAo+Pj4+ICsg ICAgICAgQlVHX09OKHZpcnRpb19uZXRfaGRyX2Zyb21fc2tiKHNrYiwgJmhkci0+aGRyLAo+Pj4+ ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB2aXJ0aW9faXNfbGl0dGxlX2Vu ZGlhbih2aS0+dmRldiksIGZhbHNlLAo+Pj4+IC0gICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIDApKQo+Pj4+IC0gICAgICAgICAgICAgICBCVUcoKTsKPj4+PiArICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAwKSk7Cj4+Pj4KPj4+PiAgICAgICAgICBpZiAodmktPm1l cmdlYWJsZV9yeF9idWZzKQo+Pj4+ICAgICAgICAgICAgICAgICAgaGRyLT5udW1fYnVmZmVycyA9 IDA7Cj4+Pj4gLS0KPj4+PiAyLjE3LjEKPj4+Pgo+Pj4KPj4+IC0tCj4+PiBMYXRlc3QgUG9kY2Fz dDoKPj4+IGh0dHBzOi8vd3d3LmxpbmtlZGluLmNvbS9mZWVkL3VwZGF0ZS91cm46bGk6YWN0aXZp dHk6Njc5MTAxNDI4NDkzNjc4NTkyMC8KPj4+Cj4+PiBEYXZlIFTDpGh0IENUTywgVGVrTGlicmUs IExMQwo+Cj4KPiAtLQo+IExhdGVzdCBQb2RjYXN0Ogo+IGh0dHBzOi8vd3d3LmxpbmtlZGluLmNv bS9mZWVkL3VwZGF0ZS91cm46bGk6YWN0aXZpdHk6Njc5MTAxNDI4NDkzNjc4NTkyMC8KPgo+IERh dmUgVMOkaHQgQ1RPLCBUZWtMaWJyZSwgTExDCj4KCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fClZpcnR1YWxpemF0aW9uIG1haWxpbmcgbGlzdApWaXJ0dWFs aXphdGlvbkBsaXN0cy5saW51eC1mb3VuZGF0aW9uLm9yZwpodHRwczovL2xpc3RzLmxpbnV4Zm91 bmRhdGlvbi5vcmcvbWFpbG1hbi9saXN0aW5mby92aXJ0dWFsaXphdGlvbg==