From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 71C3BC4332F for ; Thu, 20 Oct 2022 14:38:19 +0000 (UTC) Received: from localhost ([::1]:46332 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1olWgZ-0007HH-MC for qemu-devel@archiver.kernel.org; Thu, 20 Oct 2022 10:38:17 -0400 Received: from [::1] (helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1olWgG-0004gF-Qp for qemu-devel@archiver.kernel.org; Thu, 20 Oct 2022 10:37:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38238) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1olUsx-00021J-Dn; Thu, 20 Oct 2022 08:42:58 -0400 Received: from out30-130.freemail.mail.aliyun.com ([115.124.30.130]:37599) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1olUsv-0002cG-Gy; Thu, 20 Oct 2022 08:42:55 -0400 X-Alimail-AntiSpam: AC=PASS; BC=-1|-1; BR=01201311R161e4; CH=green; DM=||false|; DS=||; FP=0|-1|-1|-1|0|-1|-1|-1; HT=ay29a033018046050; MF=zhiwei_liu@linux.alibaba.com; NM=1; PH=DS; RN=7; SR=0; TI=SMTPD_---0VSfCbWl_1666269764; Received: from 30.221.96.197(mailfrom:zhiwei_liu@linux.alibaba.com fp:SMTPD_---0VSfCbWl_1666269764) by smtp.aliyun-inc.com; Thu, 20 Oct 2022 20:42:45 +0800 Message-ID: Date: Thu, 20 Oct 2022 20:42:43 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.3 Subject: Re: [RFC PATCH 2/3] tcg/riscv: Fix tcg_out_opc_imm when imm exceeds Content-Language: en-US To: Richard Henderson , qemu-devel@nongnu.org, qemu-riscv@nongnu.org Cc: Alistair.Francis@wdc.com, palmer@dabbelt.com, bin.meng@windriver.com, lzw194868@alibaba-inc.com References: <20221020104154.4276-1-zhiwei_liu@linux.alibaba.com> <20221020104154.4276-3-zhiwei_liu@linux.alibaba.com> <49246207-2202-0239-65f5-1f0b44d8bd64@linaro.org> From: LIU Zhiwei In-Reply-To: <49246207-2202-0239-65f5-1f0b44d8bd64@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=115.124.30.130; envelope-from=zhiwei_liu@linux.alibaba.com; helo=out30-130.freemail.mail.aliyun.com X-Spam_score_int: -98 X-Spam_score: -9.9 X-Spam_bar: --------- X-Spam_report: (-9.9 / 5.0 requ) BAYES_00=-1.9, ENV_AND_HDR_SPF_MATCH=-0.5, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001, USER_IN_DEF_SPF_WL=-7.5 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 2022/10/20 19:22, Richard Henderson wrote: > On 10/20/22 20:41, LIU Zhiwei wrote: >> TYPE-I immediate can only represent a signed 12-bit value. If immediate >> exceed, mov it to an register. >> >> Signed-off-by: LIU Zhiwei >> --- >>   tcg/riscv/tcg-target.c.inc | 28 +++++++++++++++++++++++----- >>   1 file changed, 23 insertions(+), 5 deletions(-) >> >> diff --git a/tcg/riscv/tcg-target.c.inc b/tcg/riscv/tcg-target.c.inc >> index 32f4bc7bfc..bfdf2bea69 100644 >> --- a/tcg/riscv/tcg-target.c.inc >> +++ b/tcg/riscv/tcg-target.c.inc >> @@ -668,7 +668,12 @@ static void tcg_out_addsub2(TCGContext *s, >>       if (!cbh) { >>           tcg_out_opc_reg(s, (is_sub ? opc_sub : opc_add), th, ah, bh); >>       } else if (bh != 0 || ah == rl) { >> -        tcg_out_opc_imm(s, opc_addi, th, ah, (is_sub ? -bh : bh)); >> +        if (bh == sextract(bh, 0, 12)) { >> +            tcg_out_opc_imm(s, opc_addi, th, ah, (is_sub ? -bh : bh)); >> +        } else { >> +            tcg_out_movi(s, TCG_TYPE_TL, th, (is_sub ? -bh : bh)); >> +            tcg_out_opc_reg(s, opc_add, th, ah, th); >> +        } > > This value is currently constrained by 'M': +/- 0xfff. Thanks. I missed it. > You're suggesting that the fix should be to use 'I', which is signed > 12-bit. > > But this fix is definitely in the wrong place. OK. I will have a try to look for the correct place. Best Regards, Zhiwei > > > r~