From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751365AbdEBUGy (ORCPT ); Tue, 2 May 2017 16:06:54 -0400 Received: from mout.web.de ([212.227.17.11]:55416 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750850AbdEBUGx (ORCPT ); Tue, 2 May 2017 16:06:53 -0400 Subject: [PATCH 1/3] GPU-DRM-Radeon: Use seq_putc() in radeon_sa_bo_dump_debug_info() From: SF Markus Elfring To: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Alex Deucher , =?UTF-8?Q?Christian_K=c3=b6nig?= , David Airlie Cc: LKML , kernel-janitors@vger.kernel.org References: <74d2df52-f509-e6d2-5b35-e25b7cbd1fbe@users.sourceforge.net> Message-ID: Date: Tue, 2 May 2017 22:06:35 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 MIME-Version: 1.0 In-Reply-To: <74d2df52-f509-e6d2-5b35-e25b7cbd1fbe@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:02VtJWyUcS4TrlqficyFl2Y7fwJcJE/T+dIH9Y2lhHdFZ6LIKwF uLTKj2eOkOsSrN4VBDExGuQqR4hbU7/KfG7vk039iAgEEeGKREVEfXtKwGgJCZB7EhsRYdg KuLmXD3tZEMobS716lGf31iNsoubbf5eerXUPziJ7FpOgU/VxCVPLFYxEoAxGqh+l2lnv3M /g0GBcOA6Pz/Cuj630gAA== X-UI-Out-Filterresults: notjunk:1;V01:K0:G5J0Hmp/Rxg=:s/NDInP7o8DF5dvAOt5x8x 9JhsZO7vn2u5fW7OkHZMX9KUeEH7ilzTvBT+UO9apkj2/DYJYvIkZgCK9aI3+Ammkf7+b7HQz EZE5oJFbf8At/137KMqIln1v+PBSKA4RifyYuLPko16S8rQ6YvBv9in9qfWN9Ehj3p4OdTrTU QJF/EouoVZ+w6D3x0zKrMSzucyg8X2WrOrsjti3XorMXu5lzfTUb+VW+R/gA5bse8V9kY9FLv UBQBl83LFP/UgUpcg2ZJRmNU2icSQJ8Y+7Ub9UBsEZ6z46CFcZ9Lz8qLeNESiC+a95P2C7CuX 9HeG+6JUuWoEQNiMHY6Dr8fqwTLXArs+23+wSZiEmOMUj6a8gsJK6jVs9vbEXmvONTjPIZJiY M6mhA5ukOaGkLIsVvG/ixQkJB9MFaI+LDgZNNOnrjF9QRPNMb63KOgx6QaLC7Fx+qlsh0JG3W 0D22EwEtK9Owi9ROY+uMxDz2X7jarECXJMrk3KpO6SzQ0i7O59MywdtiplNuGATGr5Z341fcy SoYSgajuX01IazAoJ/5LUASQ7fbPJg0ghft2tblT2F9KDgIPp6SVgAdimgO6aueydNmAQ++Kp dOM17kJCHnxKNQPx3Fr8VSUAmXLq1Xab19nAa1TzDNb+8v8HAzuvPs1aUJGFi4MaOx+NeO5ln mbL+Wck8E8bwXyTVCPTCxjVD5YG39sixNIkYJS+kyYdAn9tYh72m1kJzrx5Q7t+8SJVN+RgDT lixyGr6PxYrnechM6TGxLnOFjMMYVTahOzHnnkiLRgwx578vTbX1HFzVhJaTCCTEH+akgR+8u YOSkXl7 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Tue, 2 May 2017 21:35:48 +0200 A few single characters should be put into a sequence. Thus use the corresponding function "seq_putc". This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/gpu/drm/radeon/radeon_sa.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_sa.c b/drivers/gpu/drm/radeon/radeon_sa.c index 197b157b73d0..67bc3618798d 100644 --- a/drivers/gpu/drm/radeon/radeon_sa.c +++ b/drivers/gpu/drm/radeon/radeon_sa.c @@ -406,18 +406,15 @@ void radeon_sa_bo_dump_debug_info(struct radeon_sa_manager *sa_manager, list_for_each_entry(i, &sa_manager->olist, olist) { uint64_t soffset = i->soffset + sa_manager->gpu_addr; uint64_t eoffset = i->eoffset + sa_manager->gpu_addr; - if (&i->olist == sa_manager->hole) { - seq_printf(m, ">"); - } else { - seq_printf(m, " "); - } + + seq_putc(m, (&i->olist == sa_manager->hole) ? '>' : ' '); seq_printf(m, "[0x%010llx 0x%010llx] size %8lld", soffset, eoffset, eoffset - soffset); if (i->fence) { seq_printf(m, " protected by 0x%016llx on ring %d", i->fence->seq, i->fence->ring); } - seq_printf(m, "\n"); + seq_putc(m, '\n'); } spin_unlock(&sa_manager->wq.lock); } -- 2.12.2 From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Date: Tue, 02 May 2017 20:06:35 +0000 Subject: [PATCH 1/3] GPU-DRM-Radeon: Use seq_putc() in radeon_sa_bo_dump_debug_info() Message-Id: List-Id: References: <74d2df52-f509-e6d2-5b35-e25b7cbd1fbe@users.sourceforge.net> In-Reply-To: <74d2df52-f509-e6d2-5b35-e25b7cbd1fbe@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Alex Deucher , =?UTF-8?Q?Christian_K=c3=b6nig?= , David Airlie Cc: LKML , kernel-janitors@vger.kernel.org From: Markus Elfring Date: Tue, 2 May 2017 21:35:48 +0200 A few single characters should be put into a sequence. Thus use the corresponding function "seq_putc". This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/gpu/drm/radeon/radeon_sa.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_sa.c b/drivers/gpu/drm/radeon/radeon_sa.c index 197b157b73d0..67bc3618798d 100644 --- a/drivers/gpu/drm/radeon/radeon_sa.c +++ b/drivers/gpu/drm/radeon/radeon_sa.c @@ -406,18 +406,15 @@ void radeon_sa_bo_dump_debug_info(struct radeon_sa_manager *sa_manager, list_for_each_entry(i, &sa_manager->olist, olist) { uint64_t soffset = i->soffset + sa_manager->gpu_addr; uint64_t eoffset = i->eoffset + sa_manager->gpu_addr; - if (&i->olist = sa_manager->hole) { - seq_printf(m, ">"); - } else { - seq_printf(m, " "); - } + + seq_putc(m, (&i->olist = sa_manager->hole) ? '>' : ' '); seq_printf(m, "[0x%010llx 0x%010llx] size %8lld", soffset, eoffset, eoffset - soffset); if (i->fence) { seq_printf(m, " protected by 0x%016llx on ring %d", i->fence->seq, i->fence->ring); } - seq_printf(m, "\n"); + seq_putc(m, '\n'); } spin_unlock(&sa_manager->wq.lock); } -- 2.12.2