From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Durrant Subject: Re: [PATCH 5/5] xen/ARM: Restrict access to most HVM_PARAM's Date: Thu, 6 Sep 2018 09:29:24 +0000 Message-ID: References: <1536171124-27053-1-git-send-email-andrew.cooper3@citrix.com> <1536171124-27053-6-git-send-email-andrew.cooper3@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1536171124-27053-6-git-send-email-andrew.cooper3@citrix.com> Content-Language: en-US List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Xen-devel Cc: Stefano Stabellini , Wei Liu , Andrew Cooper , Julien Grall , Jan Beulich , Roger Pau Monne List-Id: xen-devel@lists.xenproject.org PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBBbmRyZXcgQ29vcGVyIFttYWls dG86YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNvbV0NCj4gU2VudDogMDUgU2VwdGVtYmVyIDIwMTgg MTk6MTINCj4gVG86IFhlbi1kZXZlbCA8eGVuLWRldmVsQGxpc3RzLnhlbi5vcmc+DQo+IENjOiBB bmRyZXcgQ29vcGVyIDxBbmRyZXcuQ29vcGVyM0BjaXRyaXguY29tPjsgSmFuIEJldWxpY2gNCj4g PEpCZXVsaWNoQHN1c2UuY29tPjsgV2VpIExpdSA8d2VpLmxpdTJAY2l0cml4LmNvbT47IFJvZ2Vy IFBhdSBNb25uZQ0KPiA8cm9nZXIucGF1QGNpdHJpeC5jb20+OyBQYXVsIER1cnJhbnQgPFBhdWwu RHVycmFudEBjaXRyaXguY29tPjsgU3RlZmFubw0KPiBTdGFiZWxsaW5pIDxzc3RhYmVsbGluaUBr ZXJuZWwub3JnPjsgSnVsaWVuIEdyYWxsIDxqdWxpZW4uZ3JhbGxAYXJtLmNvbT4NCj4gU3ViamVj dDogW1BBVENIIDUvNV0geGVuL0FSTTogUmVzdHJpY3QgYWNjZXNzIHRvIG1vc3QgSFZNX1BBUkFN J3MNCj4gDQo+IEFSTSBjdXJyZW50bHkgaGFzIG5vIHJlc3RyaWN0aW9ucyBvbiB0b29sc3RhY2sg YW5kIGd1ZXN0IGFjY2VzcyB0byB0aGUgZW50aXJlDQo+IEhWTV9QQVJBTSBibG9jay4gIEFzIHRo ZSBwYWdpbmcvbW9uaXRvci9zaGFyaW5nIGZlYXR1cmVzIGFyZW4ndCB1bmRlcg0KPiBzZWN1cml0 eQ0KPiBzdXBwb3J0LCB0aGlzIGRvZXNuJ3QgbmVlZCBhbiBYU0EuDQo+IA0KPiBUaGUgQ0FMTEJB Q0tfSVJRIGFuZCB7U1RPUkUsQ09OU09MRX1fe1BGTixFVlRDSE59IGRldGFpbHMgZXhwb3NlZA0K PiByZWFkLW9ubHkgdG8NCj4gdGhlIGd1ZXN0LCB3aGlsZSB0aGUgKl9SSU5HX1BGTiBkZXRhaWxz IGFyZSByZXN0cmljdGVkIHRvIG9ubHkgdG9vbHN0YWNrDQo+IGFjY2Vzcy4gIE5vIG90aGVyIHBh cmFtZXRlcnMgYXJlIHVzZWQuDQo+IA0KPiBTaWduZWQtb2ZmLWJ5OiBBbmRyZXcgQ29vcGVyIDxh bmRyZXcuY29vcGVyM0BjaXRyaXguY29tPg0KPiAtLS0NCj4gQ0M6IEphbiBCZXVsaWNoIDxKQmV1 bGljaEBzdXNlLmNvbT4NCj4gQ0M6IFdlaSBMaXUgPHdlaS5saXUyQGNpdHJpeC5jb20+DQo+IEND OiBSb2dlciBQYXUgTW9ubsOpIDxyb2dlci5wYXVAY2l0cml4LmNvbT4NCj4gQ0M6IFBhdWwgRHVy cmFudCA8cGF1bC5kdXJyYW50QGNpdHJpeC5jb20+DQo+IENDOiBTdGVmYW5vIFN0YWJlbGxpbmkg PHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+DQo+IENDOiBKdWxpZW4gR3JhbGwgPGp1bGllbi5ncmFs bEBhcm0uY29tPg0KPiANCj4gVGhpcyBpcyBvbmx5IGNvbXBpbGUgdGVzdGVkLCBhbmQgYmFzZWQg b24gbXkgcmVhZGluZyBvZiB0aGUgc291cmNlLiAgVGhlcmUNCj4gbWlnaHQgYmUgb3RoZXIgUEFS QU1TIG5lZWRpbmcgaW5jbHVkaW5nLg0KPiAtLS0NCj4gIHhlbi9hcmNoL2FybS9odm0uYyB8IDYy DQo+ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0t LQ0KPiAgMSBmaWxlIGNoYW5nZWQsIDU5IGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0pDQo+ IA0KPiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gvYXJtL2h2bS5jIGIveGVuL2FyY2gvYXJtL2h2bS5j DQo+IGluZGV4IDc2YjI3YzkuLjM1ODFiYTIgMTAwNjQ0DQo+IC0tLSBhL3hlbi9hcmNoL2FybS9o dm0uYw0KPiArKysgYi94ZW4vYXJjaC9hcm0vaHZtLmMNCj4gQEAgLTMxLDYgKzMxLDU3IEBADQo+ IA0KPiAgI2luY2x1ZGUgPGFzbS9oeXBlcmNhbGwuaD4NCj4gDQo+ICtzdGF0aWMgaW50IGh2bV9h bGxvd19zZXRfcGFyYW0oY29uc3Qgc3RydWN0IGRvbWFpbiAqZCwgdW5zaWduZWQgaW50DQo+IHBh cmFtKQ0KPiArew0KPiArICAgIHN3aXRjaCAoIHBhcmFtICkNCj4gKyAgICB7DQo+ICsgICAgICAg IC8qDQo+ICsgICAgICAgICAqIFRoZSBmb2xsb3dpbmcgcGFyYW1ldGVycyBhcmUgaW50ZW5kZWQg Zm9yIHRvb2xzdGFjayB1c2FnZSBvbmx5Lg0KPiArICAgICAgICAgKiBUaGV5IG1heSBub3QgYmUg c2V0IGJ5IHRoZSBkb21haW4uDQo+ICsgICAgICAgICAqLw0KPiArICAgIGNhc2UgSFZNX1BBUkFN X0NBTExCQUNLX0lSUToNCj4gKyAgICBjYXNlIEhWTV9QQVJBTV9TVE9SRV9QRk46DQo+ICsgICAg Y2FzZSBIVk1fUEFSQU1fU1RPUkVfRVZUQ0hOOg0KPiArICAgIGNhc2UgSFZNX1BBUkFNX0NPTlNP TEVfUEZOOg0KPiArICAgIGNhc2UgSFZNX1BBUkFNX0NPTlNPTEVfRVZUQ0hOOg0KDQpQcm9iYWJs eSBzaG91bGQgcmVtb3ZlIHRoZSBFVlRDSE4gcGFyYW1zIGZyb20gdGhpcyBsaXN0IGFmdGVyIGZp eGluZyBwYXRjaCAjMy4NCg0KPiArICAgIGNhc2UgSFZNX1BBUkFNX1BBR0lOR19SSU5HX1BGTjoN Cj4gKyAgICBjYXNlIEhWTV9QQVJBTV9NT05JVE9SX1JJTkdfUEZOOg0KPiArICAgIGNhc2UgSFZN X1BBUkFNX1NIQVJJTkdfUklOR19QRk46DQo+ICsgICAgICAgIHJldHVybiBkID09IGN1cnJlbnQt PmRvbWFpbiA/IC1FUEVSTSA6IDA7DQo+ICsNCj4gKyAgICAgICAgLyogV3JpdGVhYmxlIG9ubHkg YnkgWGVuLCBob2xlLCBkZXByZWNhdGVkLCBvciBvdXQtb2YtcmFuZ2UuICovDQo+ICsgICAgZGVm YXVsdDoNCj4gKyAgICAgICAgcmV0dXJuIC1FSU5WQUw7DQo+ICsgICAgfQ0KPiArfQ0KPiArDQo+ ICtzdGF0aWMgaW50IGh2bV9hbGxvd19nZXRfcGFyYW0oY29uc3Qgc3RydWN0IGRvbWFpbiAqZCwg dW5zaWduZWQgaW50DQo+IHBhcmFtKQ0KPiArew0KPiArICAgIHN3aXRjaCAoIHBhcmFtICkNCj4g KyAgICB7DQo+ICsgICAgICAgIC8qIFRoZSBmb2xsb3dpbmcgcGFyYW1ldGVycyBjYW4gYmUgcmVh ZCBieSB0aGUgZ3Vlc3QgYW5kIHRvb2xzdGFjay4gKi8NCj4gKyAgICBjYXNlIEhWTV9QQVJBTV9D QUxMQkFDS19JUlE6DQo+ICsgICAgY2FzZSBIVk1fUEFSQU1fU1RPUkVfUEZOOg0KPiArICAgIGNh c2UgSFZNX1BBUkFNX1NUT1JFX0VWVENITjoNCj4gKyAgICBjYXNlIEhWTV9QQVJBTV9DT05TT0xF X1BGTjoNCj4gKyAgICBjYXNlIEhWTV9QQVJBTV9DT05TT0xFX0VWVENITjoNCj4gKyAgICAgICAg cmV0dXJuIDA7DQo+ICsNCj4gKyAgICAgICAgLyoNCj4gKyAgICAgICAgICogVGhlIGZvbGxvd2lu ZyBwYXJhbWV0ZXJzIGFyZSBpbnRlbmRlZCBmb3IgdG9vbHN0YWNrIHVzYWdlIG9ubHkuDQo+ICsg ICAgICAgICAqIFRoZXkgbWF5IG5vdCBiZSByZWFkIGJ5IHRoZSBkb21haW4uDQo+ICsgICAgICAg ICAqLw0KPiArICAgIGNhc2UgSFZNX1BBUkFNX1BBR0lOR19SSU5HX1BGTjoNCj4gKyAgICBjYXNl IEhWTV9QQVJBTV9NT05JVE9SX1JJTkdfUEZOOg0KPiArICAgIGNhc2UgSFZNX1BBUkFNX1NIQVJJ TkdfUklOR19QRk46DQo+ICsgICAgICAgIHJldHVybiBkID09IGN1cnJlbnQtPmRvbWFpbiA/IC1F UEVSTSA6IDA7DQo+ICsNCj4gKyAgICAgICAgLyogSG9sZSwgZGVwcmVjYXRlZCwgb3Igb3V0LW9m LXJhbmdlLiAqLw0KPiArICAgIGRlZmF1bHQ6DQo+ICsgICAgICAgIHJldHVybiAtRUlOVkFMOw0K PiArICAgIH0NCj4gK30NCj4gKw0KPiAgbG9uZyBkb19odm1fb3AodW5zaWduZWQgbG9uZyBvcCwg WEVOX0dVRVNUX0hBTkRMRV9QQVJBTSh2b2lkKQ0KPiBhcmcpDQo+ICB7DQo+ICAgICAgbG9uZyBy YyA9IDA7DQo+IEBAIC00Niw5ICs5Nyw2IEBAIGxvbmcgZG9faHZtX29wKHVuc2lnbmVkIGxvbmcg b3AsDQo+IFhFTl9HVUVTVF9IQU5ETEVfUEFSQU0odm9pZCkgYXJnKQ0KPiAgICAgICAgICBpZiAo IGNvcHlfZnJvbV9ndWVzdCgmYSwgYXJnLCAxKSApDQo+ICAgICAgICAgICAgICByZXR1cm4gLUVG QVVMVDsNCj4gDQo+IC0gICAgICAgIGlmICggYS5pbmRleCA+PSBIVk1fTlJfUEFSQU1TICkNCj4g LSAgICAgICAgICAgIHJldHVybiAtRUlOVkFMOw0KPiAtDQoNCkFTU0VSVCBoZXJlLg0KDQogIFBh dWwNCg0KPiAgICAgICAgICBkID0gcmN1X2xvY2tfZG9tYWluX2J5X2FueV9pZChhLmRvbWlkKTsN Cj4gICAgICAgICAgaWYgKCBkID09IE5VTEwgKQ0KPiAgICAgICAgICAgICAgcmV0dXJuIC1FU1JD SDsNCj4gQEAgLTU5LDEwICsxMDcsMTggQEAgbG9uZyBkb19odm1fb3AodW5zaWduZWQgbG9uZyBv cCwNCj4gWEVOX0dVRVNUX0hBTkRMRV9QQVJBTSh2b2lkKSBhcmcpDQo+IA0KPiAgICAgICAgICBp ZiAoIG9wID09IEhWTU9QX3NldF9wYXJhbSApDQo+ICAgICAgICAgIHsNCj4gKyAgICAgICAgICAg IHJjID0gaHZtX2FsbG93X3NldF9wYXJhbShkLCBhLmluZGV4KTsNCj4gKyAgICAgICAgICAgIGlm ICggcmMgKQ0KPiArICAgICAgICAgICAgICAgIGdvdG8gcGFyYW1fZmFpbDsNCj4gKw0KPiAgICAg ICAgICAgICAgZC0+YXJjaC5odm0ucGFyYW1zW2EuaW5kZXhdID0gYS52YWx1ZTsNCj4gICAgICAg ICAgfQ0KPiAgICAgICAgICBlbHNlDQo+ICAgICAgICAgIHsNCj4gKyAgICAgICAgICAgIHJjID0g aHZtX2FsbG93X2dldF9wYXJhbShkLCBhLmluZGV4KTsNCj4gKyAgICAgICAgICAgIGlmICggcmMg KQ0KPiArICAgICAgICAgICAgICAgIGdvdG8gcGFyYW1fZmFpbDsNCj4gKw0KPiAgICAgICAgICAg ICAgYS52YWx1ZSA9IGQtPmFyY2guaHZtLnBhcmFtc1thLmluZGV4XTsNCj4gICAgICAgICAgICAg IHJjID0gY29weV90b19ndWVzdChhcmcsICZhLCAxKSA/IC1FRkFVTFQgOiAwOw0KPiAgICAgICAg ICB9DQo+IC0tDQo+IDIuMS40DQoNCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fClhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRldmVsQGxpc3RzLnhlbnBy b2plY3Qub3JnCmh0dHBzOi8vbGlzdHMueGVucHJvamVjdC5vcmcvbWFpbG1hbi9saXN0aW5mby94 ZW4tZGV2ZWw=