From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3FD8C433E0 for ; Wed, 10 Feb 2021 01:27:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8003F64DD6 for ; Wed, 10 Feb 2021 01:27:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234990AbhBJB0y (ORCPT ); Tue, 9 Feb 2021 20:26:54 -0500 Received: from mga07.intel.com ([134.134.136.100]:15679 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234824AbhBIXLh (ORCPT ); Tue, 9 Feb 2021 18:11:37 -0500 IronPort-SDR: Yq8K1IXHHu/P6mCAvEDC2BqIN40tfYrwnykZdJeUyQcx9HTVQkh41ZTfZf4I4VY3wDUmPiJCm9 486U6ndPofIQ== X-IronPort-AV: E=McAfee;i="6000,8403,9890"; a="246041830" X-IronPort-AV: E=Sophos;i="5.81,166,1610438400"; d="scan'208";a="246041830" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Feb 2021 15:05:18 -0800 IronPort-SDR: a6arwtBDVlPnid9+/2ah9wjbZszzK/zJLS0ONW6THj5ne4QAa+B8fBY/tZKS6ShOMB874XtM2k fczV6phvdBYw== X-IronPort-AV: E=Sophos;i="5.81,166,1610438400"; d="scan'208";a="510117583" Received: from muncuer-mobl1.amr.corp.intel.com (HELO [10.209.127.55]) ([10.209.127.55]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Feb 2021 15:05:17 -0800 Subject: Re: [PATCH] ASoC: soc-pcm: change error message to debug message To: Mark Brown Cc: Shengjiu Wang , lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org References: <1612771965-5776-1-git-send-email-shengjiu.wang@nxp.com> <20210209222331.GD4916@sirena.org.uk> From: Pierre-Louis Bossart Message-ID: Date: Tue, 9 Feb 2021 17:05:16 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210209222331.GD4916@sirena.org.uk> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/9/21 4:23 PM, Mark Brown wrote: > On Mon, Feb 08, 2021 at 09:06:44AM -0600, Pierre-Louis Bossart wrote: > >> If you demote this to dev_dbg, we'll have to ask every single user who >> reports 'sound is broken' to enable dynamic debug traces. I really don't see >> the benefit, this is a clear case of 'fail big and fail early', partly >> concealing the problem doesn't make it go away but harder to diagnose. > > Don't you also get the same information out of the DAPM debugfs or did > I misread where the error is generated from? I re-checked and I will back-pedal on my comment. I confused this error message with the classic "ASoC: no backend DAIs enabled for %s". I didn't find a single occurrence of this "ASoC: no BE found for %s" in any bug report or Google search. Reviewed-by: Pierre-Louis Bossart From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BEA5FC433DB for ; Tue, 9 Feb 2021 23:33:07 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 60DD9601FF for ; Tue, 9 Feb 2021 23:33:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 60DD9601FF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id C7C421688; Wed, 10 Feb 2021 00:32:13 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz C7C421688 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1612913583; bh=811rKjInQqM21PeYFQOEaN1C1w+cYXlfG0x+V6tDNUA=; h=Subject:To:References:From:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=Xdm7MO/jBbOqia35gQCykFTr5ZFvpKvqUx4PLZQIICboKhJhGqhwkrJXH+lABL2u+ MoeqRpI8YRjBhSP+EHs+5p+ym0fcEGP3VktH2qgEQqS79mx8Ggm/HoIVc09oz6cCzm VNg0Gegy2uGNcGw3eOYkuaJQ1EgvNO3/5S2Z43cA= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 4BEB6F8016B; Wed, 10 Feb 2021 00:32:13 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 03607F801D5; Wed, 10 Feb 2021 00:32:12 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 7E865F8013A for ; Wed, 10 Feb 2021 00:31:58 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 7E865F8013A IronPort-SDR: YNxPEvClJ6g4Hq55BPTKU1yxABZXFEJLT5eUX6MxOLWmHhU6A6bJ8SwYFqr6BRcKMQ+ArXeTLZ 3+rZdj0i0Bgg== X-IronPort-AV: E=McAfee;i="6000,8403,9890"; a="182041296" X-IronPort-AV: E=Sophos;i="5.81,166,1610438400"; d="scan'208";a="182041296" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Feb 2021 15:05:18 -0800 IronPort-SDR: a6arwtBDVlPnid9+/2ah9wjbZszzK/zJLS0ONW6THj5ne4QAa+B8fBY/tZKS6ShOMB874XtM2k fczV6phvdBYw== X-IronPort-AV: E=Sophos;i="5.81,166,1610438400"; d="scan'208";a="510117583" Received: from muncuer-mobl1.amr.corp.intel.com (HELO [10.209.127.55]) ([10.209.127.55]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Feb 2021 15:05:17 -0800 Subject: Re: [PATCH] ASoC: soc-pcm: change error message to debug message To: Mark Brown References: <1612771965-5776-1-git-send-email-shengjiu.wang@nxp.com> <20210209222331.GD4916@sirena.org.uk> From: Pierre-Louis Bossart Message-ID: Date: Tue, 9 Feb 2021 17:05:16 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210209222331.GD4916@sirena.org.uk> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Cc: alsa-devel@alsa-project.org, lgirdwood@gmail.com, Shengjiu Wang , linux-kernel@vger.kernel.org, tiwai@suse.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 2/9/21 4:23 PM, Mark Brown wrote: > On Mon, Feb 08, 2021 at 09:06:44AM -0600, Pierre-Louis Bossart wrote: > >> If you demote this to dev_dbg, we'll have to ask every single user who >> reports 'sound is broken' to enable dynamic debug traces. I really don't see >> the benefit, this is a clear case of 'fail big and fail early', partly >> concealing the problem doesn't make it go away but harder to diagnose. > > Don't you also get the same information out of the DAPM debugfs or did > I misread where the error is generated from? I re-checked and I will back-pedal on my comment. I confused this error message with the classic "ASoC: no backend DAIs enabled for %s". I didn't find a single occurrence of this "ASoC: no BE found for %s" in any bug report or Google search. Reviewed-by: Pierre-Louis Bossart