From: Christophe JAILLET <email@example.com>
To: "Krzysztof Wilczyński" <firstname.lastname@example.org>
Cc: email@example.com, firstname.lastname@example.org,
email@example.com, firstname.lastname@example.org, email@example.com,
Subject: Re: [PATCH 3/3] PCI: tegra: make const array err_msg static
Date: Wed, 7 Jul 2021 20:24:41 +0200 [thread overview]
Message-ID: <firstname.lastname@example.org> (raw)
Le 06/07/2021 à 00:31, Krzysztof Wilczyński a écrit :
> Hi Christophe,
> Thank you for sending the patches over and taking care about these!
> I was wondering whether you will be willing to send a v2 of this series
> that would include fixes to everything the checkpatch.pl script reports
> against this driver? There aren't a lot of things to fix, thus the idea
> to squash everything at once. These warnings would be as follows
> (excluding the ones you taken care of in this series):
> drivers/pci/controller/pci-tegra.c:1661: WARNING: please, no space before tabs
> drivers/pci/controller/pci-tegra.c:1890: WARNING: quoted string split across lines
> drivers/pci/controller/pci-tegra.c:1891: WARNING: quoted string split across lines
> drivers/pci/controller/pci-tegra.c:2619: WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'.
> These should be trivial to fix. The two pertaining to "quoted string
> split across lines" would be something that we might or might not decide
> to do anything about this - technically, as per the Linux kernel coding
> style , we ought to fix this... but, this particular case is not
> a terrible example, so I will leave this at your discretion.
> What do you think?
I don't think it worth it.
Even for patch 2/3 about 'seq_printf' --> 'seq_puts' conversion, I'm not
fully convinced myself that is useful.
Too trivial clean-ups only mess-up 'git blame' for no real added value.
If you want these clean-ups, I can send a patch for it, but checkpatch
output need sometimes to be ignored on files already in the tree. At
least, this is my point of view.
> Also, don't worry if you don't have the time or otherwise, as these are
> trivial things and it would only be a bonus to take care of them.
> 1. https://www.kernel.org/doc/html/v4.10/process/coding-style.html#breaking-long-lines-and-strings
next prev parent reply other threads:[~2021-07-07 18:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-04 17:17 [PATCH 1/3] PCI: tegra: Fix OF node reference leak Christophe JAILLET
2021-05-04 17:17 ` [PATCH 2/3] PCI: tegra: Use 'seq_puts' instead of 'seq_printf' Christophe JAILLET
2021-07-05 17:01 ` Vidya Sagar
2021-05-04 17:18 ` [PATCH 3/3] PCI: tegra: make const array err_msg static Christophe JAILLET
2021-07-05 17:01 ` Vidya Sagar
2021-07-05 22:31 ` Krzysztof Wilczyński
2021-07-07 18:24 ` Christophe JAILLET [this message]
2021-07-07 19:52 ` Krzysztof Wilczyński
2021-06-22 10:42 ` [PATCH 1/3] PCI: tegra: Fix OF node reference leak Lorenzo Pieralisi
2021-07-05 17:00 ` Vidya Sagar
2021-08-05 10:43 ` Lorenzo Pieralisi
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.