From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=0.1 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,TRACKER_ID autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89104C10F0B for ; Tue, 2 Apr 2019 09:00:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5124A2075E for ; Tue, 2 Apr 2019 09:00:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729729AbfDBJAM (ORCPT ); Tue, 2 Apr 2019 05:00:12 -0400 Received: from smtprelay0215.hostedemail.com ([216.40.44.215]:43937 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729162AbfDBJAM (ORCPT ); Tue, 2 Apr 2019 05:00:12 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay03.hostedemail.com (Postfix) with ESMTP id 1F86D8368EF5; Tue, 2 Apr 2019 09:00:10 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: road75_58642180c7c51 X-Filterd-Recvd-Size: 2107 Received: from XPS-9350.home (unknown [47.151.153.53]) (Authenticated sender: joe@perches.com) by omf08.hostedemail.com (Postfix) with ESMTPA; Tue, 2 Apr 2019 09:00:07 +0000 (UTC) Message-ID: Subject: Re: [PATCH 4.4 034/131] lib/int_sqrt: optimize small argument From: Joe Perches To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, "Peter Zijlstra (Intel)" , Anshul Garg , Linus Torvalds , Davidlohr Bueso , Thomas Gleixner , Ingo Molnar , Will Deacon , David Miller , Matthew Wilcox , Kees Cook , Michael Davidson , Andrew Morton , Arnd Bergmann Date: Tue, 02 Apr 2019 02:00:06 -0700 In-Reply-To: <20190402065958.GA21380@kroah.com> References: <20190401170051.645954551@linuxfoundation.org> <20190401170055.035782875@linuxfoundation.org> <20190402065958.GA21380@kroah.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.30.1-1build1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2019-04-02 at 08:59 +0200, Greg Kroah-Hartman wrote: > On Mon, Apr 01, 2019 at 10:42:52AM -0700, Joe Perches wrote: > > On Mon, 2019-04-01 at 19:01 +0200, Greg Kroah-Hartman wrote: > > > 4.4-stable review patch. If anyone has any objections, please let me know. > > > > If this is to be ported just for an optimization > > (which I think is dubious as it's not a bug fix), > > Yes, it was requested to be backported because of that. > > > why not port the __fls optimization too? > > > > __fls has a bigger effect on performance. > > What commit are you referring to? f8ae107eef209bff29a5816bc1aad40d5cd69a80 > thanks, > > greg k-h