From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758646AbdDSAmB (ORCPT ); Tue, 18 Apr 2017 20:42:01 -0400 Received: from mga06.intel.com ([134.134.136.31]:39406 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758581AbdDSAmA (ORCPT ); Tue, 18 Apr 2017 20:42:00 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,219,1488873600"; d="scan'208";a="91472456" Subject: Re: [PATCH v4 4/5] perf report: Show branch type statistics for stdio mode To: Jiri Olsa Cc: acme@kernel.org, jolsa@kernel.org, peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, Linux-kernel@vger.kernel.org, ak@linux.intel.com, kan.liang@intel.com, yao.jin@intel.com, linuxppc-dev@lists.ozlabs.org References: <1491949266-6835-1-git-send-email-yao.jin@linux.intel.com> <1491949266-6835-5-git-send-email-yao.jin@linux.intel.com> <20170418185337.GD15584@krava> From: "Jin, Yao" Message-ID: Date: Wed, 19 Apr 2017 08:41:56 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.0 MIME-Version: 1.0 In-Reply-To: <20170418185337.GD15584@krava> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/19/2017 2:53 AM, Jiri Olsa wrote: > On Wed, Apr 12, 2017 at 06:21:05AM +0800, Jin Yao wrote: > > SNIP > >> +static int hist_iter__branch_callback(struct hist_entry_iter *iter, >> + struct addr_location *al __maybe_unused, >> + bool single __maybe_unused, >> + void *arg) >> +{ >> + struct hist_entry *he = iter->he; >> + struct report *rep = arg; >> + struct branch_info *bi; >> + >> + if (sort__mode == SORT_MODE__BRANCH) { > is this check necessary? the hist_iter__branch_callback > was set based on this check > > jirka Let me double check. Thanks Jin Yao