From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Thu, 8 Mar 2018 22:31:46 +0100 Subject: [U-Boot] [PATCH] imximage: Check the IVT offset in the correct location In-Reply-To: References: <1520541633-29312-1-git-send-email-festevam@gmail.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 08/03/2018 21:53, Breno Matheus Lima wrote: > Hi Fabio, > > 2018-03-08 17:40 GMT-03:00 Fabio Estevam : >> From: Fabio Estevam >> >> Sometimes imximage throws the following error: >> >> CFGS board/freescale/vf610twr/imximage.cfg.cfgtmp >> CFGS board/freescale/vf610twr/imximage.cfg.cfgtmp >> MKIMAGE u-boot-dtb.imx >> Error: No BOOT_FROM tag in board/freescale/vf610twr/imximage.cfg.cfgtmp >> arch/arm/mach-imx/Makefile:100: recipe for target 'u-boot-dtb.imx' failed >> >> This problem happens because imximage_ivt_offset is being checked >> at un unsafe point, and in some cases it can be checked prior to >> its assignment. >> >> Fix this issue by only checking imximage_ivt_offset after its >> assignment has really occurred. >> >> Introduce a check_ivt_offset() function to help on this task. >> >> Reported-by: Breno Lima >> Reported-by: Thomas Petazzoni >> Signed-off-by: Fabio Estevam > > Tested-by: Breno Lima Thanks both - I apply it. Best regards, Stefano -- ===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================