From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D4C0C433E6 for ; Mon, 8 Mar 2021 07:02:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E3911651EF for ; Mon, 8 Mar 2021 07:02:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229711AbhCHHCM (ORCPT ); Mon, 8 Mar 2021 02:02:12 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:43898 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235102AbhCHHCK (ORCPT ); Mon, 8 Mar 2021 02:02:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1615186930; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yhCvusN/okOy5hGR/lyFJR9D8I6idT/Y3re+gRmxEXY=; b=CYsh9B6/sgiq1qCkaIrLjn/mkkwwhNxh++BsbaOR5p3LnBeS+ZQiuvGdvFoBQzKOEElOuo WnzZDbaDZI2mxQ1j4a9dqSyd67RmQjffjPOpPWqTQ5NhtIJRwu5ioraJtQOg6Hclvs4/b5 PwoP2Gx1qCyIa8U0tmehQfFMqlHT9Sc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-35-IfK6N3WMNwmmcHF2qrDwuw-1; Mon, 08 Mar 2021 02:02:06 -0500 X-MC-Unique: IfK6N3WMNwmmcHF2qrDwuw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D447D881280; Mon, 8 Mar 2021 07:02:03 +0000 (UTC) Received: from wangxiaodeMacBook-Air.local (ovpn-13-193.pek2.redhat.com [10.72.13.193]) by smtp.corp.redhat.com (Postfix) with ESMTP id 46D4410013D7; Mon, 8 Mar 2021 07:01:48 +0000 (UTC) Subject: Re: [RFC v4 10/11] vduse: Introduce a workqueue for irq injection To: Yongji Xie Cc: "Michael S. Tsirkin" , Stefan Hajnoczi , Stefano Garzarella , Parav Pandit , Bob Liu , Christoph Hellwig , Randy Dunlap , Matthew Wilcox , viro@zeniv.linux.org.uk, Jens Axboe , bcrl@kvack.org, Jonathan Corbet , virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, kvm@vger.kernel.org, linux-aio@kvack.org, linux-fsdevel@vger.kernel.org References: <20210223115048.435-1-xieyongji@bytedance.com> <20210223115048.435-11-xieyongji@bytedance.com> <2d3418d9-856c-37ee-7614-af5b721becd7@redhat.com> <44c21bf4-874d-24c9-334b-053c54e8422e@redhat.com> From: Jason Wang Message-ID: Date: Mon, 8 Mar 2021 15:01:46 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.16; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-GB X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 2021/3/8 12:50 下午, Yongji Xie wrote: > On Mon, Mar 8, 2021 at 11:04 AM Jason Wang wrote: >> >> On 2021/3/5 4:12 下午, Yongji Xie wrote: >>> On Fri, Mar 5, 2021 at 3:37 PM Jason Wang wrote: >>>> On 2021/3/5 3:27 下午, Yongji Xie wrote: >>>>> On Fri, Mar 5, 2021 at 3:01 PM Jason Wang wrote: >>>>>> On 2021/3/5 2:36 下午, Yongji Xie wrote: >>>>>>> On Fri, Mar 5, 2021 at 11:42 AM Jason Wang wrote: >>>>>>>> On 2021/3/5 11:30 上午, Yongji Xie wrote: >>>>>>>>> On Fri, Mar 5, 2021 at 11:05 AM Jason Wang wrote: >>>>>>>>>> On 2021/3/4 4:58 下午, Yongji Xie wrote: >>>>>>>>>>> On Thu, Mar 4, 2021 at 2:59 PM Jason Wang wrote: >>>>>>>>>>>> On 2021/2/23 7:50 下午, Xie Yongji wrote: >>>>>>>>>>>>> This patch introduces a workqueue to support injecting >>>>>>>>>>>>> virtqueue's interrupt asynchronously. This is mainly >>>>>>>>>>>>> for performance considerations which makes sure the push() >>>>>>>>>>>>> and pop() for used vring can be asynchronous. >>>>>>>>>>>> Do you have pref numbers for this patch? >>>>>>>>>>>> >>>>>>>>>>> No, I can do some tests for it if needed. >>>>>>>>>>> >>>>>>>>>>> Another problem is the VIRTIO_RING_F_EVENT_IDX feature will be useless >>>>>>>>>>> if we call irq callback in ioctl context. Something like: >>>>>>>>>>> >>>>>>>>>>> virtqueue_push(); >>>>>>>>>>> virtio_notify(); >>>>>>>>>>> ioctl() >>>>>>>>>>> ------------------------------------------------- >>>>>>>>>>> irq_cb() >>>>>>>>>>> virtqueue_get_buf() >>>>>>>>>>> >>>>>>>>>>> The used vring is always empty each time we call virtqueue_push() in >>>>>>>>>>> userspace. Not sure if it is what we expected. >>>>>>>>>> I'm not sure I get the issue. >>>>>>>>>> >>>>>>>>>> THe used ring should be filled by virtqueue_push() which is done by >>>>>>>>>> userspace before? >>>>>>>>>> >>>>>>>>> After userspace call virtqueue_push(), it always call virtio_notify() >>>>>>>>> immediately. In traditional VM (vhost-vdpa) cases, virtio_notify() >>>>>>>>> will inject an irq to VM and return, then vcpu thread will call >>>>>>>>> interrupt handler. But in container (virtio-vdpa) cases, >>>>>>>>> virtio_notify() will call interrupt handler directly. So it looks like >>>>>>>>> we have to optimize the virtio-vdpa cases. But one problem is we don't >>>>>>>>> know whether we are in the VM user case or container user case. >>>>>>>> Yes, but I still don't get why used ring is empty after the ioctl()? >>>>>>>> Used ring does not use bounce page so it should be visible to the kernel >>>>>>>> driver. What did I miss :) ? >>>>>>>> >>>>>>> Sorry, I'm not saying the kernel can't see the correct used vring. I >>>>>>> mean the kernel will consume the used vring in the ioctl context >>>>>>> directly in the virtio-vdpa case. In userspace's view, that means >>>>>>> virtqueue_push() is used vring's producer and virtio_notify() is used >>>>>>> vring's consumer. They will be called one by one in one thread rather >>>>>>> than different threads, which looks odd and has a bad effect on >>>>>>> performance. >>>>>> Yes, that's why we need a workqueue (WQ_UNBOUND you used). Or do you >>>>>> want to squash this patch into patch 8? >>>>>> >>>>>> So I think we can see obvious difference when virtio-vdpa is used. >>>>>> >>>>> But it looks like we don't need this workqueue in vhost-vdpa cases. >>>>> Any suggestions? >>>> I haven't had a deep thought. But I feel we can solve this by using the >>>> irq bypass manager (or something similar). Then we don't need it to be >>>> relayed via workqueue and vdpa. But I'm not sure how hard it will be. >>>> >>> Or let vdpa bus drivers give us some information? >> >> This kind of 'type' is proposed in the early RFC of vDPA series. One >> issue is that at device level, we should not differ virtio from vhost, >> so if we introduce that, it might encourge people to design a device >> that is dedicated to vhost or virtio which might not be good. >> >> But we can re-visit this when necessary. >> > OK, I see. How about adding some information in ops.set_vq_cb()? I'm not sure I get this, maybe you can explain a little bit more? Thanks > > Thanks, > Yongji > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,URIBL_RED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB269C433DB for ; Mon, 8 Mar 2021 07:02:16 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4224F60201 for ; Mon, 8 Mar 2021 07:02:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4224F60201 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=virtualization-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id CB05B430EC; Mon, 8 Mar 2021 07:02:15 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kmvj1wxXoecC; Mon, 8 Mar 2021 07:02:14 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp2.osuosl.org (Postfix) with ESMTP id 580C542FB5; Mon, 8 Mar 2021 07:02:14 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 2DF82C000B; Mon, 8 Mar 2021 07:02:14 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137]) by lists.linuxfoundation.org (Postfix) with ESMTP id 2C33FC0001 for ; Mon, 8 Mar 2021 07:02:13 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 018594EB9F for ; Mon, 8 Mar 2021 07:02:13 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp4.osuosl.org (amavisd-new); dkim=pass (1024-bit key) header.d=redhat.com Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xMqz9foCjoTF for ; Mon, 8 Mar 2021 07:02:11 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by smtp4.osuosl.org (Postfix) with ESMTPS id 958DD4EBA3 for ; Mon, 8 Mar 2021 07:02:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1615186930; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yhCvusN/okOy5hGR/lyFJR9D8I6idT/Y3re+gRmxEXY=; b=CYsh9B6/sgiq1qCkaIrLjn/mkkwwhNxh++BsbaOR5p3LnBeS+ZQiuvGdvFoBQzKOEElOuo WnzZDbaDZI2mxQ1j4a9dqSyd67RmQjffjPOpPWqTQ5NhtIJRwu5ioraJtQOg6Hclvs4/b5 PwoP2Gx1qCyIa8U0tmehQfFMqlHT9Sc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-35-IfK6N3WMNwmmcHF2qrDwuw-1; Mon, 08 Mar 2021 02:02:06 -0500 X-MC-Unique: IfK6N3WMNwmmcHF2qrDwuw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D447D881280; Mon, 8 Mar 2021 07:02:03 +0000 (UTC) Received: from wangxiaodeMacBook-Air.local (ovpn-13-193.pek2.redhat.com [10.72.13.193]) by smtp.corp.redhat.com (Postfix) with ESMTP id 46D4410013D7; Mon, 8 Mar 2021 07:01:48 +0000 (UTC) Subject: Re: [RFC v4 10/11] vduse: Introduce a workqueue for irq injection To: Yongji Xie References: <20210223115048.435-1-xieyongji@bytedance.com> <20210223115048.435-11-xieyongji@bytedance.com> <2d3418d9-856c-37ee-7614-af5b721becd7@redhat.com> <44c21bf4-874d-24c9-334b-053c54e8422e@redhat.com> From: Jason Wang Message-ID: Date: Mon, 8 Mar 2021 15:01:46 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.16; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-GB X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Cc: Jens Axboe , Jonathan Corbet , kvm@vger.kernel.org, "Michael S. Tsirkin" , linux-aio@kvack.org, netdev@vger.kernel.org, Randy Dunlap , Matthew Wilcox , virtualization@lists.linux-foundation.org, Christoph Hellwig , Bob Liu , bcrl@kvack.org, viro@zeniv.linux.org.uk, Stefan Hajnoczi , linux-fsdevel@vger.kernel.org X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" Ck9uIDIwMjEvMy84IDEyOjUwIOS4i+WNiCwgWW9uZ2ppIFhpZSB3cm90ZToKPiBPbiBNb24sIE1h ciA4LCAyMDIxIGF0IDExOjA0IEFNIEphc29uIFdhbmcgPGphc293YW5nQHJlZGhhdC5jb20+IHdy b3RlOgo+Pgo+PiBPbiAyMDIxLzMvNSA0OjEyIOS4i+WNiCwgWW9uZ2ppIFhpZSB3cm90ZToKPj4+ IE9uIEZyaSwgTWFyIDUsIDIwMjEgYXQgMzozNyBQTSBKYXNvbiBXYW5nIDxqYXNvd2FuZ0ByZWRo YXQuY29tPiB3cm90ZToKPj4+PiBPbiAyMDIxLzMvNSAzOjI3IOS4i+WNiCwgWW9uZ2ppIFhpZSB3 cm90ZToKPj4+Pj4gT24gRnJpLCBNYXIgNSwgMjAyMSBhdCAzOjAxIFBNIEphc29uIFdhbmcgPGph c293YW5nQHJlZGhhdC5jb20+IHdyb3RlOgo+Pj4+Pj4gT24gMjAyMS8zLzUgMjozNiDkuIvljYgs IFlvbmdqaSBYaWUgd3JvdGU6Cj4+Pj4+Pj4gT24gRnJpLCBNYXIgNSwgMjAyMSBhdCAxMTo0MiBB TSBKYXNvbiBXYW5nIDxqYXNvd2FuZ0ByZWRoYXQuY29tPiB3cm90ZToKPj4+Pj4+Pj4gT24gMjAy MS8zLzUgMTE6MzAg5LiK5Y2ILCBZb25namkgWGllIHdyb3RlOgo+Pj4+Pj4+Pj4gT24gRnJpLCBN YXIgNSwgMjAyMSBhdCAxMTowNSBBTSBKYXNvbiBXYW5nIDxqYXNvd2FuZ0ByZWRoYXQuY29tPiB3 cm90ZToKPj4+Pj4+Pj4+PiBPbiAyMDIxLzMvNCA0OjU4IOS4i+WNiCwgWW9uZ2ppIFhpZSB3cm90 ZToKPj4+Pj4+Pj4+Pj4gT24gVGh1LCBNYXIgNCwgMjAyMSBhdCAyOjU5IFBNIEphc29uIFdhbmcg PGphc293YW5nQHJlZGhhdC5jb20+IHdyb3RlOgo+Pj4+Pj4+Pj4+Pj4gT24gMjAyMS8yLzIzIDc6 NTAg5LiL5Y2ILCBYaWUgWW9uZ2ppIHdyb3RlOgo+Pj4+Pj4+Pj4+Pj4+IFRoaXMgcGF0Y2ggaW50 cm9kdWNlcyBhIHdvcmtxdWV1ZSB0byBzdXBwb3J0IGluamVjdGluZwo+Pj4+Pj4+Pj4+Pj4+IHZp cnRxdWV1ZSdzIGludGVycnVwdCBhc3luY2hyb25vdXNseS4gVGhpcyBpcyBtYWlubHkKPj4+Pj4+ Pj4+Pj4+PiBmb3IgcGVyZm9ybWFuY2UgY29uc2lkZXJhdGlvbnMgd2hpY2ggbWFrZXMgc3VyZSB0 aGUgcHVzaCgpCj4+Pj4+Pj4+Pj4+Pj4gYW5kIHBvcCgpIGZvciB1c2VkIHZyaW5nIGNhbiBiZSBh c3luY2hyb25vdXMuCj4+Pj4+Pj4+Pj4+PiBEbyB5b3UgaGF2ZSBwcmVmIG51bWJlcnMgZm9yIHRo aXMgcGF0Y2g/Cj4+Pj4+Pj4+Pj4+Pgo+Pj4+Pj4+Pj4+PiBObywgSSBjYW4gZG8gc29tZSB0ZXN0 cyBmb3IgaXQgaWYgbmVlZGVkLgo+Pj4+Pj4+Pj4+Pgo+Pj4+Pj4+Pj4+PiBBbm90aGVyIHByb2Js ZW0gaXMgdGhlIFZJUlRJT19SSU5HX0ZfRVZFTlRfSURYIGZlYXR1cmUgd2lsbCBiZSB1c2VsZXNz Cj4+Pj4+Pj4+Pj4+IGlmIHdlIGNhbGwgaXJxIGNhbGxiYWNrIGluIGlvY3RsIGNvbnRleHQuIFNv bWV0aGluZyBsaWtlOgo+Pj4+Pj4+Pj4+Pgo+Pj4+Pj4+Pj4+PiB2aXJ0cXVldWVfcHVzaCgpOwo+ Pj4+Pj4+Pj4+PiB2aXJ0aW9fbm90aWZ5KCk7Cj4+Pj4+Pj4+Pj4+ICAgICAgICAgICBpb2N0bCgp Cj4+Pj4+Pj4+Pj4+IC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0KPj4+Pj4+Pj4+Pj4gICAgICAgICAgICAgICBpcnFfY2IoKQo+Pj4+Pj4+Pj4+PiAgICAg ICAgICAgICAgICAgICB2aXJ0cXVldWVfZ2V0X2J1ZigpCj4+Pj4+Pj4+Pj4+Cj4+Pj4+Pj4+Pj4+ IFRoZSB1c2VkIHZyaW5nIGlzIGFsd2F5cyBlbXB0eSBlYWNoIHRpbWUgd2UgY2FsbCB2aXJ0cXVl dWVfcHVzaCgpIGluCj4+Pj4+Pj4+Pj4+IHVzZXJzcGFjZS4gTm90IHN1cmUgaWYgaXQgaXMgd2hh dCB3ZSBleHBlY3RlZC4KPj4+Pj4+Pj4+PiBJJ20gbm90IHN1cmUgSSBnZXQgdGhlIGlzc3VlLgo+ Pj4+Pj4+Pj4+Cj4+Pj4+Pj4+Pj4gVEhlIHVzZWQgcmluZyBzaG91bGQgYmUgZmlsbGVkIGJ5IHZp cnRxdWV1ZV9wdXNoKCkgd2hpY2ggaXMgZG9uZSBieQo+Pj4+Pj4+Pj4+IHVzZXJzcGFjZSBiZWZv cmU/Cj4+Pj4+Pj4+Pj4KPj4+Pj4+Pj4+IEFmdGVyIHVzZXJzcGFjZSBjYWxsIHZpcnRxdWV1ZV9w dXNoKCksIGl0IGFsd2F5cyBjYWxsIHZpcnRpb19ub3RpZnkoKQo+Pj4+Pj4+Pj4gaW1tZWRpYXRl bHkuIEluIHRyYWRpdGlvbmFsIFZNICh2aG9zdC12ZHBhKSBjYXNlcywgdmlydGlvX25vdGlmeSgp Cj4+Pj4+Pj4+PiB3aWxsIGluamVjdCBhbiBpcnEgdG8gVk0gYW5kIHJldHVybiwgdGhlbiB2Y3B1 IHRocmVhZCB3aWxsIGNhbGwKPj4+Pj4+Pj4+IGludGVycnVwdCBoYW5kbGVyLiBCdXQgaW4gY29u dGFpbmVyICh2aXJ0aW8tdmRwYSkgY2FzZXMsCj4+Pj4+Pj4+PiB2aXJ0aW9fbm90aWZ5KCkgd2ls bCBjYWxsIGludGVycnVwdCBoYW5kbGVyIGRpcmVjdGx5LiBTbyBpdCBsb29rcyBsaWtlCj4+Pj4+ Pj4+PiB3ZSBoYXZlIHRvIG9wdGltaXplIHRoZSB2aXJ0aW8tdmRwYSBjYXNlcy4gQnV0IG9uZSBw cm9ibGVtIGlzIHdlIGRvbid0Cj4+Pj4+Pj4+PiBrbm93IHdoZXRoZXIgd2UgYXJlIGluIHRoZSBW TSB1c2VyIGNhc2Ugb3IgY29udGFpbmVyIHVzZXIgY2FzZS4KPj4+Pj4+Pj4gWWVzLCBidXQgSSBz dGlsbCBkb24ndCBnZXQgd2h5IHVzZWQgcmluZyBpcyBlbXB0eSBhZnRlciB0aGUgaW9jdGwoKT8K Pj4+Pj4+Pj4gVXNlZCByaW5nIGRvZXMgbm90IHVzZSBib3VuY2UgcGFnZSBzbyBpdCBzaG91bGQg YmUgdmlzaWJsZSB0byB0aGUga2VybmVsCj4+Pj4+Pj4+IGRyaXZlci4gV2hhdCBkaWQgSSBtaXNz IDopID8KPj4+Pj4+Pj4KPj4+Pj4+PiBTb3JyeSwgSSdtIG5vdCBzYXlpbmcgdGhlIGtlcm5lbCBj YW4ndCBzZWUgdGhlIGNvcnJlY3QgdXNlZCB2cmluZy4gSQo+Pj4+Pj4+IG1lYW4gdGhlIGtlcm5l bCB3aWxsIGNvbnN1bWUgdGhlIHVzZWQgdnJpbmcgaW4gdGhlIGlvY3RsIGNvbnRleHQKPj4+Pj4+ PiBkaXJlY3RseSBpbiB0aGUgdmlydGlvLXZkcGEgY2FzZS4gSW4gdXNlcnNwYWNlJ3Mgdmlldywg dGhhdCBtZWFucwo+Pj4+Pj4+IHZpcnRxdWV1ZV9wdXNoKCkgaXMgdXNlZCB2cmluZydzIHByb2R1 Y2VyIGFuZCB2aXJ0aW9fbm90aWZ5KCkgaXMgdXNlZAo+Pj4+Pj4+IHZyaW5nJ3MgY29uc3VtZXIu IFRoZXkgd2lsbCBiZSBjYWxsZWQgb25lIGJ5IG9uZSBpbiBvbmUgdGhyZWFkIHJhdGhlcgo+Pj4+ Pj4+IHRoYW4gZGlmZmVyZW50IHRocmVhZHMsIHdoaWNoIGxvb2tzIG9kZCBhbmQgaGFzIGEgYmFk IGVmZmVjdCBvbgo+Pj4+Pj4+IHBlcmZvcm1hbmNlLgo+Pj4+Pj4gWWVzLCB0aGF0J3Mgd2h5IHdl IG5lZWQgYSB3b3JrcXVldWUgKFdRX1VOQk9VTkQgeW91IHVzZWQpLiBPciBkbyB5b3UKPj4+Pj4+ IHdhbnQgdG8gc3F1YXNoIHRoaXMgcGF0Y2ggaW50byBwYXRjaCA4Pwo+Pj4+Pj4KPj4+Pj4+IFNv IEkgdGhpbmsgd2UgY2FuIHNlZSBvYnZpb3VzIGRpZmZlcmVuY2Ugd2hlbiB2aXJ0aW8tdmRwYSBp cyB1c2VkLgo+Pj4+Pj4KPj4+Pj4gQnV0IGl0IGxvb2tzIGxpa2Ugd2UgZG9uJ3QgbmVlZCB0aGlz IHdvcmtxdWV1ZSBpbiB2aG9zdC12ZHBhIGNhc2VzLgo+Pj4+PiBBbnkgc3VnZ2VzdGlvbnM/Cj4+ Pj4gSSBoYXZlbid0IGhhZCBhIGRlZXAgdGhvdWdodC4gQnV0IEkgZmVlbCB3ZSBjYW4gc29sdmUg dGhpcyBieSB1c2luZyB0aGUKPj4+PiBpcnEgYnlwYXNzIG1hbmFnZXIgKG9yIHNvbWV0aGluZyBz aW1pbGFyKS4gVGhlbiB3ZSBkb24ndCBuZWVkIGl0IHRvIGJlCj4+Pj4gcmVsYXllZCB2aWEgd29y a3F1ZXVlIGFuZCB2ZHBhLiBCdXQgSSdtIG5vdCBzdXJlIGhvdyBoYXJkIGl0IHdpbGwgYmUuCj4+ Pj4KPj4+ICAgIE9yIGxldCB2ZHBhIGJ1cyBkcml2ZXJzIGdpdmUgdXMgc29tZSBpbmZvcm1hdGlv bj8KPj4KPj4gVGhpcyBraW5kIG9mICd0eXBlJyBpcyBwcm9wb3NlZCBpbiB0aGUgZWFybHkgUkZD IG9mIHZEUEEgc2VyaWVzLiBPbmUKPj4gaXNzdWUgaXMgdGhhdCBhdCBkZXZpY2UgbGV2ZWwsIHdl IHNob3VsZCBub3QgZGlmZmVyIHZpcnRpbyBmcm9tIHZob3N0LAo+PiBzbyBpZiB3ZSBpbnRyb2R1 Y2UgdGhhdCwgaXQgbWlnaHQgZW5jb3VyZ2UgcGVvcGxlIHRvIGRlc2lnbiBhIGRldmljZQo+PiB0 aGF0IGlzIGRlZGljYXRlZCB0byB2aG9zdCBvciB2aXJ0aW8gd2hpY2ggbWlnaHQgbm90IGJlIGdv b2QuCj4+Cj4+IEJ1dCB3ZSBjYW4gcmUtdmlzaXQgdGhpcyB3aGVuIG5lY2Vzc2FyeS4KPj4KPiBP SywgSSBzZWUuIEhvdyBhYm91dCBhZGRpbmcgc29tZSBpbmZvcm1hdGlvbiBpbiBvcHMuc2V0X3Zx X2NiKCk/CgoKSSdtIG5vdCBzdXJlIEkgZ2V0IHRoaXMsIG1heWJlIHlvdSBjYW4gZXhwbGFpbiBh IGxpdHRsZSBiaXQgbW9yZT8KClRoYW5rcwoKCj4KPiBUaGFua3MsCj4gWW9uZ2ppCj4KCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fClZpcnR1YWxpemF0aW9u IG1haWxpbmcgbGlzdApWaXJ0dWFsaXphdGlvbkBsaXN0cy5saW51eC1mb3VuZGF0aW9uLm9yZwpo dHRwczovL2xpc3RzLmxpbnV4Zm91bmRhdGlvbi5vcmcvbWFpbG1hbi9saXN0aW5mby92aXJ0dWFs aXphdGlvbg==