From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from shadbolt.e.decadent.org.uk ([88.96.1.126]:59382 "EHLO shadbolt.e.decadent.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728094AbeKJJ1Y (ORCPT ); Sat, 10 Nov 2018 04:27:24 -0500 Message-ID: Subject: Re: [PATCH stable 3.9 to 3.16] staging: comedi: quatech_daqp_cs: fix no-op loop daqp_ao_insn_write() From: Ben Hutchings To: Ian Abbott , stable@vger.kernel.org Cc: Greg Kroah-Hartman , Dan Carpenter , H Hartley Sweeten Date: Fri, 09 Nov 2018 23:44:31 +0000 In-Reply-To: <20180710170226.23969-1-abbotti@mev.co.uk> References: <20180710170226.23969-1-abbotti@mev.co.uk> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-LqI5st9jDxnAfzW5qpWd" Mime-Version: 1.0 Sender: stable-owner@vger.kernel.org List-ID: --=-LqI5st9jDxnAfzW5qpWd Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 2018-07-10 at 18:02 +0100, Ian Abbott wrote: > From: Dan Carpenter >=20 > [ Upstream commit 1376b0a2160319125c3a2822e8c09bd283cd8141 ] >=20 > There is a '>' vs '<' typo so this loop is a no-op. Thanks, but this driver seems to have lots of other bugs in 3.16, like it only ever accesses data[0] in this loop. I don't think there's much point in applying just this one. But if you think it's worth fixing then I can apply all the necessary fixes. Ben. > Fixes: d35dcc89fc93 ("staging: comedi: quatech_daqp_cs: fix daqp_ao_insn_= write()") > Signed-off-by: Dan Carpenter > Reviewed-by: Ian Abbott > Signed-off-by: Greg Kroah-Hartman > --- > drivers/staging/comedi/drivers/quatech_daqp_cs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/staging/comedi/drivers/quatech_daqp_cs.c b/drivers/s= taging/comedi/drivers/quatech_daqp_cs.c > index b3bbec0a0d23..f89a863ea04c 100644 > --- a/drivers/staging/comedi/drivers/quatech_daqp_cs.c > +++ b/drivers/staging/comedi/drivers/quatech_daqp_cs.c > @@ -649,7 +649,7 @@ static int daqp_ao_insn_write(struct comedi_device *d= ev, > /* Make sure D/A update mode is direct update */ > outb(0, dev->iobase + DAQP_AUX); > =20 > - for (i =3D 0; i > insn->n; i++) { > + for (i =3D 0; i < insn->n; i++) { > val =3D data[0]; > val &=3D 0x0fff; > val ^=3D 0x0800; /* Flip the sign */ --=20 Ben Hutchings Knowledge is power. France is bacon. --=-LqI5st9jDxnAfzW5qpWd Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEErCspvTSmr92z9o8157/I7JWGEQkFAlvmG98ACgkQ57/I7JWG EQmxpg/+MHkx7PYZzTYh0M+gJoas7EIuRXQy8jWyfqRvC2e/f3184gdxslVNAl97 dGefkfeVf5jTkhxbAzDrQWUUgAwYE8UGzF4UGQrpwZrSiUYGFaMp1fZk6dVVlXF+ bCBI25bbqrW7IxxCVGiEep9aaAWqxrj3dM+VtjX7Xn6Cx/u/poOPBXS4D0C9V4YV 7z3CAbGwoOjZiJD/cBeEHB2kQcYqsrAapPIh19qn+9R6kZ1+7R3cfJrSzEJa7alP K4rLFZPzMg8jFCyT0YSHkolUJMR3mmWQOVHQU28/qG3KVBPYaV/ho/KqrtMLosNt ygLLL871i4N9RwtTeX4UxUQbbPWS9fW5uYtG56dBdSFlxxKsmVamsI2KLhwDSYsZ l3AwmvO9VbJ5ig4PfFJ3h0IUoqUfBmvMyjTriODlMEl1shTnku9lvp9+DlfIW7KJ UNDfZN9tNebSH04WUqoX5+man24BoXbAxn2mvAXvQhO1pHd0pIVPTkHsy276z36I D7q3LbFpUKx8bsds1HxJfEyKD7oVYO2MCRPeo5yS+MfDjQpuww/PWQVqcw8QuvXc Qfe983IDEaoj7VUcW+/K88psG8UqipjRB4N44YcpVREQp85xTbkzM+GbtSgz37H6 /DwTCvyCgrrhoL7w0y9NsvFye4VbYaUg5giruRdQFtnhPHcEguk= =nML5 -----END PGP SIGNATURE----- --=-LqI5st9jDxnAfzW5qpWd--