From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754082AbeEaIdx (ORCPT ); Thu, 31 May 2018 04:33:53 -0400 Received: from relay1.mentorg.com ([192.94.38.131]:52498 "EHLO relay1.mentorg.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754034AbeEaIdu (ORCPT ); Thu, 31 May 2018 04:33:50 -0400 Subject: Re: [PATCH v4 5/5] ARM: dts: imx6qdl: add missing compatible and clock properties for EPIT To: =?UTF-8?B?Q2zDqW1lbnQgUMOpcm9u?= , Colin Didier , , , References: <20180530120327.27681-1-peron.clem@gmail.com> <20180530120327.27681-6-peron.clem@gmail.com> CC: Daniel Lezcano , Thomas Gleixner , Fabio Estevam , Sascha Hauer , Rob Herring , NXP Linux Team , Pengutronix Kernel Team , =?UTF-8?Q?Cl=c3=a9ment_Peron?= From: Vladimir Zapolskiy Message-ID: Date: Thu, 31 May 2018 11:33:43 +0300 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:45.0) Gecko/20100101 Icedove/45.2.0 MIME-Version: 1.0 In-Reply-To: <20180530120327.27681-6-peron.clem@gmail.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [137.202.0.87] X-ClientProxiedBy: svr-ies-mbx-02.mgc.mentorg.com (139.181.222.2) To SVR-IES-MBX-04.mgc.mentorg.com (139.181.222.4) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/30/2018 03:03 PM, Clément Péron wrote: > From: Colin Didier > > Add missing compatible and clock properties for EPIT node. > > Signed-off-by: Colin Didier > Signed-off-by: Clément Peron > Reviewed-by: Fabio Estevam > --- > arch/arm/boot/dts/imx6qdl.dtsi | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi > index c003e62bf290..0feec516847a 100644 > --- a/arch/arm/boot/dts/imx6qdl.dtsi > +++ b/arch/arm/boot/dts/imx6qdl.dtsi > @@ -844,13 +844,23 @@ > }; > > epit1: epit@20d0000 { /* EPIT1 */ epit1: timer@20d0000 { ... And /* EPIT1 */ comment can be removed, it is quite clear from the same line context. Formally it is a subject to another patch, but I think this can be accepted as a part of this one. > + compatible = "fsl,imx6q-epit", "fsl,imx31-epit"; > reg = <0x020d0000 0x4000>; > interrupts = <0 56 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&clks IMX6QDL_CLK_IPG_PER>, > + <&clks IMX6QDL_CLK_EPIT1>; > + clock-names = "ipg", "per"; > + status = "disabled"; > }; > > epit2: epit@20d4000 { /* EPIT2 */ Same as above. > + compatible = "fsl,imx6q-epit", "fsl,imx31-epit"; > reg = <0x020d4000 0x4000>; > interrupts = <0 57 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&clks IMX6QDL_CLK_IPG_PER>, > + <&clks IMX6QDL_CLK_EPIT2>; > + clock-names = "ipg", "per"; > + status = "disabled"; > }; > > src: src@20d8000 { > -- With best wishes, Vladimir From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vladimir Zapolskiy Subject: Re: [PATCH v4 5/5] ARM: dts: imx6qdl: add missing compatible and clock properties for EPIT Date: Thu, 31 May 2018 11:33:43 +0300 Message-ID: References: <20180530120327.27681-1-peron.clem@gmail.com> <20180530120327.27681-6-peron.clem@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180530120327.27681-6-peron.clem@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: =?UTF-8?B?Q2zDqW1lbnQgUMOpcm9u?= , Colin Didier , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Rob Herring , Sascha Hauer , Daniel Lezcano , =?UTF-8?Q?Cl=c3=a9ment_Peron?= , NXP Linux Team , Pengutronix Kernel Team , Fabio Estevam , Thomas Gleixner List-Id: devicetree@vger.kernel.org T24gMDUvMzAvMjAxOCAwMzowMyBQTSwgQ2zDqW1lbnQgUMOpcm9uIHdyb3RlOgo+IEZyb206IENv bGluIERpZGllciA8Y29saW4uZGlkaWVyQGRldmlhbGV0LmNvbT4KPiAKPiBBZGQgbWlzc2luZyBj b21wYXRpYmxlIGFuZCBjbG9jayBwcm9wZXJ0aWVzIGZvciBFUElUIG5vZGUuCj4gCj4gU2lnbmVk LW9mZi1ieTogQ29saW4gRGlkaWVyIDxjb2xpbi5kaWRpZXJAZGV2aWFsZXQuY29tPgo+IFNpZ25l ZC1vZmYtYnk6IENsw6ltZW50IFBlcm9uIDxjbGVtZW50LnBlcm9uQGRldmlhbGV0LmNvbT4KPiBS ZXZpZXdlZC1ieTogRmFiaW8gRXN0ZXZhbSA8ZmFiaW8uZXN0ZXZhbUBueHAuY29tPgo+IC0tLQo+ ICBhcmNoL2FybS9ib290L2R0cy9pbXg2cWRsLmR0c2kgfCAxMCArKysrKysrKysrCj4gIDEgZmls ZSBjaGFuZ2VkLCAxMCBpbnNlcnRpb25zKCspCj4gCj4gZGlmZiAtLWdpdCBhL2FyY2gvYXJtL2Jv b3QvZHRzL2lteDZxZGwuZHRzaSBiL2FyY2gvYXJtL2Jvb3QvZHRzL2lteDZxZGwuZHRzaQo+IGlu ZGV4IGMwMDNlNjJiZjI5MC4uMGZlZWM1MTY4NDdhIDEwMDY0NAo+IC0tLSBhL2FyY2gvYXJtL2Jv b3QvZHRzL2lteDZxZGwuZHRzaQo+ICsrKyBiL2FyY2gvYXJtL2Jvb3QvZHRzL2lteDZxZGwuZHRz aQo+IEBAIC04NDQsMTMgKzg0NCwyMyBAQAo+ICAJCQl9Owo+ICAKPiAgCQkJZXBpdDE6IGVwaXRA MjBkMDAwMCB7IC8qIEVQSVQxICovCgplcGl0MTogdGltZXJAMjBkMDAwMCB7IC4uLgoKQW5kIC8q IEVQSVQxICovIGNvbW1lbnQgY2FuIGJlIHJlbW92ZWQsIGl0IGlzIHF1aXRlIGNsZWFyIGZyb20g dGhlIHNhbWUKbGluZSBjb250ZXh0LgoKRm9ybWFsbHkgaXQgaXMgYSBzdWJqZWN0IHRvIGFub3Ro ZXIgcGF0Y2gsIGJ1dCBJIHRoaW5rIHRoaXMgY2FuIGJlCmFjY2VwdGVkIGFzIGEgcGFydCBvZiB0 aGlzIG9uZS4KCj4gKwkJCQljb21wYXRpYmxlID0gImZzbCxpbXg2cS1lcGl0IiwgImZzbCxpbXgz MS1lcGl0IjsKPiAgCQkJCXJlZyA9IDwweDAyMGQwMDAwIDB4NDAwMD47Cj4gIAkJCQlpbnRlcnJ1 cHRzID0gPDAgNTYgSVJRX1RZUEVfTEVWRUxfSElHSD47Cj4gKwkJCQljbG9ja3MgPSA8JmNsa3Mg SU1YNlFETF9DTEtfSVBHX1BFUj4sCj4gKwkJCQkJIDwmY2xrcyBJTVg2UURMX0NMS19FUElUMT47 Cj4gKwkJCQljbG9jay1uYW1lcyA9ICJpcGciLCAicGVyIjsKPiArCQkJCXN0YXR1cyA9ICJkaXNh YmxlZCI7Cj4gIAkJCX07Cj4gIAo+ICAJCQllcGl0MjogZXBpdEAyMGQ0MDAwIHsgLyogRVBJVDIg Ki8KClNhbWUgYXMgYWJvdmUuCgo+ICsJCQkJY29tcGF0aWJsZSA9ICJmc2wsaW14NnEtZXBpdCIs ICJmc2wsaW14MzEtZXBpdCI7Cj4gIAkJCQlyZWcgPSA8MHgwMjBkNDAwMCAweDQwMDA+Owo+ICAJ CQkJaW50ZXJydXB0cyA9IDwwIDU3IElSUV9UWVBFX0xFVkVMX0hJR0g+Owo+ICsJCQkJY2xvY2tz ID0gPCZjbGtzIElNWDZRRExfQ0xLX0lQR19QRVI+LAo+ICsJCQkJCSA8JmNsa3MgSU1YNlFETF9D TEtfRVBJVDI+Owo+ICsJCQkJY2xvY2stbmFtZXMgPSAiaXBnIiwgInBlciI7Cj4gKwkJCQlzdGF0 dXMgPSAiZGlzYWJsZWQiOwo+ICAJCQl9Owo+ICAKPiAgCQkJc3JjOiBzcmNAMjBkODAwMCB7Cj4g CgotLQpXaXRoIGJlc3Qgd2lzaGVzLApWbGFkaW1pcgoKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGlu dXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQu b3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: vladimir_zapolskiy@mentor.com (Vladimir Zapolskiy) Date: Thu, 31 May 2018 11:33:43 +0300 Subject: [PATCH v4 5/5] ARM: dts: imx6qdl: add missing compatible and clock properties for EPIT In-Reply-To: <20180530120327.27681-6-peron.clem@gmail.com> References: <20180530120327.27681-1-peron.clem@gmail.com> <20180530120327.27681-6-peron.clem@gmail.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 05/30/2018 03:03 PM, Cl?ment P?ron wrote: > From: Colin Didier > > Add missing compatible and clock properties for EPIT node. > > Signed-off-by: Colin Didier > Signed-off-by: Cl?ment Peron > Reviewed-by: Fabio Estevam > --- > arch/arm/boot/dts/imx6qdl.dtsi | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi > index c003e62bf290..0feec516847a 100644 > --- a/arch/arm/boot/dts/imx6qdl.dtsi > +++ b/arch/arm/boot/dts/imx6qdl.dtsi > @@ -844,13 +844,23 @@ > }; > > epit1: epit at 20d0000 { /* EPIT1 */ epit1: timer at 20d0000 { ... And /* EPIT1 */ comment can be removed, it is quite clear from the same line context. Formally it is a subject to another patch, but I think this can be accepted as a part of this one. > + compatible = "fsl,imx6q-epit", "fsl,imx31-epit"; > reg = <0x020d0000 0x4000>; > interrupts = <0 56 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&clks IMX6QDL_CLK_IPG_PER>, > + <&clks IMX6QDL_CLK_EPIT1>; > + clock-names = "ipg", "per"; > + status = "disabled"; > }; > > epit2: epit at 20d4000 { /* EPIT2 */ Same as above. > + compatible = "fsl,imx6q-epit", "fsl,imx31-epit"; > reg = <0x020d4000 0x4000>; > interrupts = <0 57 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&clks IMX6QDL_CLK_IPG_PER>, > + <&clks IMX6QDL_CLK_EPIT2>; > + clock-names = "ipg", "per"; > + status = "disabled"; > }; > > src: src at 20d8000 { > -- With best wishes, Vladimir