From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F27D2C56201 for ; Tue, 24 Nov 2020 13:10:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9835B206D9 for ; Tue, 24 Nov 2020 13:10:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387608AbgKXNK0 (ORCPT ); Tue, 24 Nov 2020 08:10:26 -0500 Received: from mga01.intel.com ([192.55.52.88]:57460 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387582AbgKXNKZ (ORCPT ); Tue, 24 Nov 2020 08:10:25 -0500 IronPort-SDR: 14e21FFz6PKapXR54lGlXsJ9Y1ZZBzKwfQJGt8y5Wggq7KM0/A3JA9NKfvJjtE5gst6dtWkm2N TCv9C2UkZMHg== X-IronPort-AV: E=McAfee;i="6000,8403,9814"; a="190065321" X-IronPort-AV: E=Sophos;i="5.78,366,1599548400"; d="scan'208";a="190065321" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Nov 2020 05:10:25 -0800 IronPort-SDR: mJrVMzwaCSVvK+lHDeSxpNM70cSXr9AW1IGVs3JHPvbItXWdnnTDOwg0euZmoeNJzu+kADjFhY R37+4eR0PxCA== X-IronPort-AV: E=Sophos;i="5.78,366,1599548400"; d="scan'208";a="536470044" Received: from ndavidso-mobl4.ger.corp.intel.com (HELO Win10on49-0007.SSPE.ch.intel.com) ([10.255.198.190]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Nov 2020 05:10:23 -0800 Subject: Re: [Intel-gfx] [PATCH] dma-buf/dma-resv: Respect num_fences when initializing the shared fence list. To: Maarten Lankhorst , dri-devel@lists.freedesktop.org Cc: intel-gfx@lists.freedesktop.org, stable@vger.kernel.org References: <20201124115707.406917-1-maarten.lankhorst@linux.intel.com> From: =?UTF-8?Q?Thomas_Hellstr=c3=b6m?= Message-ID: Date: Tue, 24 Nov 2020 14:10:05 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <20201124115707.406917-1-maarten.lankhorst@linux.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On 11/24/20 12:57 PM, Maarten Lankhorst wrote: > We hardcode the maximum number of shared fences to 4, instead of > respecting num_fences. Use a minimum of 4, but more if num_fences > is higher. > > This seems to have been an oversight when first implementing the > api. > > Fixes: 04a5faa8cbe5 ("reservation: update api and add some helpers") > Cc: # v3.17+ > Reported-by: Niranjana Vishwanathapura > Signed-off-by: Maarten Lankhorst > --- > drivers/dma-buf/dma-resv.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Thomas Hellström From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B83BAC63777 for ; Wed, 25 Nov 2020 08:12:24 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 61704208CA for ; Wed, 25 Nov 2020 08:12:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 61704208CA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 876566E854; Wed, 25 Nov 2020 08:11:55 +0000 (UTC) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id E74B66E22B; Tue, 24 Nov 2020 13:10:25 +0000 (UTC) IronPort-SDR: SadUAcEo2Metyajv1TyufdzcSLvF6ubmCxtX4i7uwC/NnCKm1HhvojtwCfrFCA0Nrv/8eQhTum LppsFsF7GYYw== X-IronPort-AV: E=McAfee;i="6000,8403,9814"; a="171159333" X-IronPort-AV: E=Sophos;i="5.78,366,1599548400"; d="scan'208";a="171159333" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Nov 2020 05:10:25 -0800 IronPort-SDR: mJrVMzwaCSVvK+lHDeSxpNM70cSXr9AW1IGVs3JHPvbItXWdnnTDOwg0euZmoeNJzu+kADjFhY R37+4eR0PxCA== X-IronPort-AV: E=Sophos;i="5.78,366,1599548400"; d="scan'208";a="536470044" Received: from ndavidso-mobl4.ger.corp.intel.com (HELO Win10on49-0007.SSPE.ch.intel.com) ([10.255.198.190]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Nov 2020 05:10:23 -0800 Subject: Re: [Intel-gfx] [PATCH] dma-buf/dma-resv: Respect num_fences when initializing the shared fence list. To: Maarten Lankhorst , dri-devel@lists.freedesktop.org References: <20201124115707.406917-1-maarten.lankhorst@linux.intel.com> From: =?UTF-8?Q?Thomas_Hellstr=c3=b6m?= Message-ID: Date: Tue, 24 Nov 2020 14:10:05 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <20201124115707.406917-1-maarten.lankhorst@linux.intel.com> Content-Language: en-US X-Mailman-Approved-At: Wed, 25 Nov 2020 08:11:52 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, stable@vger.kernel.org Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Ck9uIDExLzI0LzIwIDEyOjU3IFBNLCBNYWFydGVuIExhbmtob3JzdCB3cm90ZToKPiBXZSBoYXJk Y29kZSB0aGUgbWF4aW11bSBudW1iZXIgb2Ygc2hhcmVkIGZlbmNlcyB0byA0LCBpbnN0ZWFkIG9m Cj4gcmVzcGVjdGluZyBudW1fZmVuY2VzLiBVc2UgYSBtaW5pbXVtIG9mIDQsIGJ1dCBtb3JlIGlm IG51bV9mZW5jZXMKPiBpcyBoaWdoZXIuCj4KPiBUaGlzIHNlZW1zIHRvIGhhdmUgYmVlbiBhbiBv dmVyc2lnaHQgd2hlbiBmaXJzdCBpbXBsZW1lbnRpbmcgdGhlCj4gYXBpLgo+Cj4gRml4ZXM6IDA0 YTVmYWE4Y2JlNSAoInJlc2VydmF0aW9uOiB1cGRhdGUgYXBpIGFuZCBhZGQgc29tZSBoZWxwZXJz IikKPiBDYzogPHN0YWJsZUB2Z2VyLmtlcm5lbC5vcmc+ICMgdjMuMTcrCj4gUmVwb3J0ZWQtYnk6 IE5pcmFuamFuYSBWaXNod2FuYXRoYXB1cmEgPG5pcmFuamFuYS52aXNod2FuYXRoYXB1cmFAaW50 ZWwuY29tPgo+IFNpZ25lZC1vZmYtYnk6IE1hYXJ0ZW4gTGFua2hvcnN0IDxtYWFydGVuLmxhbmto b3JzdEBsaW51eC5pbnRlbC5jb20+Cj4gLS0tCj4gICBkcml2ZXJzL2RtYS1idWYvZG1hLXJlc3Yu YyB8IDIgKy0KPiAgIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMSBkZWxldGlvbigt KQo+ClJldmlld2VkLWJ5OiBUaG9tYXMgSGVsbHN0csO2bSA8dGhvbWFzLmhlbGxzdHJvbUBsaW51 eC5pbnRlbC5jb20+CgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Au b3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRl dmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EFB2C2D0E4 for ; Tue, 24 Nov 2020 13:10:28 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0944D206D9 for ; Tue, 24 Nov 2020 13:10:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0944D206D9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4CC906E22B; Tue, 24 Nov 2020 13:10:27 +0000 (UTC) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id E74B66E22B; Tue, 24 Nov 2020 13:10:25 +0000 (UTC) IronPort-SDR: SadUAcEo2Metyajv1TyufdzcSLvF6ubmCxtX4i7uwC/NnCKm1HhvojtwCfrFCA0Nrv/8eQhTum LppsFsF7GYYw== X-IronPort-AV: E=McAfee;i="6000,8403,9814"; a="171159333" X-IronPort-AV: E=Sophos;i="5.78,366,1599548400"; d="scan'208";a="171159333" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Nov 2020 05:10:25 -0800 IronPort-SDR: mJrVMzwaCSVvK+lHDeSxpNM70cSXr9AW1IGVs3JHPvbItXWdnnTDOwg0euZmoeNJzu+kADjFhY R37+4eR0PxCA== X-IronPort-AV: E=Sophos;i="5.78,366,1599548400"; d="scan'208";a="536470044" Received: from ndavidso-mobl4.ger.corp.intel.com (HELO Win10on49-0007.SSPE.ch.intel.com) ([10.255.198.190]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Nov 2020 05:10:23 -0800 To: Maarten Lankhorst , dri-devel@lists.freedesktop.org References: <20201124115707.406917-1-maarten.lankhorst@linux.intel.com> From: =?UTF-8?Q?Thomas_Hellstr=c3=b6m?= Message-ID: Date: Tue, 24 Nov 2020 14:10:05 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <20201124115707.406917-1-maarten.lankhorst@linux.intel.com> Content-Language: en-US Subject: Re: [Intel-gfx] [PATCH] dma-buf/dma-resv: Respect num_fences when initializing the shared fence list. X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, stable@vger.kernel.org Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Ck9uIDExLzI0LzIwIDEyOjU3IFBNLCBNYWFydGVuIExhbmtob3JzdCB3cm90ZToKPiBXZSBoYXJk Y29kZSB0aGUgbWF4aW11bSBudW1iZXIgb2Ygc2hhcmVkIGZlbmNlcyB0byA0LCBpbnN0ZWFkIG9m Cj4gcmVzcGVjdGluZyBudW1fZmVuY2VzLiBVc2UgYSBtaW5pbXVtIG9mIDQsIGJ1dCBtb3JlIGlm IG51bV9mZW5jZXMKPiBpcyBoaWdoZXIuCj4KPiBUaGlzIHNlZW1zIHRvIGhhdmUgYmVlbiBhbiBv dmVyc2lnaHQgd2hlbiBmaXJzdCBpbXBsZW1lbnRpbmcgdGhlCj4gYXBpLgo+Cj4gRml4ZXM6IDA0 YTVmYWE4Y2JlNSAoInJlc2VydmF0aW9uOiB1cGRhdGUgYXBpIGFuZCBhZGQgc29tZSBoZWxwZXJz IikKPiBDYzogPHN0YWJsZUB2Z2VyLmtlcm5lbC5vcmc+ICMgdjMuMTcrCj4gUmVwb3J0ZWQtYnk6 IE5pcmFuamFuYSBWaXNod2FuYXRoYXB1cmEgPG5pcmFuamFuYS52aXNod2FuYXRoYXB1cmFAaW50 ZWwuY29tPgo+IFNpZ25lZC1vZmYtYnk6IE1hYXJ0ZW4gTGFua2hvcnN0IDxtYWFydGVuLmxhbmto b3JzdEBsaW51eC5pbnRlbC5jb20+Cj4gLS0tCj4gICBkcml2ZXJzL2RtYS1idWYvZG1hLXJlc3Yu YyB8IDIgKy0KPiAgIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMSBkZWxldGlvbigt KQo+ClJldmlld2VkLWJ5OiBUaG9tYXMgSGVsbHN0csO2bSA8dGhvbWFzLmhlbGxzdHJvbUBsaW51 eC5pbnRlbC5jb20+CgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Au b3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwt Z2Z4Cg==