From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05D98C3A5A5 for ; Thu, 5 Sep 2019 06:38:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BF7652173B for ; Thu, 5 Sep 2019 06:37:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=geanix.com header.i=@geanix.com header.b="X5Uh+reR" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731461AbfIEGh7 (ORCPT ); Thu, 5 Sep 2019 02:37:59 -0400 Received: from first.geanix.com ([116.203.34.67]:37996 "EHLO first.geanix.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731109AbfIEGh7 (ORCPT ); Thu, 5 Sep 2019 02:37:59 -0400 Received: from [192.168.100.95] (unknown [95.138.208.137]) by first.geanix.com (Postfix) with ESMTPSA id B256A62578; Thu, 5 Sep 2019 06:37:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=geanix.com; s=first; t=1567665467; bh=ooslwGUmbaszu9MhAQWuNDQEghCIlWpljFHDJnX/X6I=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=X5Uh+reRPNOaDWd+0IKKc7qtr/4gH1lEX0LJ7xr8i4Zn+KxN0flEvego5JFtD3ZSI 1cmRq6WUCHMRFsv7pHSzf8mAP2HOPvsRBBembc8K4ScYsn+udn8kgosOZWJZKz+wKT sa1tvc8WO7PKtWMSnJDzmzhflzs2LCObXKjBjgbv/MRw0r5tHUMf7pgRM+u5Q0xO6Q FKLFkun4sPwshHx8MB5DlLzUbVMDbuPTydDgFE0iQgT6oUPLrUjQ3neHpe2LJYSP7F YBo1KwbgmXfCmq8y2ppaQ+SF0TjEjv+Ov+yxsdKBgUFLCNjBiYc9snU7lbAtBY9Xe5 yMJu0DGPRTcMA== Subject: Re: [PATCH v3 4/6] iio: imu: st_lsm6dsx: always enter interrupt thread To: Lorenzo Bianconi Cc: linux-iio@vger.kernel.org, jic23@kernel.org, lorenzo.bianconi83@gmail.com, denis.ciocca@st.com, mario.tesi@st.com, armando.visconti@st.com, martin@geanix.com References: <20190904091732.112281-1-sean@geanix.com> <20190904091732.112281-4-sean@geanix.com> <20190905063441.GA31578@localhost.localdomain> From: Sean Nyekjaer Message-ID: Date: Thu, 5 Sep 2019 08:37:35 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190905063441.GA31578@localhost.localdomain> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US-large Content-Transfer-Encoding: 7bit Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On 05/09/2019 08.34, Lorenzo Bianconi wrote: > This chunck is unnecessary since read_fifo() will check number of available > samples in the FIFO and moreover it is obviously broken since you are running > st_lsm6dsx_read_fifo directly instead of using fifo_ops pointer. Thanks for the review :-) I have missed that, I have spend a lot of time rebasing "iio: imu: st_lsm6dsx: move interrupt thread to core". It could be nice if that patch could be applied in the near future :-) /Sean