From: Joerg Vehlow <lkml@jv-coder.de>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v3 3/4] lib: ignore SIGINT in _tst_kill_test
Date: Tue, 18 May 2021 06:57:15 +0200 [thread overview]
Message-ID: <a4154e09-8ae3-beb3-13d5-c92126177ed5@jv-coder.de> (raw)
In-Reply-To: <CAEemH2fRLqipQWTxVsakYNGsmQT+2X8_xzgepCiAY1O8YWtKFA@mail.gmail.com>
Hi Li,
On 5/13/2021 7:08 AM, Li Wang wrote:
>> FYI I tried to use both SIGINT and SIGTERM, but there was some problem.
>> But I guess it was my error. Please *add* SIGTERM (keep SIGINT).
> Yes, we'd better keep SIGINT for ctrl^c action and use SIGTERM
> additionally for process terminating.
>
> Does this below (rough solution in my mind) work for you?
>
> diff --git a/lib/newlib_tests/shell/timeout03.sh
> b/lib/newlib_tests/shell/timeout03.sh
> index cd548d9a2..f39f5712a 100755
> --- a/lib/newlib_tests/shell/timeout03.sh
> +++ b/lib/newlib_tests/shell/timeout03.sh
> @@ -30,6 +30,7 @@ TST_TIMEOUT=1
>
> do_test()
> {
> + trap "echo 'Sorry, timeout03 is still alive'" TERM
> tst_res TINFO "testing killing test after TST_TIMEOUT"
>
> sleep 2
> diff --git a/testcases/lib/tst_test.sh b/testcases/lib/tst_test.sh
> index 28c2052d6..d7c9791e9 100644
> --- a/testcases/lib/tst_test.sh
> +++ b/testcases/lib/tst_test.sh
> @@ -21,7 +21,7 @@ export TST_LIB_LOADED=1
> . tst_security.sh
>
> # default trap function
> -trap "tst_brk TBROK 'test interrupted or timed out'" INT
> +trap "tst_brk TBROK 'test interrupted'" INT
This would require something like
trap "tst_brk TBROK 'test terminated'" TERM
or
trap "_tst_do_exit" TERM
Otherwise the test is terminated very roughly, without executing
cleanup, which is probably not a good idea.
But that introduces the next problem: A short deadlock between
_tst_kill_test and _tst_cleanup_timer,
because _tst_cleanup_timer waits for the termination of the timeout
process and vice versa.
Another problem is, that a SIGTERM originating from some other location
could look like a timeout.
I am currently thinking about the following solution, to mitigate most
problems:
The timeout process sends SIGUSR1 (or maybe SIGALRM?) only to the main
test process and blocks TERM.
The main process can print, that it ran into a timeout, send a sigterm
to its processs group (while ignoring TERM itself).
Then it can unset $_tst_setup_timer_pid safely, because it knows it was
triggered by the timeout process and execute _tst_do_exit.
If the timeout process does not see the termination of the main process,
it can still send SIGKILL to the whole process group.
J?rg
next prev parent reply other threads:[~2021-05-18 4:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-08 5:51 [LTP] [PATCH v3 3/4] lib: ignore SIGINT in _tst_kill_test Li Wang
2021-05-10 11:47 ` Cyril Hrubis
2021-05-11 5:54 ` Joerg Vehlow
2021-05-12 9:49 ` Li Wang
2021-05-12 10:34 ` Joerg Vehlow
2021-05-12 14:20 ` Petr Vorel
2021-05-13 5:08 ` Li Wang
2021-05-14 7:53 ` Petr Vorel
2021-05-14 9:10 ` Li Wang
2021-05-14 15:10 ` Petr Vorel
2021-05-18 4:57 ` Joerg Vehlow [this message]
2021-05-18 7:27 ` Li Wang
2021-05-18 8:46 ` Petr Vorel
2021-05-18 9:45 ` Joerg Vehlow
2021-05-18 12:01 ` Li Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a4154e09-8ae3-beb3-13d5-c92126177ed5@jv-coder.de \
--to=lkml@jv-coder.de \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.