From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB241C433E0 for ; Fri, 22 Jan 2021 08:14:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 750CA23358 for ; Fri, 22 Jan 2021 08:14:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727022AbhAVIOd (ORCPT ); Fri, 22 Jan 2021 03:14:33 -0500 Received: from mx2.suse.de ([195.135.220.15]:49838 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726880AbhAVIO3 (ORCPT ); Fri, 22 Jan 2021 03:14:29 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 6F202ABD6; Fri, 22 Jan 2021 08:13:43 +0000 (UTC) To: Gerd Hoffmann , dri-devel@lists.freedesktop.org Cc: David Airlie , open list , "open list:DRM DRIVER FOR QXL VIRTUAL GPU" , "open list:DRM DRIVER FOR QXL VIRTUAL GPU" , Dave Airlie References: <20210120111240.2509679-1-kraxel@redhat.com> <20210120111240.2509679-3-kraxel@redhat.com> From: Thomas Zimmermann Subject: Re: [PATCH v3 2/4] drm/qxl: unpin release objects Message-ID: Date: Fri, 22 Jan 2021 09:13:42 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20210120111240.2509679-3-kraxel@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="8lDQ2R8nzpd2PKtDZloK0uSHN2Cl2aRVD" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --8lDQ2R8nzpd2PKtDZloK0uSHN2Cl2aRVD Content-Type: multipart/mixed; boundary="DkAhTomUwaEiij7TgXImvKEG8i01RUXo9"; protected-headers="v1" From: Thomas Zimmermann To: Gerd Hoffmann , dri-devel@lists.freedesktop.org Cc: David Airlie , open list , "open list:DRM DRIVER FOR QXL VIRTUAL GPU" , "open list:DRM DRIVER FOR QXL VIRTUAL GPU" , Dave Airlie Message-ID: Subject: Re: [PATCH v3 2/4] drm/qxl: unpin release objects References: <20210120111240.2509679-1-kraxel@redhat.com> <20210120111240.2509679-3-kraxel@redhat.com> In-Reply-To: <20210120111240.2509679-3-kraxel@redhat.com> --DkAhTomUwaEiij7TgXImvKEG8i01RUXo9 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable Hi Am 20.01.21 um 12:12 schrieb Gerd Hoffmann: > Balances the qxl_create_bo(..., pinned=3Dtrue, ...); > call in qxl_release_bo_alloc(). >=20 > Signed-off-by: Gerd Hoffmann > --- > drivers/gpu/drm/qxl/qxl_release.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/drivers/gpu/drm/qxl/qxl_release.c b/drivers/gpu/drm/qxl/qx= l_release.c > index 0fcfc952d5e9..add979cba11b 100644 > --- a/drivers/gpu/drm/qxl/qxl_release.c > +++ b/drivers/gpu/drm/qxl/qxl_release.c > @@ -166,6 +166,7 @@ qxl_release_free_list(struct qxl_release *release) > entry =3D container_of(release->bos.next, > struct qxl_bo_list, tv.head); > bo =3D to_qxl_bo(entry->tv.bo); > + bo->tbo.pin_count =3D 0; /* ttm_bo_unpin(&bo->tbo); */ This code looks like a workaround or a bug. AFAICT the only place with pre-pinned BO is qdev->dumb_shadow_bo. Can=20 you remove the pinned flag entirely and handle pinning as part of=20 dumb_shadow_bo's code. Otherwise maybe use if (pin_count) ttm_bo_unpin(); WARN_ON(pin_count); /* should always be 0 now */ with a comment similar to the commit's description. Best regards Thomas > qxl_bo_unref(&bo); > list_del(&entry->tv.head); > kfree(entry); >=20 --=20 Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany (HRB 36809, AG N=C3=BCrnberg) Gesch=C3=A4ftsf=C3=BChrer: Felix Imend=C3=B6rffer --DkAhTomUwaEiij7TgXImvKEG8i01RUXo9-- --8lDQ2R8nzpd2PKtDZloK0uSHN2Cl2aRVD Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsF5BAABCAAjFiEExndm/fpuMUdwYFFolh/E3EQov+AFAmAKiTYFAwAAAAAACgkQlh/E3EQov+Db ng/+IKIfMqKZFPcMiJWzE+ihESlVvBqmriFdyTyOZk/0lwMLZ+p9oS2KQ+Z/cSh4LMzdCYbcECAH JXE+20bCFPgoNnE6Fsfh53gVKB1xe950iw/q/88trV8XS3ow2mPRyu63zl6q4UEibuaFDmnDNV85 M/3pD9NW75VVsenIRemaRRBJA0rAEJkQmud+QkhC6APefYSVKAwGo/3uoHLiiUx0fZVXdsF6HX/p RyShmizdLnpOl11mNoAZM3cpMmsV0pHWc/GnfzS8BUuvvgqC3w9bDD6BnpfUwkmAnVcaRqkSonUa NjiQszNqx7r643/OwFc5FAUgBmdqLUsvGlm1QsILkZWbR0pWTPUA5thR5HYBKYcbgIviJmQIREN/ T3wMCZvfvmuREypOeueVR9ODzx0HKY/kdY5KpJCB6gGc8Uzq9IPfhV7HkSij77HQQTEIi6qL5Zs+ RjUheJwyCheNvMeBPY9ME9s7p4Zqe7ODGwl8Rdjc8nl4+Ptd4z+HGHN5Ptf0AtehDfDEeyvE/VRZ nLLY8hUyg6ZyXpo6kjDSexspN9e/tm5s3nwAGb7tjCESEmFshylT1f24meedFY7ydTgmq15Y68IG XpUNmIJboON9lwlKkEZNwF4tliuFs2xMvr/fGDvVCRImx5fryhLc87Dk0+3XXycWFwcBPkVY36lE o2I= =zuLX -----END PGP SIGNATURE----- --8lDQ2R8nzpd2PKtDZloK0uSHN2Cl2aRVD-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E06A4C433E6 for ; Fri, 22 Jan 2021 08:13:50 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3F4C423358 for ; Fri, 22 Jan 2021 08:13:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3F4C423358 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=virtualization-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id B4A0A87335; Fri, 22 Jan 2021 08:13:49 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vxOq4XeEY7Wn; Fri, 22 Jan 2021 08:13:48 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by hemlock.osuosl.org (Postfix) with ESMTP id 1D09F87330; Fri, 22 Jan 2021 08:13:48 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 04070C088B; Fri, 22 Jan 2021 08:13:48 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists.linuxfoundation.org (Postfix) with ESMTP id 23E7BC013A for ; Fri, 22 Jan 2021 08:13:46 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 08C018588A for ; Fri, 22 Jan 2021 08:13:46 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id i1Rd7juQRUF2 for ; Fri, 22 Jan 2021 08:13:45 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by whitealder.osuosl.org (Postfix) with ESMTPS id 0CA03810B8 for ; Fri, 22 Jan 2021 08:13:44 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 6F202ABD6; Fri, 22 Jan 2021 08:13:43 +0000 (UTC) To: Gerd Hoffmann , dri-devel@lists.freedesktop.org References: <20210120111240.2509679-1-kraxel@redhat.com> <20210120111240.2509679-3-kraxel@redhat.com> From: Thomas Zimmermann Subject: Re: [PATCH v3 2/4] drm/qxl: unpin release objects Message-ID: Date: Fri, 22 Jan 2021 09:13:42 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20210120111240.2509679-3-kraxel@redhat.com> Cc: David Airlie , "open list:DRM DRIVER FOR QXL VIRTUAL GPU" , Dave Airlie , open list , "open list:DRM DRIVER FOR QXL VIRTUAL GPU" X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============0147135261824549803==" Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============0147135261824549803== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="8lDQ2R8nzpd2PKtDZloK0uSHN2Cl2aRVD" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --8lDQ2R8nzpd2PKtDZloK0uSHN2Cl2aRVD Content-Type: multipart/mixed; boundary="DkAhTomUwaEiij7TgXImvKEG8i01RUXo9"; protected-headers="v1" From: Thomas Zimmermann To: Gerd Hoffmann , dri-devel@lists.freedesktop.org Cc: David Airlie , open list , "open list:DRM DRIVER FOR QXL VIRTUAL GPU" , "open list:DRM DRIVER FOR QXL VIRTUAL GPU" , Dave Airlie Message-ID: Subject: Re: [PATCH v3 2/4] drm/qxl: unpin release objects References: <20210120111240.2509679-1-kraxel@redhat.com> <20210120111240.2509679-3-kraxel@redhat.com> In-Reply-To: <20210120111240.2509679-3-kraxel@redhat.com> --DkAhTomUwaEiij7TgXImvKEG8i01RUXo9 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable Hi Am 20.01.21 um 12:12 schrieb Gerd Hoffmann: > Balances the qxl_create_bo(..., pinned=3Dtrue, ...); > call in qxl_release_bo_alloc(). >=20 > Signed-off-by: Gerd Hoffmann > --- > drivers/gpu/drm/qxl/qxl_release.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/drivers/gpu/drm/qxl/qxl_release.c b/drivers/gpu/drm/qxl/qx= l_release.c > index 0fcfc952d5e9..add979cba11b 100644 > --- a/drivers/gpu/drm/qxl/qxl_release.c > +++ b/drivers/gpu/drm/qxl/qxl_release.c > @@ -166,6 +166,7 @@ qxl_release_free_list(struct qxl_release *release) > entry =3D container_of(release->bos.next, > struct qxl_bo_list, tv.head); > bo =3D to_qxl_bo(entry->tv.bo); > + bo->tbo.pin_count =3D 0; /* ttm_bo_unpin(&bo->tbo); */ This code looks like a workaround or a bug. AFAICT the only place with pre-pinned BO is qdev->dumb_shadow_bo. Can=20 you remove the pinned flag entirely and handle pinning as part of=20 dumb_shadow_bo's code. Otherwise maybe use if (pin_count) ttm_bo_unpin(); WARN_ON(pin_count); /* should always be 0 now */ with a comment similar to the commit's description. Best regards Thomas > qxl_bo_unref(&bo); > list_del(&entry->tv.head); > kfree(entry); >=20 --=20 Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany (HRB 36809, AG N=C3=BCrnberg) Gesch=C3=A4ftsf=C3=BChrer: Felix Imend=C3=B6rffer --DkAhTomUwaEiij7TgXImvKEG8i01RUXo9-- --8lDQ2R8nzpd2PKtDZloK0uSHN2Cl2aRVD Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsF5BAABCAAjFiEExndm/fpuMUdwYFFolh/E3EQov+AFAmAKiTYFAwAAAAAACgkQlh/E3EQov+Db ng/+IKIfMqKZFPcMiJWzE+ihESlVvBqmriFdyTyOZk/0lwMLZ+p9oS2KQ+Z/cSh4LMzdCYbcECAH JXE+20bCFPgoNnE6Fsfh53gVKB1xe950iw/q/88trV8XS3ow2mPRyu63zl6q4UEibuaFDmnDNV85 M/3pD9NW75VVsenIRemaRRBJA0rAEJkQmud+QkhC6APefYSVKAwGo/3uoHLiiUx0fZVXdsF6HX/p RyShmizdLnpOl11mNoAZM3cpMmsV0pHWc/GnfzS8BUuvvgqC3w9bDD6BnpfUwkmAnVcaRqkSonUa NjiQszNqx7r643/OwFc5FAUgBmdqLUsvGlm1QsILkZWbR0pWTPUA5thR5HYBKYcbgIviJmQIREN/ T3wMCZvfvmuREypOeueVR9ODzx0HKY/kdY5KpJCB6gGc8Uzq9IPfhV7HkSij77HQQTEIi6qL5Zs+ RjUheJwyCheNvMeBPY9ME9s7p4Zqe7ODGwl8Rdjc8nl4+Ptd4z+HGHN5Ptf0AtehDfDEeyvE/VRZ nLLY8hUyg6ZyXpo6kjDSexspN9e/tm5s3nwAGb7tjCESEmFshylT1f24meedFY7ydTgmq15Y68IG XpUNmIJboON9lwlKkEZNwF4tliuFs2xMvr/fGDvVCRImx5fryhLc87Dk0+3XXycWFwcBPkVY36lE o2I= =zuLX -----END PGP SIGNATURE----- --8lDQ2R8nzpd2PKtDZloK0uSHN2Cl2aRVD-- --===============0147135261824549803== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization --===============0147135261824549803==-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E118EC433DB for ; Fri, 22 Jan 2021 08:13:49 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6B9C223358 for ; Fri, 22 Jan 2021 08:13:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6B9C223358 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C45756E2EF; Fri, 22 Jan 2021 08:13:46 +0000 (UTC) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id D7EA06E05A; Fri, 22 Jan 2021 08:13:44 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 6F202ABD6; Fri, 22 Jan 2021 08:13:43 +0000 (UTC) To: Gerd Hoffmann , dri-devel@lists.freedesktop.org References: <20210120111240.2509679-1-kraxel@redhat.com> <20210120111240.2509679-3-kraxel@redhat.com> From: Thomas Zimmermann Subject: Re: [PATCH v3 2/4] drm/qxl: unpin release objects Message-ID: Date: Fri, 22 Jan 2021 09:13:42 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20210120111240.2509679-3-kraxel@redhat.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , "open list:DRM DRIVER FOR QXL VIRTUAL GPU" , Dave Airlie , open list , "open list:DRM DRIVER FOR QXL VIRTUAL GPU" Content-Type: multipart/mixed; boundary="===============1969096869==" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============1969096869== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="8lDQ2R8nzpd2PKtDZloK0uSHN2Cl2aRVD" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --8lDQ2R8nzpd2PKtDZloK0uSHN2Cl2aRVD Content-Type: multipart/mixed; boundary="DkAhTomUwaEiij7TgXImvKEG8i01RUXo9"; protected-headers="v1" From: Thomas Zimmermann To: Gerd Hoffmann , dri-devel@lists.freedesktop.org Cc: David Airlie , open list , "open list:DRM DRIVER FOR QXL VIRTUAL GPU" , "open list:DRM DRIVER FOR QXL VIRTUAL GPU" , Dave Airlie Message-ID: Subject: Re: [PATCH v3 2/4] drm/qxl: unpin release objects References: <20210120111240.2509679-1-kraxel@redhat.com> <20210120111240.2509679-3-kraxel@redhat.com> In-Reply-To: <20210120111240.2509679-3-kraxel@redhat.com> --DkAhTomUwaEiij7TgXImvKEG8i01RUXo9 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable Hi Am 20.01.21 um 12:12 schrieb Gerd Hoffmann: > Balances the qxl_create_bo(..., pinned=3Dtrue, ...); > call in qxl_release_bo_alloc(). >=20 > Signed-off-by: Gerd Hoffmann > --- > drivers/gpu/drm/qxl/qxl_release.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/drivers/gpu/drm/qxl/qxl_release.c b/drivers/gpu/drm/qxl/qx= l_release.c > index 0fcfc952d5e9..add979cba11b 100644 > --- a/drivers/gpu/drm/qxl/qxl_release.c > +++ b/drivers/gpu/drm/qxl/qxl_release.c > @@ -166,6 +166,7 @@ qxl_release_free_list(struct qxl_release *release) > entry =3D container_of(release->bos.next, > struct qxl_bo_list, tv.head); > bo =3D to_qxl_bo(entry->tv.bo); > + bo->tbo.pin_count =3D 0; /* ttm_bo_unpin(&bo->tbo); */ This code looks like a workaround or a bug. AFAICT the only place with pre-pinned BO is qdev->dumb_shadow_bo. Can=20 you remove the pinned flag entirely and handle pinning as part of=20 dumb_shadow_bo's code. Otherwise maybe use if (pin_count) ttm_bo_unpin(); WARN_ON(pin_count); /* should always be 0 now */ with a comment similar to the commit's description. Best regards Thomas > qxl_bo_unref(&bo); > list_del(&entry->tv.head); > kfree(entry); >=20 --=20 Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany (HRB 36809, AG N=C3=BCrnberg) Gesch=C3=A4ftsf=C3=BChrer: Felix Imend=C3=B6rffer --DkAhTomUwaEiij7TgXImvKEG8i01RUXo9-- --8lDQ2R8nzpd2PKtDZloK0uSHN2Cl2aRVD Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsF5BAABCAAjFiEExndm/fpuMUdwYFFolh/E3EQov+AFAmAKiTYFAwAAAAAACgkQlh/E3EQov+Db ng/+IKIfMqKZFPcMiJWzE+ihESlVvBqmriFdyTyOZk/0lwMLZ+p9oS2KQ+Z/cSh4LMzdCYbcECAH JXE+20bCFPgoNnE6Fsfh53gVKB1xe950iw/q/88trV8XS3ow2mPRyu63zl6q4UEibuaFDmnDNV85 M/3pD9NW75VVsenIRemaRRBJA0rAEJkQmud+QkhC6APefYSVKAwGo/3uoHLiiUx0fZVXdsF6HX/p RyShmizdLnpOl11mNoAZM3cpMmsV0pHWc/GnfzS8BUuvvgqC3w9bDD6BnpfUwkmAnVcaRqkSonUa NjiQszNqx7r643/OwFc5FAUgBmdqLUsvGlm1QsILkZWbR0pWTPUA5thR5HYBKYcbgIviJmQIREN/ T3wMCZvfvmuREypOeueVR9ODzx0HKY/kdY5KpJCB6gGc8Uzq9IPfhV7HkSij77HQQTEIi6qL5Zs+ RjUheJwyCheNvMeBPY9ME9s7p4Zqe7ODGwl8Rdjc8nl4+Ptd4z+HGHN5Ptf0AtehDfDEeyvE/VRZ nLLY8hUyg6ZyXpo6kjDSexspN9e/tm5s3nwAGb7tjCESEmFshylT1f24meedFY7ydTgmq15Y68IG XpUNmIJboON9lwlKkEZNwF4tliuFs2xMvr/fGDvVCRImx5fryhLc87Dk0+3XXycWFwcBPkVY36lE o2I= =zuLX -----END PGP SIGNATURE----- --8lDQ2R8nzpd2PKtDZloK0uSHN2Cl2aRVD-- --===============1969096869== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel --===============1969096869==--