From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Rasmus Villemoes <rasmus.villemoes@prevas.dk>,
Wolfgang Grandegger <wg@grandegger.com>,
"David S. Miller" <davem@davemloft.net>
Cc: Thomas Winding <twi@deif.com>, Fabio Estevam <festevam@gmail.com>,
Per Christensen <pnc@deif.com>,
Rasmus Villemoes <Rasmus.Villemoes@prevas.se>,
"linux-can@vger.kernel.org" <linux-can@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] can: flexcan: bump FLEXCAN_TIMEOUT_US to 250
Date: Wed, 20 Mar 2019 14:18:02 +0100 [thread overview]
Message-ID: <a418bbc9-186c-174a-20d8-18cedeaf0089@pengutronix.de> (raw)
In-Reply-To: <20190307150024.23628-1-rasmus.villemoes@prevas.dk>
[-- Attachment #1.1: Type: text/plain, Size: 1033 bytes --]
On 3/7/19 4:00 PM, Rasmus Villemoes wrote:
> While trying to add support for the Flexcan modules on the MPC8309,
> I'm hitting ETIMEDOUT in flexcan_chip_disable(). With this, probing
> succeeds. Checking the leftover value of timeout with a primitive
>
> pr_err("%s: timeout==%d\n", __func__, timeout);
>
> after the loop in chip_disable() typically shows values around 12-14,
> i.e. suggesting that it takes about 110-130 us for the LPM_ACK bit to
> appear. So a timeout value of about twice that seems reasonable.
>
> Signed-off-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
I've scheduled the patch by Joakim Zhang:
9daed89ae8a3 can: flexcan: fix timeout when set small bitrate
that doubles the timeout to 100.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-03-20 13:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-07 15:00 [PATCH] can: flexcan: bump FLEXCAN_TIMEOUT_US to 250 Rasmus Villemoes
2019-03-18 7:40 ` Rasmus Villemoes
2019-03-20 13:18 ` Marc Kleine-Budde [this message]
2019-03-21 14:34 ` Rasmus Villemoes
2019-03-21 15:30 ` Marc Kleine-Budde
2019-03-22 7:45 ` Rasmus Villemoes
2019-03-22 7:51 ` Marc Kleine-Budde
2019-04-29 8:53 ` Rasmus Villemoes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a418bbc9-186c-174a-20d8-18cedeaf0089@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=Rasmus.Villemoes@prevas.se \
--cc=davem@davemloft.net \
--cc=festevam@gmail.com \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pnc@deif.com \
--cc=rasmus.villemoes@prevas.dk \
--cc=twi@deif.com \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.