From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D998C4727E for ; Wed, 30 Sep 2020 09:42:38 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E7A462075F for ; Wed, 30 Sep 2020 09:42:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=xen.org header.i=@xen.org header.b="g4xVF3et" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E7A462075F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=xen.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.522.1693 (Exim 4.92) (envelope-from ) id 1kNYcz-0003An-Ny; Wed, 30 Sep 2020 09:42:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 522.1693; Wed, 30 Sep 2020 09:42:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kNYcz-0003Ag-Kl; Wed, 30 Sep 2020 09:42:25 +0000 Received: by outflank-mailman (input) for mailman id 522; Wed, 30 Sep 2020 09:42:25 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kNYcy-0003Ab-Qy for xen-devel@lists.xenproject.org; Wed, 30 Sep 2020 09:42:24 +0000 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 973297cf-8140-4ba2-a1dd-66a557607573; Wed, 30 Sep 2020 09:42:23 +0000 (UTC) Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kNYcq-0005t8-3n; Wed, 30 Sep 2020 09:42:16 +0000 Received: from [54.239.6.187] (helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1kNYcp-0000RB-Jh; Wed, 30 Sep 2020 09:42:15 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kNYcy-0003Ab-Qy for xen-devel@lists.xenproject.org; Wed, 30 Sep 2020 09:42:24 +0000 X-Inumbo-ID: 973297cf-8140-4ba2-a1dd-66a557607573 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 973297cf-8140-4ba2-a1dd-66a557607573; Wed, 30 Sep 2020 09:42:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=xic4rwKFNSGMZvHHU+BDo4SBCLwhyV/nfqleyVA5Ta4=; b=g4xVF3etM0LpddmrLvybuaV1lR gQsj4GJgJxabjVxwAl2peZZATwMADgWATDvyU4QzQHL0Ouhk1unb1I3Au/bgR9SBmXj4nH3F95uVm ZlyAKF0It49bHCiYrOIYn26GehBkkrZfvYs9xDqpzf7Dwirk3vXzUkakf8WKQcLwSSPU=; Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kNYcq-0005t8-3n; Wed, 30 Sep 2020 09:42:16 +0000 Received: from [54.239.6.187] (helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1kNYcp-0000RB-Jh; Wed, 30 Sep 2020 09:42:15 +0000 Subject: Re: [PATCH 0/4] xen/arm: Unbreak ACPI To: =?UTF-8?Q?Alex_Benn=c3=a9e?= Cc: xen-devel@lists.xenproject.org, masami.hiramatsu@linaro.org, ehem+xen@m5p.com, bertrand.marquis@arm.com, andre.przywara@arm.com, Julien Grall , Stefano Stabellini , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <20200926205542.9261-1-julien@xen.org> <87k0wcppnj.fsf@linaro.org> <5afbce1c-0c45-4b8c-771a-f83b91328e4a@xen.org> <87d024p9tc.fsf@linaro.org> From: Julien Grall Message-ID: Date: Wed, 30 Sep 2020 10:42:11 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.1.0 MIME-Version: 1.0 In-Reply-To: <87d024p9tc.fsf@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Hi Alex, On 29/09/2020 22:11, Alex Bennée wrote: > > Julien Grall writes: > >> Hi Alex, >> >> On 29/09/2020 16:29, Alex Bennée wrote: >>> >>> Julien Grall writes: >>> >>>> From: Julien Grall >>>> >>>> Hi all, >>>> >>>> Xen on ARM has been broken for quite a while on ACPI systems. This >>>> series aims to fix it. >>>> >>>> Unfortunately I don't have a system with ACPI v6.0 or later (QEMU seems >>>> to only support 5.1). So I did only some light testing. >>> >>> I was hoping to get more diagnostics out to get it working under QEMU >>> TCG so I think must of missed a step: >>> >>> Loading Xen 4.15-unstable ... >>> Loading Linux 4.19.0-11-arm64 ... >>> Loading initial ramdisk ... >>> Using modules provided by bootloader in FDT >>> Xen 4.15-unstable (c/s Sat Sep 26 21:55:42 2020 +0100 git:72f3d495d0) EFI loader >>> ...silence... >>> >>> I have a grub installed from testing on a buster base: >>> >>> dpkg --status grub-arm64-efi >>> Version: 2.04-8 >>> >>> With: >>> >>> GRUB_CMDLINE_LINUX_DEFAULT="" >>> GRUB_CMDLINE_LINUX="console=ttyAMA0" >>> GRUB_CMDLINE_LINUX_XEN_REPLACE="console=hvc0 earlyprintk=xen" >>> GRUB_CMDLINE_XEN="loglvl=all guest_loglvl=all com1=115200,8n1,0x3e8,5console=com1,vg" >>> >>> And I built Xen with --enable-systemd and tweaked the hypervisor .config: >>> >>> CONFIG_EXPERT=y >>> CONFIG_ACPI=y >>> >>> So any pointers to make it more verbose would be helpful. >> >> The error is hapenning before Xen setup the console. You can get early >> output on QEMU if you rebuild Xen with the following .config options: >> >> CONFIG_DEBUG=y >> CONFIG_EARLY_UART_CHOICE_PL011=y >> CONFIG_EARLY_UART_PL011=y >> CONFIG_EARLY_PRINTK=y >> CONFIG_EARLY_UART_BASE_ADDRESS=0x09000000 >> CONFIG_EARLY_UART_PL011_BAUD_RATE=0 >> CONFIG_EARLY_PRINTK_INC="debug-pl011.inc" > > OK I can see it fails on the ACPI and then tries to fall back to FDT and > then fails to find the GIC: > > (XEN) CMDLINE[00000000f7bbe000]:chosen placeholder root=UUID=cf00cd3a-066b-4146-bedf-f811d3343077 ro console=hvc0 earlyprintk=xen > (XEN) > (XEN) Command line: placeholder loglvl=all guest_loglvl=all com1=115200,8n1,0x3e8,5console=com1,vg no-real-mode edd=off > (XEN) parameter "placeholder" unknown! > (XEN) parameter "no-real-mode" unknown! > (XEN) parameter "edd" unknown! > (XEN) ACPI: RSDP 138560000, 0024 (r2 BOCHS ) > (XEN) ACPI: XSDT 138550000, 004C (r1 BOCHS BXPCFACP 1 1000013) > (XEN) ACPI: FACP 138510000, 010C (r5 BOCHS BXPCFACP 1 BXPC 1) > (XEN) ACPI: DSDT 138520000, 14A6 (r2 BOCHS BXPCDSDT 1 BXPC 1) > (XEN) ACPI: APIC 138500000, 018C (r3 BOCHS BXPCAPIC 1 BXPC 1) > (XEN) ACPI: GTDT 1384F0000, 0060 (r2 BOCHS BXPCGTDT 1 BXPC 1) > (XEN) ACPI: MCFG 1384E0000, 003C (r1 BOCHS BXPCMCFG 1 BXPC 1) > (XEN) ACPI: SPCR 1384D0000, 0050 (r2 BOCHS BXPCSPCR 1 BXPC 1) > (XEN) Unsupported FADT revision 5.1, should be 6.0+, will disable ACPI > (XEN) acpi_boot_table_init: FADT not found (-22) > (XEN) Domain heap initialised > (XEN) Booting using Device Tree > (XEN) Platform: Generic System > (XEN) > (XEN) **************************************** > (XEN) Panic on CPU 0: > (XEN) Unable to find compatible GIC in the device tree > (XEN) **************************************** > (XEN) > (XEN) Reboot in five seconds... > > Despite saying it is going to reboot it never manages to. Any idea how > it is trying to reset the system? This is a bit of chicken and eggs problem. To know the reset method, you need to parse the ACPI tables. As we can't parse then we don't know the reset method. So, Xen will just do an infinite loop. It would probably be good to be more forthcoming with the users and say it will not reboot. Also, IIRC, the time subsystem is not yet initialized. So it might be possible to mdelay() doesn't work properly. Cheers, -- Julien Grall