Re: [Qemu-devel] [PATCH] block/qcow.c: Fix memory leak in qcow_create() - Philippe Mathieu-Daudé

From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Max Reitz <mreitz@redhat.com>,
	qemu-block@nongnu.org, patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH] block/qcow.c: Fix memory leak in qcow_create()
Date: Mon, 5 Jun 2017 11:19:14 -0300	[thread overview]
Message-ID: <a4365718-b8b9-4968-fa1f-c8608752dd65@amsat.org> (raw)
In-Reply-To: <1496670954-664-1-git-send-email-peter.maydell@linaro.org>

On 06/05/2017 10:55 AM, Peter Maydell wrote:
> Coverity points out that the code path in qcow_create() for
> the magic "fat:" backing file name leaks the memory used to
> store the filename (CID 1307771). Free the memory before
> we overwrite the pointer.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

> ---
>  block/qcow.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/block/qcow.c b/block/qcow.c
> index 95ab123..7bd94dc 100644
> --- a/block/qcow.c
> +++ b/block/qcow.c
> @@ -852,6 +852,7 @@ static int qcow_create(const char *filename, QemuOpts *opts, Error **errp)
>              header_size += backing_filename_len;
>          } else {
>              /* special backing file for vvfat */
> +            g_free(backing_file);
>              backing_file = NULL;
>          }
>          header.cluster_bits = 9; /* 512 byte cluster to avoid copying
>