From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59525) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1etGmB-0005qw-CT for qemu-devel@nongnu.org; Tue, 06 Mar 2018 12:53:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1etGm8-0001qv-5p for qemu-devel@nongnu.org; Tue, 06 Mar 2018 12:53:23 -0500 Received: from mx0a-00190b01.pphosted.com ([2620:100:9001:583::1]:58498) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1etGm7-0001qN-QN for qemu-devel@nongnu.org; Tue, 06 Mar 2018 12:53:20 -0500 References: <864430f2a613c4d3c82b591ed7bc27068ddad369.1519961667.git.jbaron@akamai.com> <20180302195256-mutt-send-email-mst@kernel.org> From: Jason Baron Message-ID: Date: Tue, 6 Mar 2018 12:53:14 -0500 MIME-Version: 1.0 In-Reply-To: <20180302195256-mutt-send-email-mst@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/4] eth: add speed and duplex definitions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: jasowang@redhat.com, qemu-devel@nongnu.org, virtio-dev@lists.oasis-open.org On 03/02/2018 12:54 PM, Michael S. Tsirkin wrote: > On Thu, Mar 01, 2018 at 10:46:33PM -0500, Jason Baron wrote: >> Pull in definitions for SPEED_UNKNOWN, DUPLEX_UNKNOWN, DUPLEX_HALF, >> and DUPLEX_FULL. >> >> Signed-off-by: Jason Baron >> Cc: "Michael S. Tsirkin" >> Cc: Jason Wang >> Cc: virtio-dev@lists.oasis-open.org >> --- >> include/net/eth.h | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/include/net/eth.h b/include/net/eth.h >> index 09054a5..9843678 100644 >> --- a/include/net/eth.h >> +++ b/include/net/eth.h >> @@ -417,4 +417,11 @@ bool >> eth_parse_ipv6_hdr(const struct iovec *pkt, int pkt_frags, >> size_t ip6hdr_off, eth_ip6_hdr_info *info); >> >> +/* ethtool defines - from linux/ethtool.h */ >> +#define SPEED_UNKNOWN -1 >> + >> +#define DUPLEX_HALF 0x00 >> +#define DUPLEX_FULL 0x01 >> +#define DUPLEX_UNKNOWN 0xff >> + >> #endif > > While that's not a lot, I think we should import linux/ethtool.h into > include/standard-headers/linux/ using scripts/update-linux-headers.sh > Ok, I had started down that path, by including include/uapi/linux/ethtool.h but that resulted in a few other headers - kernel.h, sysinfo.h. And so it seemed like a lot of headers for only a few lines. But I will re-visit it... Thanks, -Jason From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: virtio-dev-return-3431-cohuck=redhat.com@lists.oasis-open.org Sender: List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [66.179.20.138]) by lists.oasis-open.org (Postfix) with ESMTP id ECB6F5818F21 for ; Tue, 6 Mar 2018 09:53:17 -0800 (PST) References: <864430f2a613c4d3c82b591ed7bc27068ddad369.1519961667.git.jbaron@akamai.com> <20180302195256-mutt-send-email-mst@kernel.org> From: Jason Baron Message-ID: Date: Tue, 6 Mar 2018 12:53:14 -0500 MIME-Version: 1.0 In-Reply-To: <20180302195256-mutt-send-email-mst@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: [virtio-dev] Re: [PATCH 1/4] eth: add speed and duplex definitions To: "Michael S. Tsirkin" Cc: jasowang@redhat.com, qemu-devel@nongnu.org, virtio-dev@lists.oasis-open.org List-ID: On 03/02/2018 12:54 PM, Michael S. Tsirkin wrote: > On Thu, Mar 01, 2018 at 10:46:33PM -0500, Jason Baron wrote: >> Pull in definitions for SPEED_UNKNOWN, DUPLEX_UNKNOWN, DUPLEX_HALF, >> and DUPLEX_FULL. >> >> Signed-off-by: Jason Baron >> Cc: "Michael S. Tsirkin" >> Cc: Jason Wang >> Cc: virtio-dev@lists.oasis-open.org >> --- >> include/net/eth.h | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/include/net/eth.h b/include/net/eth.h >> index 09054a5..9843678 100644 >> --- a/include/net/eth.h >> +++ b/include/net/eth.h >> @@ -417,4 +417,11 @@ bool >> eth_parse_ipv6_hdr(const struct iovec *pkt, int pkt_frags, >> size_t ip6hdr_off, eth_ip6_hdr_info *info); >> >> +/* ethtool defines - from linux/ethtool.h */ >> +#define SPEED_UNKNOWN -1 >> + >> +#define DUPLEX_HALF 0x00 >> +#define DUPLEX_FULL 0x01 >> +#define DUPLEX_UNKNOWN 0xff >> + >> #endif > > While that's not a lot, I think we should import linux/ethtool.h into > include/standard-headers/linux/ using scripts/update-linux-headers.sh > Ok, I had started down that path, by including include/uapi/linux/ethtool.h but that resulted in a few other headers - kernel.h, sysinfo.h. And so it seemed like a lot of headers for only a few lines. But I will re-visit it... Thanks, -Jason --------------------------------------------------------------------- To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org