From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1487C433F5 for ; Fri, 25 Mar 2022 09:21:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1356722AbiCYJXX (ORCPT ); Fri, 25 Mar 2022 05:23:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49688 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345014AbiCYJXX (ORCPT ); Fri, 25 Mar 2022 05:23:23 -0400 Received: from wp530.webpack.hosteurope.de (wp530.webpack.hosteurope.de [IPv6:2a01:488:42:1000:50ed:8234::]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2A99BCF49F; Fri, 25 Mar 2022 02:21:49 -0700 (PDT) Received: from ip4d144895.dynamic.kabel-deutschland.de ([77.20.72.149] helo=[192.168.66.200]); authenticated by wp530.webpack.hosteurope.de running ExIM with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) id 1nXg8U-00023m-32; Fri, 25 Mar 2022 10:21:34 +0100 Message-ID: Date: Fri, 25 Mar 2022 10:21:24 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [REGRESSION] Recent swiotlb DMA_FROM_DEVICE fixes break ath9k-based AP Content-Language: en-US To: Oleksandr Natalenko , Robin Murphy , Christoph Hellwig , Maxime Bizon , =?UTF-8?Q?Toke_H=c3=b8iland-J=c3=b8rgense?= =?UTF-8?Q?n?= Cc: Linus Torvalds , Halil Pasic , Marek Szyprowski , Kalle Valo , "David S. Miller" , Jakub Kicinski , Paolo Abeni , Olha Cherevyk , iommu , linux-wireless , Netdev , Linux Kernel Mailing List , Greg Kroah-Hartman , stable References: <1812355.tdWV9SEqCh@natalenko.name> <871qyr9t4e.fsf@toke.dk> <4699073.GXAFRqVoOG@natalenko.name> From: Thorsten Leemhuis In-Reply-To: <4699073.GXAFRqVoOG@natalenko.name> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-bounce-key: webpack.hosteurope.de;regressions@leemhuis.info;1648200109;1a0d0afe; X-HE-SMSGID: 1nXg8U-00023m-32 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 25.03.22 08:12, Oleksandr Natalenko wrote: > On čtvrtek 24. března 2022 18:07:29 CET Toke Høiland-Jørgensen wrote: >> Right, but is that sync_for_device call really needed? AFAICT, that >> ath9k_hw_process_rxdesc_edma() invocation doesn't actually modify any of >> the data when it returns EINPROGRESS, so could we just skip it? Like >> the patch below? Or am I misunderstanding the semantics here? >> >> diff --git a/drivers/net/wireless/ath/ath9k/recv.c b/drivers/net/wireless/ath/ath9k/recv.c >> index 0c0624a3b40d..19244d4c0ada 100644 >> --- a/drivers/net/wireless/ath/ath9k/recv.c >> +++ b/drivers/net/wireless/ath/ath9k/recv.c >> @@ -647,12 +647,8 @@ static bool ath_edma_get_buffers(struct ath_softc *sc, >> common->rx_bufsize, DMA_FROM_DEVICE); >> >> ret = ath9k_hw_process_rxdesc_edma(ah, rs, skb->data); >> - if (ret == -EINPROGRESS) { >> - /*let device gain the buffer again*/ >> - dma_sync_single_for_device(sc->dev, bf->bf_buf_addr, >> - common->rx_bufsize, DMA_FROM_DEVICE); >> + if (ret == -EINPROGRESS) >> return false; >> - } >> >> __skb_unlink(skb, &rx_edma->rx_fifo); >> if (ret == -EINVAL) { > > With this patch and both ddbd89deb7d3+aa6f8dcbab47 in place the AP works for me. TWIMC: If anyone needs more testers or something, I noticed two bug report in bko about this problem: https://bugzilla.kernel.org/show_bug.cgi?id=215703 https://bugzilla.kernel.org/show_bug.cgi?id=215698 I'll point both to this discussion and the patch. Ciao, Thorsten From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E6F7AC433FE for ; Fri, 25 Mar 2022 09:21:51 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 930B66107A; Fri, 25 Mar 2022 09:21:51 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id QH18SNarQv1o; Fri, 25 Mar 2022 09:21:49 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp3.osuosl.org (Postfix) with ESMTPS id 4CD2561074; Fri, 25 Mar 2022 09:21:49 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 21F2DC002C; Fri, 25 Mar 2022 09:21:49 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136]) by lists.linuxfoundation.org (Postfix) with ESMTP id D4341C0012 for ; Fri, 25 Mar 2022 09:21:47 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id B23406107A for ; Fri, 25 Mar 2022 09:21:47 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id k86FFudiqFnZ for ; Fri, 25 Mar 2022 09:21:46 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.8.0 Received: from wp530.webpack.hosteurope.de (wp530.webpack.hosteurope.de [IPv6:2a01:488:42:1000:50ed:8234::]) by smtp3.osuosl.org (Postfix) with ESMTPS id BE6E661074 for ; Fri, 25 Mar 2022 09:21:46 +0000 (UTC) Received: from ip4d144895.dynamic.kabel-deutschland.de ([77.20.72.149] helo=[192.168.66.200]); authenticated by wp530.webpack.hosteurope.de running ExIM with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) id 1nXg8U-00023m-32; Fri, 25 Mar 2022 10:21:34 +0100 Message-ID: Date: Fri, 25 Mar 2022 10:21:24 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [REGRESSION] Recent swiotlb DMA_FROM_DEVICE fixes break ath9k-based AP Content-Language: en-US To: Oleksandr Natalenko , Robin Murphy , Christoph Hellwig , Maxime Bizon , =?UTF-8?Q?Toke_H=c3=b8iland-J=c3=b8rgense?= =?UTF-8?Q?n?= References: <1812355.tdWV9SEqCh@natalenko.name> <871qyr9t4e.fsf@toke.dk> <4699073.GXAFRqVoOG@natalenko.name> From: Thorsten Leemhuis In-Reply-To: <4699073.GXAFRqVoOG@natalenko.name> X-bounce-key: webpack.hosteurope.de; regressions@leemhuis.info; 1648200106; 6db1eb40; X-HE-SMSGID: 1nXg8U-00023m-32 Cc: Netdev , Kalle Valo , linux-wireless , Linux Kernel Mailing List , stable , Halil Pasic , iommu , Olha Cherevyk , Greg Kroah-Hartman , Jakub Kicinski , Paolo Abeni , Linus Torvalds , "David S. Miller" X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" T24gMjUuMDMuMjIgMDg6MTIsIE9sZWtzYW5kciBOYXRhbGVua28gd3JvdGU6Cj4gT24gxI10dnJ0 ZWsgMjQuIGLFmWV6bmEgMjAyMiAxODowNzoyOSBDRVQgVG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu IHdyb3RlOgo+PiBSaWdodCwgYnV0IGlzIHRoYXQgc3luY19mb3JfZGV2aWNlIGNhbGwgcmVhbGx5 IG5lZWRlZD8gQUZBSUNULCB0aGF0Cj4+IGF0aDlrX2h3X3Byb2Nlc3NfcnhkZXNjX2VkbWEoKSBp bnZvY2F0aW9uIGRvZXNuJ3QgYWN0dWFsbHkgbW9kaWZ5IGFueSBvZgo+PiB0aGUgZGF0YSB3aGVu IGl0IHJldHVybnMgRUlOUFJPR1JFU1MsIHNvIGNvdWxkIHdlIGp1c3Qgc2tpcCBpdD8gTGlrZQo+ PiB0aGUgcGF0Y2ggYmVsb3c/IE9yIGFtIEkgbWlzdW5kZXJzdGFuZGluZyB0aGUgc2VtYW50aWNz IGhlcmU/Cj4+Cj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL25ldC93aXJlbGVzcy9hdGgvYXRoOWsv cmVjdi5jIGIvZHJpdmVycy9uZXQvd2lyZWxlc3MvYXRoL2F0aDlrL3JlY3YuYwo+PiBpbmRleCAw YzA2MjRhM2I0MGQuLjE5MjQ0ZDRjMGFkYSAxMDA2NDQKPj4gLS0tIGEvZHJpdmVycy9uZXQvd2ly ZWxlc3MvYXRoL2F0aDlrL3JlY3YuYwo+PiArKysgYi9kcml2ZXJzL25ldC93aXJlbGVzcy9hdGgv YXRoOWsvcmVjdi5jCj4+IEBAIC02NDcsMTIgKzY0Nyw4IEBAIHN0YXRpYyBib29sIGF0aF9lZG1h X2dldF9idWZmZXJzKHN0cnVjdCBhdGhfc29mdGMgKnNjLAo+PiAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIGNvbW1vbi0+cnhfYnVmc2l6ZSwgRE1BX0ZST01fREVWSUNFKTsKPj4gIAo+ PiAgICAgICAgIHJldCA9IGF0aDlrX2h3X3Byb2Nlc3NfcnhkZXNjX2VkbWEoYWgsIHJzLCBza2It PmRhdGEpOwo+PiAtICAgICAgIGlmIChyZXQgPT0gLUVJTlBST0dSRVNTKSB7Cj4+IC0gICAgICAg ICAgICAgICAvKmxldCBkZXZpY2UgZ2FpbiB0aGUgYnVmZmVyIGFnYWluKi8KPj4gLSAgICAgICAg ICAgICAgIGRtYV9zeW5jX3NpbmdsZV9mb3JfZGV2aWNlKHNjLT5kZXYsIGJmLT5iZl9idWZfYWRk ciwKPj4gLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb21tb24tPnJ4X2J1ZnNpemUs IERNQV9GUk9NX0RFVklDRSk7Cj4+ICsgICAgICAgaWYgKHJldCA9PSAtRUlOUFJPR1JFU1MpCj4+ ICAgICAgICAgICAgICAgICByZXR1cm4gZmFsc2U7Cj4+IC0gICAgICAgfQo+PiAgCj4+ICAgICAg ICAgX19za2JfdW5saW5rKHNrYiwgJnJ4X2VkbWEtPnJ4X2ZpZm8pOwo+PiAgICAgICAgIGlmIChy ZXQgPT0gLUVJTlZBTCkgewo+IAo+IFdpdGggdGhpcyBwYXRjaCBhbmQgYm90aCBkZGJkODlkZWI3 ZDMrYWE2ZjhkY2JhYjQ3IGluIHBsYWNlIHRoZSBBUCB3b3JrcyBmb3IgbWUuCgpUV0lNQzogSWYg YW55b25lIG5lZWRzIG1vcmUgdGVzdGVycyBvciBzb21ldGhpbmcsIEkgbm90aWNlZCB0d28gYnVn CnJlcG9ydCBpbiBia28gYWJvdXQgdGhpcyBwcm9ibGVtOgoKaHR0cHM6Ly9idWd6aWxsYS5rZXJu ZWwub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTU3MDMKaHR0cHM6Ly9idWd6aWxsYS5rZXJuZWwub3Jn L3Nob3dfYnVnLmNnaT9pZD0yMTU2OTgKCkknbGwgcG9pbnQgYm90aCB0byB0aGlzIGRpc2N1c3Np b24gYW5kIHRoZSBwYXRjaC4KCkNpYW8sIFRob3JzdGVuCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCmlvbW11IG1haWxpbmcgbGlzdAppb21tdUBsaXN0cy5s aW51eC1mb3VuZGF0aW9uLm9yZwpodHRwczovL2xpc3RzLmxpbnV4Zm91bmRhdGlvbi5vcmcvbWFp bG1hbi9saXN0aW5mby9pb21tdQ==