Re: [OE-core] [PATCH] base/patch: Disable network for unpack/patch/configure/compile/install

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Thu, 2021-12-23 at 12:31 +0100, Konrad Weihmann wrote:
> 
> On 23.12.21 11:49, Peter Kjellerstedt wrote:
> > > -----Original Message-----
> > > From: openembedded-core@lists.openembedded.org <openembedded-core@lists.openembedded.org> On Behalf Of Richard Purdie
> > > Sent: den 23 december 2021 00:21
> > > To: openembedded-core@lists.openembedded.org
> > > Subject: [OE-core] [PATCH] base/patch: Disable network for unpack/patch/configure/compile/install
> > > 
> > > Use the newly added nonetwork task flag to disable network access where
> > > possible in unpack/patch/configure/compile/install tasks.
> > > 
> > > We can't disable networking in sstate tasks due to sstate downloads and
> > > also so we can report hash equivalence to the server.
> > 
> > Since no tasks except fetch (and apparently the sstate tasks) are expected
> > to use the network, wouldn't it make more sense to reverse this flag? I.e.,
> > add do_fetch[network] = "1" instead. That way you don't get away with
> > adding some random task and using the network from it unless you explicitly
> > state that you will.
> 
> This is actually a brilliant idea, which would also make it easier to 
> control this behavior from a user's perspective

Part of me wonders if we really do want to make this "easy" for the user :/

Cheers,

Richard