From: Pierre Morel <pmorel@linux.ibm.com>
To: Thomas Huth <thuth@redhat.com>, kvm@vger.kernel.org
Cc: linux-s390@vger.kernel.org, frankja@linux.ibm.com,
david@redhat.com, cohuck@redhat.com, imbrenda@linux.ibm.com
Subject: Re: [kvm-unit-tests PATCH v1 2/5] s390x: css: simplifications of the tests
Date: Wed, 3 Feb 2021 11:10:36 +0100 [thread overview]
Message-ID: <a46eae99-0cb2-a775-3254-83dd8dfe1f83@linux.ibm.com> (raw)
In-Reply-To: <daf7ef77-98fc-3e29-d753-78b933a494d5@redhat.com>
On 2/2/21 6:29 PM, Thomas Huth wrote:
> On 29/01/2021 15.34, Pierre Morel wrote:
>> In order to ease the writing of tests based on:
...snip...
>> error_ccw:
>> free_io_mem(senseid, sizeof(*senseid));
>> -error_senseid:
>> - unregister_io_int_func(css_irq_io);
>> + return retval;
>> +}
>
> Maybe use "success" as a name for the variable instead of "retval"? ...
> since it's a boolean value...
yes, I do, thanks.
Pierre
--
Pierre Morel
IBM Lab Boeblingen
next prev parent reply other threads:[~2021-02-03 10:11 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1611930869-25745-1-git-send-email-pmorel@linux.ibm.com>
[not found] ` <1611930869-25745-4-git-send-email-pmorel@linux.ibm.com>
2021-02-02 11:48 ` [kvm-unit-tests PATCH v1 3/5] s390x: css: implementing Set CHannel Monitor Cornelia Huck
2021-02-02 16:15 ` Pierre Morel
2021-02-02 17:32 ` Thomas Huth
2021-02-03 10:09 ` Pierre Morel
[not found] ` <1611930869-25745-6-git-send-email-pmorel@linux.ibm.com>
2021-02-02 11:52 ` [kvm-unit-tests PATCH v1 5/5] s390x: css: testing measurement block format 1 Cornelia Huck
[not found] ` <1611930869-25745-2-git-send-email-pmorel@linux.ibm.com>
2021-02-01 10:01 ` [kvm-unit-tests PATCH v1 1/5] s390x: css: Store CSS Characteristics Janosch Frank
2021-02-01 12:09 ` Pierre Morel
2021-02-02 11:11 ` Cornelia Huck
2021-02-02 14:19 ` Pierre Morel
2021-02-02 17:25 ` Thomas Huth
2021-02-03 10:12 ` Pierre Morel
[not found] ` <1611930869-25745-3-git-send-email-pmorel@linux.ibm.com>
2021-02-01 10:11 ` [kvm-unit-tests PATCH v1 2/5] s390x: css: simplifications of the tests Janosch Frank
2021-02-01 12:15 ` Pierre Morel
2021-02-01 12:22 ` Janosch Frank
2021-02-02 11:23 ` Cornelia Huck
2021-02-02 14:39 ` Pierre Morel
2021-02-02 17:29 ` Thomas Huth
2021-02-03 10:10 ` Pierre Morel [this message]
[not found] ` <1611930869-25745-5-git-send-email-pmorel@linux.ibm.com>
2021-02-02 17:35 ` [kvm-unit-tests PATCH v1 4/5] s390x: css: SCHM tests format 0 Thomas Huth
2021-02-03 10:09 ` Pierre Morel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a46eae99-0cb2-a775-3254-83dd8dfe1f83@linux.ibm.com \
--to=pmorel@linux.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.