From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932610AbcIUGNY (ORCPT ); Wed, 21 Sep 2016 02:13:24 -0400 Received: from szxga02-in.huawei.com ([119.145.14.65]:24298 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932457AbcIUGNW (ORCPT ); Wed, 21 Sep 2016 02:13:22 -0400 Subject: Re: [PATCH v3] pwm: add pwm driver for HiSilicon BVT SOCs To: Rob Herring References: <1473645106-42266-1-git-send-email-yuanjian12@hisilicon.com> <20160920144348.GA22856@rob-hp-laptop> CC: , , , , , , , From: Jian Yuan Message-ID: Date: Wed, 21 Sep 2016 14:12:54 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160920144348.GA22856@rob-hp-laptop> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.209.117] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020204.57E224F2.0016,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: bf249b24549ce830113245a9e6f8583b Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016/9/20 22:43, Rob Herring wrote: > On Mon, Sep 12, 2016 at 09:51:46AM +0800, Jian Yuan wrote: >> From: yuanjian >> >> Add PWM driver for the PWM controller found on HiSilicon BVT SOCs, like Hi3519V100, Hi3516CV300, etc. >> The PWM controller is primarily in charge of controlling P-Iris lens. >> >> Reviewed-by: Jiancheng Xue >> Signed-off-by: Jian Yuan >> --- >> Change Log: >> v3: >> Add PWM compatible string for Hi3519V100. >> Implement .apply() function which support atomic, instead of .enable()/.disable()/.config(). >> v2: >> The number of PWMs is change to be probeable based on the compatible string. >> >> .../devicetree/bindings/pwm/pwm-hibvt.txt | 20 ++ >> drivers/pwm/Kconfig | 9 + >> drivers/pwm/Makefile | 1 + >> drivers/pwm/pwm-hibvt.c | 270 +++++++++++++++++++++ >> 4 files changed, 300 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/pwm/pwm-hibvt.txt >> create mode 100644 drivers/pwm/pwm-hibvt.c >> >> diff --git a/Documentation/devicetree/bindings/pwm/pwm-hibvt.txt b/Documentation/devicetree/bindings/pwm/pwm-hibvt.txt >> new file mode 100644 >> index 0000000..2ecf4e4 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/pwm/pwm-hibvt.txt >> @@ -0,0 +1,20 @@ >> +Hisilicon PWM controller >> + >> +Required properties: >> +-compatible: should contain one SoC specific compatible string and one generic compatible >> +string "hisilicon, hibvt-pwm". The SoC specific strings supported including: >> + "hisilicon,hi3516cv300-pwm" >> + "hisilicon,hi3519v100-pwm" >> +- reg: physical base address and length of the controller's registers. >> +- clocks: phandle and clock specifier of the PWM reference clock. >> +- resets: phandle and reset specifier for the PWM controller reset. > > You are missing #pwm-cells. > Ok, thanks. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jian Yuan Subject: Re: [PATCH v3] pwm: add pwm driver for HiSilicon BVT SOCs Date: Wed, 21 Sep 2016 14:12:54 +0800 Message-ID: References: <1473645106-42266-1-git-send-email-yuanjian12@hisilicon.com> <20160920144348.GA22856@rob-hp-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20160920144348.GA22856@rob-hp-laptop> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Rob Herring Cc: thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, linux-pwm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, xuejiancheng-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org, kevin.lixu-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org, jalen.hsu-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org List-Id: devicetree@vger.kernel.org On 2016/9/20 22:43, Rob Herring wrote: > On Mon, Sep 12, 2016 at 09:51:46AM +0800, Jian Yuan wrote: >> From: yuanjian >> >> Add PWM driver for the PWM controller found on HiSilicon BVT SOCs, like Hi3519V100, Hi3516CV300, etc. >> The PWM controller is primarily in charge of controlling P-Iris lens. >> >> Reviewed-by: Jiancheng Xue >> Signed-off-by: Jian Yuan >> --- >> Change Log: >> v3: >> Add PWM compatible string for Hi3519V100. >> Implement .apply() function which support atomic, instead of .enable()/.disable()/.config(). >> v2: >> The number of PWMs is change to be probeable based on the compatible string. >> >> .../devicetree/bindings/pwm/pwm-hibvt.txt | 20 ++ >> drivers/pwm/Kconfig | 9 + >> drivers/pwm/Makefile | 1 + >> drivers/pwm/pwm-hibvt.c | 270 +++++++++++++++++++++ >> 4 files changed, 300 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/pwm/pwm-hibvt.txt >> create mode 100644 drivers/pwm/pwm-hibvt.c >> >> diff --git a/Documentation/devicetree/bindings/pwm/pwm-hibvt.txt b/Documentation/devicetree/bindings/pwm/pwm-hibvt.txt >> new file mode 100644 >> index 0000000..2ecf4e4 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/pwm/pwm-hibvt.txt >> @@ -0,0 +1,20 @@ >> +Hisilicon PWM controller >> + >> +Required properties: >> +-compatible: should contain one SoC specific compatible string and one generic compatible >> +string "hisilicon, hibvt-pwm". The SoC specific strings supported including: >> + "hisilicon,hi3516cv300-pwm" >> + "hisilicon,hi3519v100-pwm" >> +- reg: physical base address and length of the controller's registers. >> +- clocks: phandle and clock specifier of the PWM reference clock. >> +- resets: phandle and reset specifier for the PWM controller reset. > > You are missing #pwm-cells. > Ok, thanks. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html