[PATCH bpf] bpf: selftests: Whitelist test_progs.h from .gitignore

[PATCH bpf] bpf: selftests: Whitelist test_progs.h from .gitignore

[Daniel Xu]

Somehow test_progs.h was being included by the existing rule:

    /test_progs*

This is bad because:

    1) test_progs.h is a checked in file
    2) grep-like tools like ripgrep[0] respect gitignore and
       test_progs.h was being hidden from searches

[0]: https://github.com/BurntSushi/ripgrep

Fixes: 74b5a5968fe8 ("selftests/bpf: Replace test_progs and test_maps w/
general rule")

Signed-off-by: Daniel Xu <dxu@dxuuu.xyz>
---
 tools/testing/selftests/bpf/.gitignore | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/testing/selftests/bpf/.gitignore b/tools/testing/selftests/bpf/.gitignore
index 4866f6a21901..d89efd9785d8 100644
--- a/tools/testing/selftests/bpf/.gitignore
+++ b/tools/testing/selftests/bpf/.gitignore
@@ -10,6 +10,7 @@ FEATURE-DUMP.libbpf
 fixdep
 test_dev_cgroup
 /test_progs*
+!test_progs.h
 test_verifier_log
 feature
 test_sock
-- 
2.31.1

Re: [PATCH bpf] bpf: selftests: Whitelist test_progs.h from .gitignore

[Andrii Nakryiko]

On Wed, Jun 16, 2021 at 2:52 PM Daniel Xu <dxu@dxuuu.xyz> wrote:
>
> Somehow test_progs.h was being included by the existing rule:
>
>     /test_progs*
>
> This is bad because:
>
>     1) test_progs.h is a checked in file
>     2) grep-like tools like ripgrep[0] respect gitignore and
>        test_progs.h was being hidden from searches
>

Nice find, thanks! That bothered me before, but not enough to investigate :)

> [0]: https://github.com/BurntSushi/ripgrep
>
> Fixes: 74b5a5968fe8 ("selftests/bpf: Replace test_progs and test_maps w/
> general rule")
>

Commit references in Fixes: tag shouldn't be wrapped. And there is no
need for an empty line. I can fix it up when applying, but just for
the future. And bpf-next is probably the right destination, I don't
think it needs to go through the bpf tree.

> Signed-off-by: Daniel Xu <dxu@dxuuu.xyz>
> ---
>  tools/testing/selftests/bpf/.gitignore | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/tools/testing/selftests/bpf/.gitignore b/tools/testing/selftests/bpf/.gitignore
> index 4866f6a21901..d89efd9785d8 100644
> --- a/tools/testing/selftests/bpf/.gitignore
> +++ b/tools/testing/selftests/bpf/.gitignore
> @@ -10,6 +10,7 @@ FEATURE-DUMP.libbpf
>  fixdep
>  test_dev_cgroup
>  /test_progs*
> +!test_progs.h
>  test_verifier_log
>  feature
>  test_sock
> --
> 2.31.1
>