All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: eesposit@redhat.com, qemu-block@nongnu.org, kwolf@redhat.com,
	mreitz@redhat.com
Subject: Re: [PATCH v2 1/5] qemu-iotests: do not buffer the test output
Date: Tue, 23 Mar 2021 21:57:01 +0300	[thread overview]
Message-ID: <a483830f-d2fb-1de0-bfea-bb90542a53c3@virtuozzo.com> (raw)
In-Reply-To: <192fb6f9-c913-2393-54e7-ffcc87be7467@virtuozzo.com>

23.03.2021 21:54, Vladimir Sementsov-Ogievskiy wrote:
>> +class ReproducibleTestRunner(unittest.TextTestRunner):
>> +    def __init__(self, stream: Optional[io.TextIOBase] = None,
>> +                 resultclass: Type = ReproducibleTestResult, *args, **kwargs):
> 
> actually, neither stream nor resultclass arguments are used in the code, so it seems we don't need them?

Ah, we probably should support them to be prepared for the following patch.

-- 
Best regards,
Vladimir


  reply	other threads:[~2021-03-23 19:45 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-23 18:19 [PATCH v2 0/5] qemu-iotests: quality of life improvements Paolo Bonzini
2021-03-23 18:19 ` [PATCH v2 1/5] qemu-iotests: do not buffer the test output Paolo Bonzini
2021-03-23 18:54   ` Vladimir Sementsov-Ogievskiy
2021-03-23 18:57     ` Vladimir Sementsov-Ogievskiy [this message]
2021-03-23 18:19 ` [PATCH v2 2/5] qemu-iotests: allow passing unittest.main arguments to the test scripts Paolo Bonzini
2021-03-23 19:02   ` Vladimir Sementsov-Ogievskiy
2021-03-23 19:17   ` Vladimir Sementsov-Ogievskiy
2021-03-23 21:22     ` Paolo Bonzini
2021-03-24  7:34       ` Vladimir Sementsov-Ogievskiy
2021-03-23 18:19 ` [PATCH v2 3/5] qemu-iotests: move command line and environment handling from TestRunner to TestEnv Paolo Bonzini
2021-03-23 18:19 ` [PATCH v2 4/5] qemu-iotests: let "check" spawn an arbitrary test command Paolo Bonzini
2021-03-23 19:12   ` Vladimir Sementsov-Ogievskiy
2021-03-23 21:20     ` Paolo Bonzini
2021-03-24  7:36       ` Vladimir Sementsov-Ogievskiy
2021-03-23 18:19 ` [PATCH v2 5/5] qemu-iotests: fix case of SOCK_DIR already in the environment Paolo Bonzini
2021-03-24 15:17 ` [PATCH v2 0/5] qemu-iotests: quality of life improvements Emanuele Giuseppe Esposito
2021-03-25 18:15 ` Max Reitz
2021-03-26  6:50   ` Paolo Bonzini
2021-03-26 13:40 ` Max Reitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a483830f-d2fb-1de0-bfea-bb90542a53c3@virtuozzo.com \
    --to=vsementsov@virtuozzo.com \
    --cc=eesposit@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.