From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anatoly Burakov Subject: [PATCH 3/3] vfio: fix uninitialized variable Date: Fri, 1 Jun 2018 10:08:12 +0100 Message-ID: References: <5f73e30c5159ff7476641036f2d81c78d15b38a3.1527843615.git.anatoly.burakov@intel.com> Cc: ferruh.yigit@intel.com, xiao.w.wang@intel.com, stable@dpdk.org To: dev@dpdk.org Return-path: In-Reply-To: <5f73e30c5159ff7476641036f2d81c78d15b38a3.1527843615.git.anatoly.burakov@intel.com> In-Reply-To: <5f73e30c5159ff7476641036f2d81c78d15b38a3.1527843615.git.anatoly.burakov@intel.com> References: <5f73e30c5159ff7476641036f2d81c78d15b38a3.1527843615.git.anatoly.burakov@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Some static analyzers complain about it, even though value is never used if not initialized. To avoid additional false positives about a potential null-pointer dereferences, also add a null-check. Bugzilla ID: 58 Fixes: ea2dc1066870 ("vfio: add multi container support") Cc: xiao.w.wang@intel.com Cc: stable@dpdk.org Signed-off-by: Anatoly Burakov --- lib/librte_eal/linuxapp/eal/eal_vfio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/librte_eal/linuxapp/eal/eal_vfio.c b/lib/librte_eal/linuxapp/eal/eal_vfio.c index a2bbdfbf4..4b7fcf3d6 100644 --- a/lib/librte_eal/linuxapp/eal/eal_vfio.c +++ b/lib/librte_eal/linuxapp/eal/eal_vfio.c @@ -1778,7 +1778,7 @@ int __rte_experimental rte_vfio_container_group_unbind(int container_fd, int iommu_group_num) { struct vfio_config *vfio_cfg; - struct vfio_group *cur_grp; + struct vfio_group *cur_grp = NULL; int i; vfio_cfg = get_vfio_cfg_by_container_fd(container_fd); @@ -1795,7 +1795,7 @@ rte_vfio_container_group_unbind(int container_fd, int iommu_group_num) } /* This should not happen */ - if (i == VFIO_MAX_GROUPS) { + if (i == VFIO_MAX_GROUPS || cur_grp == NULL) { RTE_LOG(ERR, EAL, "Specified group number not found\n"); return -1; } -- 2.17.0