From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1E44C433DB for ; Thu, 18 Feb 2021 16:23:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8F0E264E85 for ; Thu, 18 Feb 2021 16:23:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233282AbhBRQWt (ORCPT ); Thu, 18 Feb 2021 11:22:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34950 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231243AbhBRNiD (ORCPT ); Thu, 18 Feb 2021 08:38:03 -0500 Received: from mail.marcansoft.com (marcansoft.com [IPv6:2a01:298:fe:f::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3D46DC061574; Thu, 18 Feb 2021 05:37:16 -0800 (PST) Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: marcan@marcan.st) by mail.marcansoft.com (Postfix) with ESMTPSA id 806163FA55; Thu, 18 Feb 2021 13:37:09 +0000 (UTC) To: Krzysztof Kozlowski Cc: linux-arm-kernel@lists.infradead.org, Marc Zyngier , Rob Herring , Arnd Bergmann , Olof Johansson , Mark Kettenis , Tony Lindgren , Mohamed Mediouni , Stan Skowronek , Alexander Graf , Will Deacon , Linus Walleij , Mark Rutland , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210215121713.57687-1-marcan@marcan.st> <20210215121713.57687-19-marcan@marcan.st> <20210215182651.rjte67udhk3vhbsk@kozik-lap> From: Hector Martin Subject: Re: [PATCH v2 18/25] tty: serial: samsung_tty: add s3c24xx_port_type Message-ID: Date: Thu, 18 Feb 2021 22:37:03 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20210215182651.rjte67udhk3vhbsk@kozik-lap> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: es-ES Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16/02/2021 03.26, Krzysztof Kozlowski wrote: >> This removes s3c24xx_serial_has_interrupt_mask, which was just checking >> for a specific type anyway, and adds the ucon_mask port info member to >> avoid having S3C2440 as a distinct type. > > Please split setting the ucon_mask to separate patch. It's a nice > code simplification on its own. Done for v3. >> /* Unmask Tx interrupt */ >> - if (s3c24xx_serial_has_interrupt_mask(port)) >> - s3c24xx_clear_bit(port, S3C64XX_UINTM_TXD, >> - S3C64XX_UINTM); >> - else >> + switch (ourport->info->type) { >> + case TYPE_S3C6400: >> + s3c24xx_clear_bit(port, S3C64XX_UINTM_TXD, S3C64XX_UINTM); > > Please do not re-wrap. It makes reviewing more difficult. You can > perform proper re-wrapping as a separate cleanup patch. >> if (ourport->rx_enabled) { >> dev_dbg(port->dev, "stopping rx\n"); >> - if (s3c24xx_serial_has_interrupt_mask(port)) >> - s3c24xx_set_bit(port, S3C64XX_UINTM_RXD, >> - S3C64XX_UINTM); > > The same. Reverted those two lines for v3. -- Hector Martin (marcan@marcan.st) Public Key: https://mrcn.st/pub From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8998C433E0 for ; Thu, 18 Feb 2021 13:39:23 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 564C064E33 for ; Thu, 18 Feb 2021 13:39:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 564C064E33 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=marcan.st Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:Subject: From:References:To:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=d8h0GKrwfgTe6sw3H+Ej9/VDJoJndL+fhOr2tzOJs6o=; b=wO91mH5Y4nFPTSq1nIEK85RXx fvNNMzfsYFy5WgJ30EoA0Ov43BxxM7JIg7v2egOL3nxUq4Xgs/UK8TPMdSJKFhxTnze5qAWb95S88 CY5Q/wABm7kT6OSXIBVs0Vrp3ireye8gOfWnrmBn/K19vTYUwIk5IlzQHRg8FzHhyOLl5UiEjWC0I 3nlscwDeZmneg9eeH6HvUDJLWN0nPgm+AnZ8p7LnZ0zigueaGhO1KRR2ZncIWqFia6p1vj6/g3LJi qKMAC8b2FJ1IfttwMpQuAHtoXcvOixT4Pk+61+MDeUzTHjXQsQo3WRet2vM0qTRgLcTDD8/qt88S4 2/xLggRRA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lCjUd-000337-9d; Thu, 18 Feb 2021 13:37:19 +0000 Received: from marcansoft.com ([2a01:298:fe:f::2] helo=mail.marcansoft.com) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lCjUa-00032Y-8w for linux-arm-kernel@lists.infradead.org; Thu, 18 Feb 2021 13:37:17 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: marcan@marcan.st) by mail.marcansoft.com (Postfix) with ESMTPSA id 806163FA55; Thu, 18 Feb 2021 13:37:09 +0000 (UTC) To: Krzysztof Kozlowski References: <20210215121713.57687-1-marcan@marcan.st> <20210215121713.57687-19-marcan@marcan.st> <20210215182651.rjte67udhk3vhbsk@kozik-lap> From: Hector Martin Subject: Re: [PATCH v2 18/25] tty: serial: samsung_tty: add s3c24xx_port_type Message-ID: Date: Thu, 18 Feb 2021 22:37:03 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20210215182651.rjte67udhk3vhbsk@kozik-lap> Content-Language: es-ES X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210218_083716_440337_3A349158 X-CRM114-Status: GOOD ( 13.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Arnd Bergmann , Rob Herring , Tony Lindgren , Marc Zyngier , Linus Walleij , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Alexander Graf , Olof Johansson , Mohamed Mediouni , Stan Skowronek , Will Deacon , linux-arm-kernel@lists.infradead.org, Mark Kettenis Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 16/02/2021 03.26, Krzysztof Kozlowski wrote: >> This removes s3c24xx_serial_has_interrupt_mask, which was just checking >> for a specific type anyway, and adds the ucon_mask port info member to >> avoid having S3C2440 as a distinct type. > > Please split setting the ucon_mask to separate patch. It's a nice > code simplification on its own. Done for v3. >> /* Unmask Tx interrupt */ >> - if (s3c24xx_serial_has_interrupt_mask(port)) >> - s3c24xx_clear_bit(port, S3C64XX_UINTM_TXD, >> - S3C64XX_UINTM); >> - else >> + switch (ourport->info->type) { >> + case TYPE_S3C6400: >> + s3c24xx_clear_bit(port, S3C64XX_UINTM_TXD, S3C64XX_UINTM); > > Please do not re-wrap. It makes reviewing more difficult. You can > perform proper re-wrapping as a separate cleanup patch. >> if (ourport->rx_enabled) { >> dev_dbg(port->dev, "stopping rx\n"); >> - if (s3c24xx_serial_has_interrupt_mask(port)) >> - s3c24xx_set_bit(port, S3C64XX_UINTM_RXD, >> - S3C64XX_UINTM); > > The same. Reverted those two lines for v3. -- Hector Martin (marcan@marcan.st) Public Key: https://mrcn.st/pub _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel