From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4937CC3B187 for ; Tue, 11 Feb 2020 21:57:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2337220714 for ; Tue, 11 Feb 2020 21:57:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="gSXEVrGy" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727041AbgBKV5n (ORCPT ); Tue, 11 Feb 2020 16:57:43 -0500 Received: from mail26.static.mailgun.info ([104.130.122.26]:43278 "EHLO mail26.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727029AbgBKV5m (ORCPT ); Tue, 11 Feb 2020 16:57:42 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1581458262; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=jWU1cgqaUBb34RjRYJOYQVzFk/Z6wfMiJoxum7QsqVU=; b=gSXEVrGyFCVoUuDJ3IaOSi2sq7N3XQ39+d/ffmRKbpjCM3o0fQoqIRQg3Ws1Ieo9j7LJDI4D D9nalF/Ud1F9zCQB38i+SRbnNF/0l3SmQ5hrNGhSyKLN1lRof1rcJ5wu2L5SxUGGLggu/BKp gTQr8qbZbPb8r6P80FaJ75E8m6c= X-Mailgun-Sending-Ip: 104.130.122.26 X-Mailgun-Sid: WyI1MzIzYiIsICJsaW51eC1hcm0tbXNtQHZnZXIua2VybmVsLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5e43234e.7fd09eb3ae30-smtp-out-n03; Tue, 11 Feb 2020 21:57:34 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id D0813C447A2; Tue, 11 Feb 2020 21:57:33 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: saiprakash.ranjan) by smtp.codeaurora.org (Postfix) with ESMTPSA id 28EA1C43383; Tue, 11 Feb 2020 21:57:32 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 12 Feb 2020 03:27:32 +0530 From: Sai Prakash Ranjan To: Rob Herring Cc: Andy Gross , Bjorn Andersson , Guenter Roeck , devicetree@vger.kernel.org, Douglas Anderson , Stephen Boyd , Matthias Kaehlcke , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , linux-kernel@vger.kernel.org, linux-arm-msm , devicetree-owner@vger.kernel.org Subject: Re: [PATCHv2 2/2] dt-bindings: watchdog: Add compatible for QCS404, SC7180, SDM845, SM8150 In-Reply-To: References: <20200206183808.GA5019@bogus> Message-ID: X-Sender: saiprakash.ranjan@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 2020-02-11 23:54, Rob Herring wrote: > On Fri, Feb 7, 2020 at 12:10 AM Sai Prakash Ranjan > wrote: >> >> Hi Rob, >> >> On 2020-02-07 00:08, Rob Herring wrote: >> > On Sat, Feb 01, 2020 at 08:59:49PM +0530, Sai Prakash Ranjan wrote: >> >> Add missing compatible for watchdog timer on QCS404, >> >> SC7180, SDM845 and SM8150 SoCs. >> > >> > That's not what the commit does. You are changing what's valid. >> > >> > One string was valid, now 2 are required. >> > >> >> Does this look good? > > No. First of all, what's the base for the diff? It's not what you > originally had nor incremental on top of this patch. > It was an incremental on top of this patch. > Second, a value of 'qcom,kpss-timer' or 'qcom,kpss-wdt' or > 'qcom,scss-timer' will fail validation because 2 clauses of 'oneOf' > will be true. > I will just remove oneOf and add the missing compatibles to the enum. Thanks, Sai -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EEB6C35242 for ; Tue, 11 Feb 2020 21:57:59 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 116BC20714 for ; Tue, 11 Feb 2020 21:57:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="LLsN9er0"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="CgMPscwm" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 116BC20714 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:To:From: Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=PInUZpwCYhIYHZ6b/tMAQItMG++aSJUJy5tYn9RyV9w=; b=LLsN9er09K5wig402cFIMTkYN fgvC3vLTa9MT30x4J+z2vfcRQeY8X8he3OOfqeFqSDEbV3NBpugB/P9Pz/p97Oy/GZiBJxAAicGSS U4oZoiIG/W4Wnb04jxLSSGV788jETQ+1WazMVeKX5WX7vNnDHrAfSuuQOHUs3Y6p+mejdrSbxLQ/j UTKdW80a948NT5L7IP6i9UGJbDDDkVM4nhZ9YSkXIwaTmKUxJMBSb+aITXqOP9N/DJEzT1oPmLeYZ obsXJlgTBLBEAbC/ZOT1LL7dsToQxQ5DZLbUEbEGfExSAxl1+qOe4seF/u5BG78CzUUxO2HPIoMxd A/9b7ORFw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j1dXR-0005c2-0h; Tue, 11 Feb 2020 21:57:49 +0000 Received: from mail27.static.mailgun.info ([104.130.122.27]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j1dXN-0005az-GW for linux-arm-kernel@lists.infradead.org; Tue, 11 Feb 2020 21:57:47 +0000 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1581458263; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=jWU1cgqaUBb34RjRYJOYQVzFk/Z6wfMiJoxum7QsqVU=; b=CgMPscwmldN2g7uaV1VfzMjqNT4jzeY0PbHqR2ZQXWRSsla2/X1DMmX4mG5ldG4Q00F1iFkw D/eDBcsgZx6veczyYYQo3n3h44N/KBy6C7P02Gaa3llnmyKQkZy+NnUms1uDSrcc2Ad1aVD+ 0LSLroxvoxClxb4rUMlgIgax7Y4= X-Mailgun-Sending-Ip: 104.130.122.27 X-Mailgun-Sid: WyJiYzAxZiIsICJsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5e43234e.7fa0c32c7538-smtp-out-n01; Tue, 11 Feb 2020 21:57:34 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 8B915C447A0; Tue, 11 Feb 2020 21:57:33 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: saiprakash.ranjan) by smtp.codeaurora.org (Postfix) with ESMTPSA id 28EA1C43383; Tue, 11 Feb 2020 21:57:32 +0000 (UTC) MIME-Version: 1.0 Date: Wed, 12 Feb 2020 03:27:32 +0530 From: Sai Prakash Ranjan To: Rob Herring Subject: Re: [PATCHv2 2/2] dt-bindings: watchdog: Add compatible for QCS404, SC7180, SDM845, SM8150 In-Reply-To: References: <20200206183808.GA5019@bogus> Message-ID: X-Sender: saiprakash.ranjan@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200211_135745_611362_2099A46A X-CRM114-Status: GOOD ( 14.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, devicetree-owner@vger.kernel.org, linux-kernel@vger.kernel.org, Douglas Anderson , Stephen Boyd , Andy Gross , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , linux-arm-msm , Bjorn Andersson , Matthias Kaehlcke , Guenter Roeck Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2020-02-11 23:54, Rob Herring wrote: > On Fri, Feb 7, 2020 at 12:10 AM Sai Prakash Ranjan > wrote: >> >> Hi Rob, >> >> On 2020-02-07 00:08, Rob Herring wrote: >> > On Sat, Feb 01, 2020 at 08:59:49PM +0530, Sai Prakash Ranjan wrote: >> >> Add missing compatible for watchdog timer on QCS404, >> >> SC7180, SDM845 and SM8150 SoCs. >> > >> > That's not what the commit does. You are changing what's valid. >> > >> > One string was valid, now 2 are required. >> > >> >> Does this look good? > > No. First of all, what's the base for the diff? It's not what you > originally had nor incremental on top of this patch. > It was an incremental on top of this patch. > Second, a value of 'qcom,kpss-timer' or 'qcom,kpss-wdt' or > 'qcom,scss-timer' will fail validation because 2 clauses of 'oneOf' > will be true. > I will just remove oneOf and add the missing compatibles to the enum. Thanks, Sai -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel