Re: [PATCH mdadm v7 4/7] mdadm: Introduce pr_info()

[Paul Menzel <pmenzel@molgen.mpg.de>]

Dear Logan,


Am 01.03.23 um 21:41 schrieb Logan Gunthorpe:
> Feedback was given to avoid informational pr_err() calls that print
> to stderr, even though that's done all through out the code.
> 
> Using printf() directly doesn't maintain the same format (an "mdadm"
> prefix on every line.

Just a nit, that the closing ) is missing.

In the summary you could use: Introduce and use pr_info()

> So introduce pr_info() which prints to stdout with the same format
> and use it for a couple informational pr_err() calls in Create().
> 
> Future work can make this call used in more cases.
> 
> Signed-off-by: Logan Gunthorpe <logang@deltatee.com>
> Acked-by: Kinga Tanska <kinga.tanska@linux.intel.com>
> Reviewed-by: Xiao Ni <xni@redhat.com>
> Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
> Acked-by: Coly Li <colyli@suse.de>
> ---
>   Create.c | 7 ++++---
>   mdadm.h  | 2 ++
>   2 files changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/Create.c b/Create.c
> index 6a0446644e04..4acda30c5256 100644
> --- a/Create.c
> +++ b/Create.c
> @@ -984,11 +984,12 @@ int Create(struct supertype *st, char *mddev,
>   
>   			mdi = sysfs_read(-1, devnm, GET_VERSION);
>   
> -			pr_err("Creating array inside %s container %s\n",
> +			pr_info("Creating array inside %s container %s\n",
>   				mdi?mdi->text_version:"managed", devnm);
>   			sysfs_free(mdi);
>   		} else
> -			pr_err("Defaulting to version %s metadata\n", info.text_version);
> +			pr_info("Defaulting to version %s metadata\n",
> +				info.text_version);
>   	}
>   
>   	map_update(&map, fd2devnm(mdfd), info.text_version,
> @@ -1145,7 +1146,7 @@ int Create(struct supertype *st, char *mddev,
>   			ioctl(mdfd, RESTART_ARRAY_RW, NULL);
>   		}
>   		if (c->verbose >= 0)
> -			pr_err("array %s started.\n", mddev);
> +			pr_info("array %s started.\n", mddev);
>   		if (st->ss->external && st->container_devnm[0]) {
>   			if (need_mdmon)
>   				start_mdmon(st->container_devnm);
> diff --git a/mdadm.h b/mdadm.h
> index 13f8b4cb5a6b..8bd65fba1887 100644
> --- a/mdadm.h
> +++ b/mdadm.h
> @@ -1852,6 +1852,8 @@ static inline int xasprintf(char **strp, const char *fmt, ...) {
>   #endif
>   #define cont_err(fmt ...) fprintf(stderr, "       " fmt)
>   
> +#define pr_info(fmt, args...) printf("%s: "fmt, Name, ##args)
> +
>   void *xmalloc(size_t len);
>   void *xrealloc(void *ptr, size_t len);
>   void *xcalloc(size_t num, size_t size);

Acked-by: Paul Menzel <pmenzel@molgen.mpg.de>


Kind regards,

Paul