From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C74CEC4363C for ; Sun, 4 Oct 2020 18:47:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 709592068D for ; Sun, 4 Oct 2020 18:47:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="fcItKKls" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726330AbgJDSrd (ORCPT ); Sun, 4 Oct 2020 14:47:33 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:57001 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726288AbgJDSrd (ORCPT ); Sun, 4 Oct 2020 14:47:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1601837251; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6A91pVwAgeaoYz6zV+GlM5FMKvind26qqWKHM1z1Y6Y=; b=fcItKKlsP9Rj63JZ+RQvWUZEpn3PwyahrIZS/+jstQD5ipo3mCP6ZKkKDLzWEnriEasVh1 rkQdxAI/iHKacnwAOEvBCT/LrXUJZdnw5tHoHNY/IKEhvdfJKJBV2bRlGdU3iHTQwcAtH3 89p4rQ295lkcO7HbctN1kDwynQhAXcM= Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-257-wnBqD3sgNEOeDztkx_ztdQ-1; Sun, 04 Oct 2020 14:47:29 -0400 X-MC-Unique: wnBqD3sgNEOeDztkx_ztdQ-1 Received: by mail-qt1-f197.google.com with SMTP id t4so912324qtd.23 for ; Sun, 04 Oct 2020 11:47:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=6A91pVwAgeaoYz6zV+GlM5FMKvind26qqWKHM1z1Y6Y=; b=LLIYspXmGri2ZNc0DWDbUnd637kcfmehxze9Jj+/EjNw8PDMZgbxYhFTWSdHRVoawK JXpwlDSKO8AJnd72sSG2R/Ce68ZytXnBQwF4tTkgkgTfW1mvy8c8+iUOekb9/khlNWHf cC0EKouHHUxwXzcL4T9y+wBETi4p54kYAAyleLickHzkE1qMLpFQkl2nAKe1kr/Ds/0k pcFlPi+bRthFbW2X/PaEMjXiSCQUwvJB8n20UIHk2GUqeL2iKxT5TsmkxYeYsB8xHNqq qAD29Th9aUWIhQynP/2KaIYODgtmSvqnpgIoLO0JI71N4TkB8DT2CV9nnU1BS+b3yYUS bYAg== X-Gm-Message-State: AOAM53110dxg0yD+5bmcrUpGbNv/HJvA3Hiy56XtxJ4FDlso76si4t5F AqxpqOS74JxJY9KAcv/KTSDH/RWdaSm5r9HN/IC2am3R+pi8z3wY9ZoehelCHp++eXmlMjp1vaA FZ19Tx+sygh/zFgm5SuwYdj5w X-Received: by 2002:a05:620a:95e:: with SMTP id w30mr10991849qkw.403.1601837248823; Sun, 04 Oct 2020 11:47:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJze76mUl77FL6xMxcU6FHTIo213x/SKyFzCNyRACmRqaDpyiwpYUvw2QbFoE3Fv6YgOc57CNw== X-Received: by 2002:a05:620a:95e:: with SMTP id w30mr10991835qkw.403.1601837248596; Sun, 04 Oct 2020 11:47:28 -0700 (PDT) Received: from trix.remote.csb (075-142-250-213.res.spectrum.com. [75.142.250.213]) by smtp.gmail.com with ESMTPSA id o2sm5796485qkk.42.2020.10.04.11.47.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 04 Oct 2020 11:47:28 -0700 (PDT) Subject: Re: [PATCH 10/10] fpga: fpga-mgr: altera-pr-ip: Simplify registration To: Moritz Fischer , linux-fpga@vger.kernel.org Cc: hao.wu@intel.com, michal.simek@xilinx.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, russell.h.weight@intel.com, matthew.gerlach@intel.com References: <20201004051423.75879-1-mdf@kernel.org> <20201004051423.75879-11-mdf@kernel.org> From: Tom Rix Message-ID: Date: Sun, 4 Oct 2020 11:47:26 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20201004051423.75879-11-mdf@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/3/20 10:14 PM, Moritz Fischer wrote: > Simplify registration using new devm_fpga_mgr_register() API. > Remove the now obsolete altera_pr_unregister() function. > > Signed-off-by: Moritz Fischer > --- > > We should take another look at this, IIRC correctly the point of > splitting this up into a separate driver was to make it useable by a > different (pci?) driver later on. > > It doesn't seem like this happened, and I think we should just make this > a platform driver? > > --- > drivers/fpga/altera-pr-ip-core-plat.c | 10 ---------- > drivers/fpga/altera-pr-ip-core.c | 14 +------------- > include/linux/fpga/altera-pr-ip-core.h | 1 - > 3 files changed, 1 insertion(+), 24 deletions(-) > > diff --git a/drivers/fpga/altera-pr-ip-core-plat.c b/drivers/fpga/altera-pr-ip-core-plat.c > index 99b9cc0e70f0..b008a6b8d2d3 100644 > --- a/drivers/fpga/altera-pr-ip-core-plat.c > +++ b/drivers/fpga/altera-pr-ip-core-plat.c > @@ -28,15 +28,6 @@ static int alt_pr_platform_probe(struct platform_device *pdev) > return alt_pr_register(dev, reg_base); > } > > -static int alt_pr_platform_remove(struct platform_device *pdev) > -{ > - struct device *dev = &pdev->dev; > - > - alt_pr_unregister(dev); > - > - return 0; > -} > - > static const struct of_device_id alt_pr_of_match[] = { > { .compatible = "altr,a10-pr-ip", }, > {}, > @@ -46,7 +37,6 @@ MODULE_DEVICE_TABLE(of, alt_pr_of_match); > > static struct platform_driver alt_pr_platform_driver = { > .probe = alt_pr_platform_probe, > - .remove = alt_pr_platform_remove, > .driver = { > .name = "alt_a10_pr_ip", > .of_match_table = alt_pr_of_match, > diff --git a/drivers/fpga/altera-pr-ip-core.c b/drivers/fpga/altera-pr-ip-core.c > index 2cf25fd5e897..dfdf21ed34c4 100644 > --- a/drivers/fpga/altera-pr-ip-core.c > +++ b/drivers/fpga/altera-pr-ip-core.c > @@ -195,22 +195,10 @@ int alt_pr_register(struct device *dev, void __iomem *reg_base) > if (!mgr) > return -ENOMEM; > > - dev_set_drvdata(dev, mgr); > - > - return fpga_mgr_register(mgr); > + return devm_fpga_mgr_register(dev, mgr); > } > EXPORT_SYMBOL_GPL(alt_pr_register); > > -void alt_pr_unregister(struct device *dev) > -{ > - struct fpga_manager *mgr = dev_get_drvdata(dev); > - > - dev_dbg(dev, "%s\n", __func__); > - > - fpga_mgr_unregister(mgr); > -} > -EXPORT_SYMBOL_GPL(alt_pr_unregister); Similar to the others, except for removing this symbol. A patch should do one logical thing. I'd rather this be split out of the patchset. Tom > - > MODULE_AUTHOR("Matthew Gerlach "); > MODULE_DESCRIPTION("Altera Partial Reconfiguration IP Core"); > MODULE_LICENSE("GPL v2"); > diff --git a/include/linux/fpga/altera-pr-ip-core.h b/include/linux/fpga/altera-pr-ip-core.h > index 0b08ac20ab16..a6b4c07858cc 100644 > --- a/include/linux/fpga/altera-pr-ip-core.h > +++ b/include/linux/fpga/altera-pr-ip-core.h > @@ -13,6 +13,5 @@ > #include > > int alt_pr_register(struct device *dev, void __iomem *reg_base); > -void alt_pr_unregister(struct device *dev); > > #endif /* _ALT_PR_IP_CORE_H */ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A3CFC4363C for ; Sun, 4 Oct 2020 18:49:06 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 220C52068D for ; Sun, 4 Oct 2020 18:49:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="oq9svv3v"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="KwS6tCCz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 220C52068D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=dJcsKw+sSSqvTfnYehLt+ULYp8C8w3VV71cs8FbyQ0g=; b=oq9svv3v6MEOep3/u/3OZPMFK fP6wUOcSVs3Oi8eY2zkrDoSzDURoVVRwCvUXzo9gEcAFYxReMdT3K8z7LDodefFBLvW2ZKNHuA92y BvGDa+ok5F5AflRJ+q4V1Xh8lhjU+Ysd21rCaSnsUT1s3eN+OpqhW+qVK1mlc50fz6oTjSYgEWJgo 0CA04RyZc3LKhDGTVxim0Lpak9eUwEU5EVYstKixsWLZwaKDIWFhxQEXjMvlFVXItyeSB1XZKFvPw TTgA8j1bzQC3qhUht528Q2JINq7IYzTiIUDGgovZH+5yzhVdLrDkNZA27U2WXp98N4dSDvvkmhFYU RE91avH+Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kP92k-0002lJ-ME; Sun, 04 Oct 2020 18:47:34 +0000 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kP92h-0002kx-Dn for linux-arm-kernel@lists.infradead.org; Sun, 04 Oct 2020 18:47:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1601837250; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6A91pVwAgeaoYz6zV+GlM5FMKvind26qqWKHM1z1Y6Y=; b=KwS6tCCzVje0U7nqNmoG2DDvw5ss8CtYFbx0NYupzSr6u9zdiNw2mVVczEPHyFxCsoVQ7T 2+w9qvzYTHFsEXa+YJnyapLISlqxHNQp+Ayb938ZSwE6LeQKIYcO/b+tI+9y0PZxX3ImBS 0Wv9sBTWuNH44YxadB3EQYu98i3sS9M= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-204-VFDhi92AMrqC9-vAmmwPDQ-1; Sun, 04 Oct 2020 14:47:29 -0400 X-MC-Unique: VFDhi92AMrqC9-vAmmwPDQ-1 Received: by mail-qt1-f198.google.com with SMTP id y20so3580582qta.6 for ; Sun, 04 Oct 2020 11:47:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=6A91pVwAgeaoYz6zV+GlM5FMKvind26qqWKHM1z1Y6Y=; b=c2L1NDTMka4OWdOp7ulLUe5ManOoTlgO8fmxuDjb1LeHzSoWWsFOxbTz4QoCtJyKd2 0Ku5jCA+pCMB8JkvOZB8C96SNosoHhQmKd4FY3Fq9tb6JTUd/t3yDidUSBUhoU9LzixE hHLg2cssdlXLHhAJ1u/j4HBcKGNqBCsRIcROkCR11ZX4ZvKPd9OT1+PBhiLByBzaSJM3 iu/HrAmsN4aazYOP8lkDiWdmXgS3dr6+AHqg9clCzgvwSV4gtxZuBivod9uAHEiGTCcu tHDw3iPLHqtd57o6wNncQoto9O0c5GdzwKi1IRK8VinCil6Op9ECmlmTc6KLXwKVhVf2 qEhQ== X-Gm-Message-State: AOAM533tNaD+5lAh87OamAkX3ECsFIQ/PBaam3aZWEKMEwt5ZqxEMTIg 5nw/xzNdha59Rr7yU6h2K44suJo13yxM7gktUkPO8t+y1XY+dpMWByWMBtIyvZvc0rFOFpJR+JJ th5CzFQHpDKT1Uu+BhVJKPEMsLCIE4LdQvTk= X-Received: by 2002:a05:620a:95e:: with SMTP id w30mr10991851qkw.403.1601837248823; Sun, 04 Oct 2020 11:47:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJze76mUl77FL6xMxcU6FHTIo213x/SKyFzCNyRACmRqaDpyiwpYUvw2QbFoE3Fv6YgOc57CNw== X-Received: by 2002:a05:620a:95e:: with SMTP id w30mr10991835qkw.403.1601837248596; Sun, 04 Oct 2020 11:47:28 -0700 (PDT) Received: from trix.remote.csb (075-142-250-213.res.spectrum.com. [75.142.250.213]) by smtp.gmail.com with ESMTPSA id o2sm5796485qkk.42.2020.10.04.11.47.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 04 Oct 2020 11:47:28 -0700 (PDT) Subject: Re: [PATCH 10/10] fpga: fpga-mgr: altera-pr-ip: Simplify registration To: Moritz Fischer , linux-fpga@vger.kernel.org References: <20201004051423.75879-1-mdf@kernel.org> <20201004051423.75879-11-mdf@kernel.org> From: Tom Rix Message-ID: Date: Sun, 4 Oct 2020 11:47:26 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20201004051423.75879-11-mdf@kernel.org> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=trix@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201004_144731_503197_406C3543 X-CRM114-Status: GOOD ( 24.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: russell.h.weight@intel.com, linux-kernel@vger.kernel.org, matthew.gerlach@intel.com, michal.simek@xilinx.com, linux-arm-kernel@lists.infradead.org, hao.wu@intel.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10/3/20 10:14 PM, Moritz Fischer wrote: > Simplify registration using new devm_fpga_mgr_register() API. > Remove the now obsolete altera_pr_unregister() function. > > Signed-off-by: Moritz Fischer > --- > > We should take another look at this, IIRC correctly the point of > splitting this up into a separate driver was to make it useable by a > different (pci?) driver later on. > > It doesn't seem like this happened, and I think we should just make this > a platform driver? > > --- > drivers/fpga/altera-pr-ip-core-plat.c | 10 ---------- > drivers/fpga/altera-pr-ip-core.c | 14 +------------- > include/linux/fpga/altera-pr-ip-core.h | 1 - > 3 files changed, 1 insertion(+), 24 deletions(-) > > diff --git a/drivers/fpga/altera-pr-ip-core-plat.c b/drivers/fpga/altera-pr-ip-core-plat.c > index 99b9cc0e70f0..b008a6b8d2d3 100644 > --- a/drivers/fpga/altera-pr-ip-core-plat.c > +++ b/drivers/fpga/altera-pr-ip-core-plat.c > @@ -28,15 +28,6 @@ static int alt_pr_platform_probe(struct platform_device *pdev) > return alt_pr_register(dev, reg_base); > } > > -static int alt_pr_platform_remove(struct platform_device *pdev) > -{ > - struct device *dev = &pdev->dev; > - > - alt_pr_unregister(dev); > - > - return 0; > -} > - > static const struct of_device_id alt_pr_of_match[] = { > { .compatible = "altr,a10-pr-ip", }, > {}, > @@ -46,7 +37,6 @@ MODULE_DEVICE_TABLE(of, alt_pr_of_match); > > static struct platform_driver alt_pr_platform_driver = { > .probe = alt_pr_platform_probe, > - .remove = alt_pr_platform_remove, > .driver = { > .name = "alt_a10_pr_ip", > .of_match_table = alt_pr_of_match, > diff --git a/drivers/fpga/altera-pr-ip-core.c b/drivers/fpga/altera-pr-ip-core.c > index 2cf25fd5e897..dfdf21ed34c4 100644 > --- a/drivers/fpga/altera-pr-ip-core.c > +++ b/drivers/fpga/altera-pr-ip-core.c > @@ -195,22 +195,10 @@ int alt_pr_register(struct device *dev, void __iomem *reg_base) > if (!mgr) > return -ENOMEM; > > - dev_set_drvdata(dev, mgr); > - > - return fpga_mgr_register(mgr); > + return devm_fpga_mgr_register(dev, mgr); > } > EXPORT_SYMBOL_GPL(alt_pr_register); > > -void alt_pr_unregister(struct device *dev) > -{ > - struct fpga_manager *mgr = dev_get_drvdata(dev); > - > - dev_dbg(dev, "%s\n", __func__); > - > - fpga_mgr_unregister(mgr); > -} > -EXPORT_SYMBOL_GPL(alt_pr_unregister); Similar to the others, except for removing this symbol. A patch should do one logical thing. I'd rather this be split out of the patchset. Tom > - > MODULE_AUTHOR("Matthew Gerlach "); > MODULE_DESCRIPTION("Altera Partial Reconfiguration IP Core"); > MODULE_LICENSE("GPL v2"); > diff --git a/include/linux/fpga/altera-pr-ip-core.h b/include/linux/fpga/altera-pr-ip-core.h > index 0b08ac20ab16..a6b4c07858cc 100644 > --- a/include/linux/fpga/altera-pr-ip-core.h > +++ b/include/linux/fpga/altera-pr-ip-core.h > @@ -13,6 +13,5 @@ > #include > > int alt_pr_register(struct device *dev, void __iomem *reg_base); > -void alt_pr_unregister(struct device *dev); > > #endif /* _ALT_PR_IP_CORE_H */ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel