From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF2B5C433B4 for ; Fri, 23 Apr 2021 16:00:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 81C4661425 for ; Fri, 23 Apr 2021 16:00:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243289AbhDWQAo (ORCPT ); Fri, 23 Apr 2021 12:00:44 -0400 Received: from mga05.intel.com ([192.55.52.43]:62705 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243177AbhDWQAf (ORCPT ); Fri, 23 Apr 2021 12:00:35 -0400 IronPort-SDR: zh+H+j+kZJ4l2ZIoYH4e2WsfrzAv6xIqJjmR3S1lemrIOVAA0uTsqIijtHWi7LjVp7m0tpZ2nx K/iIUiwSrMGw== X-IronPort-AV: E=McAfee;i="6200,9189,9963"; a="281418077" X-IronPort-AV: E=Sophos;i="5.82,246,1613462400"; d="scan'208";a="281418077" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Apr 2021 08:59:58 -0700 IronPort-SDR: w9MlMKEafsoA2GnJcPHYgHXbBDKJtAUy0Zz1rc7GGzWPVqI4elo3AjtBMWhPWCMiTLrQej0ran 2vn64bGpfHGg== X-IronPort-AV: E=Sophos;i="5.82,246,1613462400"; d="scan'208";a="603576576" Received: from yyu32-mobl1.amr.corp.intel.com (HELO [10.212.37.160]) ([10.212.37.160]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Apr 2021 08:59:56 -0700 Subject: Re: [PATCH v25 21/30] mm: Re-introduce vm_flags to do_mmap() To: "Kirill A. Shutemov" Cc: x86@kernel.org, "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Borislav Petkov , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H.J. Lu" , Jann Horn , Jonathan Corbet , Kees Cook , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Peter Zijlstra , Randy Dunlap , "Ravi V. Shankar" , Vedvyas Shanbhogue , Dave Martin , Weijiang Yang , Pengfei Xu , Haitao Huang , Peter Collingbourne , Andrew Morton References: <20210415221419.31835-1-yu-cheng.yu@intel.com> <20210415221419.31835-22-yu-cheng.yu@intel.com> <20210423103114.3hheurux4ixccrwv@box.shutemov.name> From: "Yu, Yu-cheng" Message-ID: Date: Fri, 23 Apr 2021 08:59:55 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <20210423103114.3hheurux4ixccrwv@box.shutemov.name> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/23/2021 3:31 AM, Kirill A. Shutemov wrote: > On Thu, Apr 15, 2021 at 03:14:10PM -0700, Yu-cheng Yu wrote: >> There was no more caller passing vm_flags to do_mmap(), and vm_flags was >> removed from the function's input by: >> >> commit 45e55300f114 ("mm: remove unnecessary wrapper function do_mmap_pgoff()"). >> >> There is a new user now. Shadow stack allocation passes VM_SHADOW_STACK to >> do_mmap(). Thus, re-introduce vm_flags to do_mmap(). >> >> Signed-off-by: Yu-cheng Yu >> Reviewed-by: Peter Collingbourne >> Reviewed-by: Kees Cook >> Cc: Andrew Morton >> Cc: Oleg Nesterov >> Cc: linux-mm@kvack.org > > Reviewed-by: Kirill A. Shutemov > Thanks for reviewing. Yu-cheng