From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754351AbeDPMGr (ORCPT ); Mon, 16 Apr 2018 08:06:47 -0400 Received: from mail-wr0-f172.google.com ([209.85.128.172]:35859 "EHLO mail-wr0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753088AbeDPMGp (ORCPT ); Mon, 16 Apr 2018 08:06:45 -0400 X-Google-Smtp-Source: AIpwx49myGi+GSfCEIXiVWso00ASwIn+ONZ/2aKBbfIqpnGCtl8ot5RgKsEE6cu4HB+KX5BrUzSMzQ== Subject: Re: [PATCH 01/14] thermal: exynos: Reading temperature makes sense only when TMU is turned on To: Bartlomiej Zolnierkiewicz , Eduardo Valentin Cc: Zhang Rui , Krzysztof Kozlowski , Kukjin Kim , linux-samsung-soc@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Marek Szyprowski References: <1523873525-23718-1-git-send-email-b.zolnierkie@samsung.com> <1523873525-23718-2-git-send-email-b.zolnierkie@samsung.com> From: Daniel Lezcano Message-ID: Date: Mon, 16 Apr 2018 14:06:41 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <1523873525-23718-2-git-send-email-b.zolnierkie@samsung.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16/04/2018 12:11, Bartlomiej Zolnierkiewicz wrote: > From: Marek Szyprowski > > When thermal sensor is not yet enabled, reading temperature might return > random value. This might even result in stopping system booting when such > temperature is higher than the critical value. Fix this by checking if TMU > has been actually enabled before reading the temperature. > > This change fixes booting of Exynos4210-based board with TMU enabled (for > example Samsung Trats board), which was broken since v4.4 kernel release. Why not move the thermal_zone_of_sensor_register *after* initializing the sensor ? > Signed-off-by: Marek Szyprowski > Fixes: 9e4249b40340 ("thermal: exynos: Fix first temperature read after registering sensor") > CC: stable@vger.kernel.org # v4.6+ > Signed-off-by: Bartlomiej Zolnierkiewicz -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog