From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thorsten Leemhuis Subject: Re: [REGRESSION] 07ec51480b5e ("virtio_pci: use shared interrupts for virtqueues") causes crashes in guest Date: Thu, 23 Mar 2017 18:15:08 +0100 Message-ID: References: <43ffa887-a20d-f836-cba8-11196924d82d@redhat.com> <20170323151906.GA19376@redhat.com> <20170323184143-mutt-send-email-mst@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20170323184143-mutt-send-email-mst@kernel.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: "Michael S. Tsirkin" , "Richard W.M. Jones" Cc: Laura Abbott , virtualization@lists.linux-foundation.org, Christoph Hellwig , Linux Kernel Mailing List List-Id: virtualization@lists.linuxfoundation.org On 23.03.2017 17:41, Michael S. Tsirkin wrote: > On Thu, Mar 23, 2017 at 03:19:07PM +0000, Richard W.M. Jones wrote: >> On Thu, Mar 23, 2017 at 01:13:50PM +0800, Jason Wang wrote: >>> >From 312859b596e83a2164a8430343d31fce2a5ad808 Mon Sep 17 00:00:00 2001 >>> From: Jason Wang >>> Date: Thu, 23 Mar 2017 13:07:16 +0800 >>> Subject: [PATCH] virtio_pci: fix out of bound access for msix_names >>> Signed-off-by: Jason Wang >> I tested this, and it does appear to fix the crashes in >> vp_modern_find_vqs. Therefore: >> Tested-by: Richard W.M. Jones > I've queued the fix, thanks everyone! Thx. Feel free to add Tested-by: Thorsten Leemhuis as a kernel with that patch works well in my reboot tests so far. Ciao, Thorsten