From mboxrd@z Thu Jan  1 00:00:00 1970
From: Shreyansh Jain <shreyansh.jain@nxp.com>
Subject: Re: [PATCH v3 05/20] eal: introduce device class
 abstraction
Date: Tue, 27 Mar 2018 14:08:31 +0530
Message-ID: <a4a2b609-7e86-40a3-27f0-b0c56e9e7fd5@nxp.com>
References: <cover.1521652453.git.gaetan.rivet@6wind.com>
 <cover.1522105876.git.gaetan.rivet@6wind.com>
 <e0c27adffa2ce2b715cbe0b7bf9fdfc0d478c41b.1522105876.git.gaetan.rivet@6wind.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
To: Gaetan Rivet <gaetan.rivet@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 (mail-eopbgr20075.outbound.protection.outlook.com [40.107.2.75])
 by dpdk.org (Postfix) with ESMTP id 689F82C12
 for <dev@dpdk.org>; Tue, 27 Mar 2018 10:38:59 +0200 (CEST)
In-Reply-To: <e0c27adffa2ce2b715cbe0b7bf9fdfc0d478c41b.1522105876.git.gaetan.rivet@6wind.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 3/27/2018 4:48 AM, Gaetan Rivet wrote:
> Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>
> ---
>   lib/librte_eal/bsdapp/eal/Makefile         |   1 +
>   lib/librte_eal/common/Makefile             |   2 +-
>   lib/librte_eal/common/eal_common_class.c   |  62 +++++++++++++++
>   lib/librte_eal/common/include/rte_class.h  | 121 +++++++++++++++++++++++++++++
>   lib/librte_eal/common/include/rte_common.h |   1 +
>   lib/librte_eal/linuxapp/eal/Makefile       |   1 +
>   lib/librte_eal/rte_eal_version.map         |   2 +
>   7 files changed, 189 insertions(+), 1 deletion(-)
>   create mode 100644 lib/librte_eal/common/eal_common_class.c
>   create mode 100644 lib/librte_eal/common/include/rte_class.h
> 

[...]

> +
> +/**
> + * Class iterator to find a particular class.
> + *
> + * This function compares each registered class to find one that matches
> + * the data passed as parameter.
> + *
> + * If the comparison function returns zero this function will stop iterating
> + * over any more classes. To continue a search the class of a previous search
> + * can be passed via the start parameter.
> + *
> + * @param start
> + *	Starting point for the iteration.
> + *
> + * @param cmp
> + *	Comparison function.
> + *
> + * @param data
> + *	 Data to pass to comparison function.
> + *
> + * @return
> + *	 A pointer to a rte_bus structure or NULL in case no class matches

Trivial:               ^^^^^^^^
                 Should be rte_class

[...]

-
Shreyansh