From: "Christian König" <ckoenig.leichtzumerken-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Alex Deucher
<alexdeucher-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Harry Wentland <harry.wentland-5C7GfCeVMHo@public.gmane.org>
Cc: Christian Koenig <christian.koenig-5C7GfCeVMHo@public.gmane.org>,
amd-gfx list
<amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
Subject: Re: [PATCH v2] drm/amdgpu: Fix potential uninitialized use of 'idle' in amdgpu_ids.c
Date: Sun, 11 Feb 2018 10:36:25 +0100 [thread overview]
Message-ID: <a4ada0df-92a3-5be5-433e-53e0e4e68fdd@gmail.com> (raw)
In-Reply-To: <CADnq5_NERkHKMaZ+nhHzDq33J4=Em_4uUGXs7rj5A=bJmZpepA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
Am 09.02.2018 um 21:31 schrieb Alex Deucher:
> On Fri, Feb 9, 2018 at 1:49 PM, Harry Wentland <harry.wentland@amd.com> wrote:
>> v2: Use NULL and reverse christmas tree ordering
>>
>> Signed-off-by: Harry Wentland <harry.wentland@amd.com>
> Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
>
>> ---
>> drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c
>> index 7d2805729c20..563e74755aab 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c
>> @@ -406,7 +406,8 @@ int amdgpu_vmid_grab(struct amdgpu_vm *vm, struct amdgpu_ring *ring,
>> struct amdgpu_device *adev = ring->adev;
>> unsigned vmhub = ring->funcs->vmhub;
>> struct amdgpu_vmid_mgr *id_mgr = &adev->vm_manager.id_mgr[vmhub];
>> - struct amdgpu_vmid *id, *idle;
>> + struct amdgpu_vmid *idle = NULL;
>> + struct amdgpu_vmid *id = NULL;
>> int r = 0;
>>
>> mutex_lock(&id_mgr->lock);
>> --
>> 2.14.1
>>
>> _______________________________________________
>> amd-gfx mailing list
>> amd-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
prev parent reply other threads:[~2018-02-11 9:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-09 18:49 [PATCH v2] drm/amdgpu: Fix potential uninitialized use of 'idle' in amdgpu_ids.c Harry Wentland
[not found] ` <20180209184910.21679-1-harry.wentland-5C7GfCeVMHo@public.gmane.org>
2018-02-09 20:31 ` Alex Deucher
[not found] ` <CADnq5_NERkHKMaZ+nhHzDq33J4=Em_4uUGXs7rj5A=bJmZpepA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-02-11 9:36 ` Christian König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a4ada0df-92a3-5be5-433e-53e0e4e68fdd@gmail.com \
--to=ckoenig.leichtzumerken-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=alexdeucher-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=christian.koenig-5C7GfCeVMHo@public.gmane.org \
--cc=harry.wentland-5C7GfCeVMHo@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.