From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA0BEC433E0 for ; Fri, 5 Mar 2021 10:21:50 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8B82E64F4F for ; Fri, 5 Mar 2021 10:21:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8B82E64F4F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D8BC26EB5C; Fri, 5 Mar 2021 10:21:49 +0000 (UTC) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by gabe.freedesktop.org (Postfix) with ESMTP id 0B3456EB5C for ; Fri, 5 Mar 2021 10:21:48 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 56EF5101E; Fri, 5 Mar 2021 02:21:47 -0800 (PST) Received: from [192.168.1.179] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 751173F7D7; Fri, 5 Mar 2021 02:21:46 -0800 (PST) Subject: Re: [PATCH 0/2] Fix purging buffers in the shmem helpers To: Neil Roberts , Rob Herring , Tomeu Vizoso , Alyssa Rosenzweig , Robin Murphy References: <20210223155125.199577-1-nroberts@igalia.com> From: Steven Price Message-ID: Date: Fri, 5 Mar 2021 10:22:30 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210223155125.199577-1-nroberts@igalia.com> Content-Language: en-GB X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 23/02/2021 15:51, Neil Roberts wrote: > These two patches fix a problem with the madvise purging code for the > shmem helpers where the mmaping for a purged buffer wouldn't get > invalidated correctly. This presumably ends up as a security hole > where the mapping can be accessed from user-space to read and write > random pages from other buffers. This is currently affecting Panfrost. > The second patch is a v2 from a patch that was sent standalone. > > There is a WIP IGT test for Panfrost which demonstrates the bug here: > > https://gitlab.freedesktop.org/nroberts/igt-gpu-tools/-/commits/panfrost-purgemap/ > > Neil Roberts (2): > drm/shmem-helper: Check for purged buffers in fault handler > drm/shmem-helper: Don't remove the offset in vm_area_struct pgoff > > drivers/gpu/drm/drm_gem_shmem_helper.c | 25 ++++++++++++++++++------- > 1 file changed, 18 insertions(+), 7 deletions(-) > Pushed to drm-misc-fixes Thanks, Steve _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel