From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.4 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23602C48BE5 for ; Wed, 16 Jun 2021 08:42:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0563161241 for ; Wed, 16 Jun 2021 08:42:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232047AbhFPIod (ORCPT ); Wed, 16 Jun 2021 04:44:33 -0400 Received: from mga05.intel.com ([192.55.52.43]:13682 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232012AbhFPIoa (ORCPT ); Wed, 16 Jun 2021 04:44:30 -0400 IronPort-SDR: ub69TCHkezbFX2XHupt/7iETjThXS7heEMI9+6G/vGcDA8dmAd4lQBxdppHWmcECO4/zi0U5sx A7+/L5P0Gh9w== X-IronPort-AV: E=McAfee;i="6200,9189,10016"; a="291770840" X-IronPort-AV: E=Sophos;i="5.83,277,1616482800"; d="scan'208";a="291770840" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jun 2021 01:42:23 -0700 IronPort-SDR: XkMrx79+dB/mNC/PtGc2214acDd1tQm3kKMHkMe7U42BlYgoA1S0+ARJaX4DmyEBki/aLU+Wte 49DGkPS1dyLg== X-IronPort-AV: E=Sophos;i="5.83,277,1616482800"; d="scan'208";a="484805084" Received: from hchan3-mobl1.gar.corp.intel.com (HELO [10.254.212.123]) ([10.254.212.123]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jun 2021 01:42:20 -0700 Cc: baolu.lu@linux.intel.com, linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, linuxarm@huawei.com, thunder.leizhen@huawei.com, chenxiang66@hisilicon.com Subject: Re: [PATCH v12 3/5] iommu/vt-d: Add support for IOMMU default DMA mode build options To: Robin Murphy , John Garry , joro@8bytes.org, will@kernel.org, dwmw2@infradead.org References: <1623414043-40745-1-git-send-email-john.garry@huawei.com> <1623414043-40745-4-git-send-email-john.garry@huawei.com> <03675e2f-c3a6-ce33-ef96-f9ae544b2d13@huawei.com> <824db374-dc82-a9ea-b162-2f51e70ef999@linux.intel.com> From: Lu Baolu Message-ID: Date: Wed, 16 Jun 2021 16:42:18 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/6/15 16:25, Robin Murphy wrote: > On 2021-06-15 08:26, Lu Baolu wrote: >> Hi John, >> >> On 6/14/21 4:03 PM, John Garry wrote: >>> On 12/06/2021 03:14, Lu Baolu wrote: >>>> On 2021/6/11 20:20, John Garry wrote: >>>>> diff --git a/drivers/iommu/Kconfig b/drivers/iommu/Kconfig >>>>> index 2a71347611d4..4467353f981b 100644 >>>>> --- a/drivers/iommu/Kconfig >>>>> +++ b/drivers/iommu/Kconfig >>>>> @@ -94,6 +94,7 @@ choice >>>>>       prompt "IOMMU default DMA mode" >>>>>       depends on IOMMU_DMA >>>>> +    default IOMMU_DEFAULT_LAZY if INTEL_IOMMU >>>>>       default IOMMU_DEFAULT_STRICT >>>> >>>> If two default values are different. Which one will be overridden? >>> >>> If I understand your question correctly, I think you are asking if >>> both are set: >>> CONFIG_IOMMU_DEFAULT_LAZY=y >>> CONFIG_IOMMU_DEFAULT_STRICT=y >>> >>> If this happens, then make defconfig complains about both being set, >>> and selects the 2nd, whatever that is. >> >> On x86, Intel or AMD, this will be >> >>      prompt "IOMMU default DMA mode" >>        depends on IOMMU_DMA >>        default IOMMU_DEFAULT_LAZY >>        default IOMMU_DEFAULT_STRICT >> >> which will be default, LAZY or STRICT? Will it cause complains? > > See Documentation/kbuild/kconfig-language.rst: > >   A config option can have any number of default values. If multiple >   default values are visible, only the first defined one is active. Get it. Thank you, Robin. Best regards, baolu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.4 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34EC6C48BE6 for ; Wed, 16 Jun 2021 08:42:29 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A839A610EA for ; Wed, 16 Jun 2021 08:42:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A839A610EA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 74028827C9; Wed, 16 Jun 2021 08:42:28 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jGAgghAmXMw3; Wed, 16 Jun 2021 08:42:27 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp1.osuosl.org (Postfix) with ESMTPS id 7272582564; Wed, 16 Jun 2021 08:42:27 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 4462FC000E; Wed, 16 Jun 2021 08:42:27 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id E3849C000B for ; Wed, 16 Jun 2021 08:42:25 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id BA081401CF for ; Wed, 16 Jun 2021 08:42:25 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0Nl2QLJVTQWw for ; Wed, 16 Jun 2021 08:42:24 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by smtp2.osuosl.org (Postfix) with ESMTPS id A45D84017D for ; Wed, 16 Jun 2021 08:42:24 +0000 (UTC) IronPort-SDR: Sh0/ByB5VfuhBL3XSa4g9kKjR47RILAhJK0dtV8VaozvTUqYNvdvzj8V/SAvArndMSbAr6EiFM WqjiHItkSgAg== X-IronPort-AV: E=McAfee;i="6200,9189,10016"; a="291770841" X-IronPort-AV: E=Sophos;i="5.83,277,1616482800"; d="scan'208";a="291770841" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jun 2021 01:42:23 -0700 IronPort-SDR: XkMrx79+dB/mNC/PtGc2214acDd1tQm3kKMHkMe7U42BlYgoA1S0+ARJaX4DmyEBki/aLU+Wte 49DGkPS1dyLg== X-IronPort-AV: E=Sophos;i="5.83,277,1616482800"; d="scan'208";a="484805084" Received: from hchan3-mobl1.gar.corp.intel.com (HELO [10.254.212.123]) ([10.254.212.123]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jun 2021 01:42:20 -0700 Subject: Re: [PATCH v12 3/5] iommu/vt-d: Add support for IOMMU default DMA mode build options To: Robin Murphy , John Garry , joro@8bytes.org, will@kernel.org, dwmw2@infradead.org References: <1623414043-40745-1-git-send-email-john.garry@huawei.com> <1623414043-40745-4-git-send-email-john.garry@huawei.com> <03675e2f-c3a6-ce33-ef96-f9ae544b2d13@huawei.com> <824db374-dc82-a9ea-b162-2f51e70ef999@linux.intel.com> From: Lu Baolu Message-ID: Date: Wed, 16 Jun 2021 16:42:18 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US Cc: linuxarm@huawei.com, linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" T24gMjAyMS82LzE1IDE2OjI1LCBSb2JpbiBNdXJwaHkgd3JvdGU6Cj4gT24gMjAyMS0wNi0xNSAw ODoyNiwgTHUgQmFvbHUgd3JvdGU6Cj4+IEhpIEpvaG4sCj4+Cj4+IE9uIDYvMTQvMjEgNDowMyBQ TSwgSm9obiBHYXJyeSB3cm90ZToKPj4+IE9uIDEyLzA2LzIwMjEgMDM6MTQsIEx1IEJhb2x1IHdy b3RlOgo+Pj4+IE9uIDIwMjEvNi8xMSAyMDoyMCwgSm9obiBHYXJyeSB3cm90ZToKPj4+Pj4gZGlm ZiAtLWdpdCBhL2RyaXZlcnMvaW9tbXUvS2NvbmZpZyBiL2RyaXZlcnMvaW9tbXUvS2NvbmZpZwo+ Pj4+PiBpbmRleCAyYTcxMzQ3NjExZDQuLjQ0NjczNTNmOTgxYiAxMDA2NDQKPj4+Pj4gLS0tIGEv ZHJpdmVycy9pb21tdS9LY29uZmlnCj4+Pj4+ICsrKyBiL2RyaXZlcnMvaW9tbXUvS2NvbmZpZwo+ Pj4+PiBAQCAtOTQsNiArOTQsNyBAQCBjaG9pY2UKPj4+Pj4gwqDCoMKgwqDCoCBwcm9tcHQgIklP TU1VIGRlZmF1bHQgRE1BIG1vZGUiCj4+Pj4+IMKgwqDCoMKgwqAgZGVwZW5kcyBvbiBJT01NVV9E TUEKPj4+Pj4gK8KgwqDCoCBkZWZhdWx0IElPTU1VX0RFRkFVTFRfTEFaWSBpZiBJTlRFTF9JT01N VQo+Pj4+PiDCoMKgwqDCoMKgIGRlZmF1bHQgSU9NTVVfREVGQVVMVF9TVFJJQ1QKPj4+Pgo+Pj4+ IElmIHR3byBkZWZhdWx0IHZhbHVlcyBhcmUgZGlmZmVyZW50LiBXaGljaCBvbmUgd2lsbCBiZSBv dmVycmlkZGVuPwo+Pj4KPj4+IElmIEkgdW5kZXJzdGFuZCB5b3VyIHF1ZXN0aW9uIGNvcnJlY3Rs eSwgSSB0aGluayB5b3UgYXJlIGFza2luZyBpZiAKPj4+IGJvdGggYXJlIHNldDoKPj4+IENPTkZJ R19JT01NVV9ERUZBVUxUX0xBWlk9eQo+Pj4gQ09ORklHX0lPTU1VX0RFRkFVTFRfU1RSSUNUPXkK Pj4+Cj4+PiBJZiB0aGlzIGhhcHBlbnMsIHRoZW4gbWFrZSBkZWZjb25maWcgY29tcGxhaW5zIGFi b3V0IGJvdGggYmVpbmcgc2V0LCAKPj4+IGFuZCBzZWxlY3RzIHRoZSAybmQsIHdoYXRldmVyIHRo YXQgaXMuCj4+Cj4+IE9uIHg4NiwgSW50ZWwgb3IgQU1ELCB0aGlzIHdpbGwgYmUKPj4KPj4gwqDC oMKgwqDCoHByb21wdCAiSU9NTVUgZGVmYXVsdCBETUEgbW9kZSIKPj4gwqDCoMKgwqDCoMKgIGRl cGVuZHMgb24gSU9NTVVfRE1BCj4+IMKgwqDCoMKgwqDCoCBkZWZhdWx0IElPTU1VX0RFRkFVTFRf TEFaWQo+PiDCoMKgwqDCoMKgwqAgZGVmYXVsdCBJT01NVV9ERUZBVUxUX1NUUklDVAo+Pgo+PiB3 aGljaCB3aWxsIGJlIGRlZmF1bHQsIExBWlkgb3IgU1RSSUNUPyBXaWxsIGl0IGNhdXNlIGNvbXBs YWlucz8KPiAKPiBTZWUgRG9jdW1lbnRhdGlvbi9rYnVpbGQva2NvbmZpZy1sYW5ndWFnZS5yc3Q6 Cj4gCj4gIMKgIEEgY29uZmlnIG9wdGlvbiBjYW4gaGF2ZSBhbnkgbnVtYmVyIG9mIGRlZmF1bHQg dmFsdWVzLiBJZiBtdWx0aXBsZQo+ICDCoCBkZWZhdWx0IHZhbHVlcyBhcmUgdmlzaWJsZSwgb25s eSB0aGUgZmlyc3QgZGVmaW5lZCBvbmUgaXMgYWN0aXZlLgoKR2V0IGl0LiBUaGFuayB5b3UsIFJv YmluLgoKQmVzdCByZWdhcmRzLApiYW9sdQpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwppb21tdSBtYWlsaW5nIGxpc3QKaW9tbXVAbGlzdHMubGludXgtZm91 bmRhdGlvbi5vcmcKaHR0cHM6Ly9saXN0cy5saW51eGZvdW5kYXRpb24ub3JnL21haWxtYW4vbGlz dGluZm8vaW9tbXU=