From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id C64A510E1BE for ; Wed, 28 Dec 2022 18:44:19 +0000 (UTC) Message-ID: Date: Thu, 29 Dec 2022 00:13:57 +0530 MIME-Version: 1.0 Content-Language: en-US To: Bhanuprakash Modem , igt-dev@lists.freedesktop.org References: <20221115170855.196572-1-bhanuprakash.modem@intel.com> <20221115170855.196572-45-bhanuprakash.modem@intel.com> From: Swati Sharma In-Reply-To: <20221115170855.196572-45-bhanuprakash.modem@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [igt-dev] [i-g-t v5 44/52] tests/i915/kms_flip_scaled_crc: Add support for Bigjoiner List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: On 15-Nov-22 10:38 PM, Bhanuprakash Modem wrote: > This patch will add a check to Skip the subtest if a selected pipe/output > combo won't support Bigjoiner or 8K mode. > > Example: > * Pipe-D wont support a mode > 5K > * To use 8K mode on a pipe then consecutive pipe must be available & free. > > V2: - Use updated helper name > > Signed-off-by: Bhanuprakash Modem > --- > tests/i915/kms_flip_scaled_crc.c | 13 ++++++++++++- > 1 file changed, 12 insertions(+), 1 deletion(-) > > diff --git a/tests/i915/kms_flip_scaled_crc.c b/tests/i915/kms_flip_scaled_crc.c > index 10465ca7..1b497dcc 100644 > --- a/tests/i915/kms_flip_scaled_crc.c > +++ b/tests/i915/kms_flip_scaled_crc.c > @@ -648,8 +648,13 @@ igt_main > for_each_pipe(&data.display, pipe) { > bool found = false; > for_each_valid_output_on_pipe(&data.display, pipe, output) { > + igt_display_reset(&data.display); > + > modetoset = find_mode(&data, output); > - if (modetoset) { > + igt_output_set_pipe(output, pipe); > + igt_output_override_mode(output, modetoset); >> why we have to override mode here? > + > + if (modetoset && i915_pipe_output_combo_valid(&data.display)) { > found = true; > igt_dynamic_f("pipe-%s-valid-mode", kmstest_pipe_name(pipe)) > run_tests(&data, index, pipe, output, modetoset); > @@ -658,6 +663,12 @@ igt_main > } > if (!found) { > for_each_valid_output_on_pipe(&data.display, pipe, output) { > + igt_display_reset(&data.display); > + > + igt_output_set_pipe(output, pipe); > + if (!i915_pipe_output_combo_valid(&data.display)) > + continue; > + > igt_dynamic_f("pipe-%s-default-mode", kmstest_pipe_name(pipe)) > run_tests(&data, index, pipe, output, modetoset); > } -- ~Swati Sharma